Merge branch 'RED-9132-bp' into 'release/4.244.x'

RED-9132 - Remove debug information from Paragraph/Location field

See merge request redactmanager/redaction-service!402
This commit is contained in:
Corina Olariu 2024-05-17 14:18:44 +02:00
commit f05f1fd9b3
2 changed files with 11 additions and 2 deletions

View File

@ -33,6 +33,7 @@ import com.iqser.red.service.redaction.v1.server.model.document.entity.TextEntit
import com.iqser.red.service.redaction.v1.server.model.document.nodes.Document;
import com.iqser.red.service.redaction.v1.server.model.document.nodes.Image;
import com.iqser.red.service.redaction.v1.server.model.document.nodes.ImageType;
import com.iqser.red.service.redaction.v1.server.model.document.nodes.SemanticNode;
import com.iqser.red.service.redaction.v1.server.storage.RedactionStorageService;
import lombok.AccessLevel;
@ -201,7 +202,7 @@ public class EntityLogCreatorService {
.containingNodeId(image.getTreeId())
.closestHeadline(image.getHeadline().getTextBlock().getSearchText())
.section(image.getManualOverwrite().getSection()
.orElse(image.getParent().toString()))
.orElse(this.buildSectionString(image.getParent())))
.imageHasTransparency(image.isTransparent())
.manualChanges(ManualChangeFactory.toLocalManualChangeList(image.getManualOverwrite().getManualChangeLog(), true))
.state(buildEntryState(image))
@ -267,7 +268,7 @@ public class EntityLogCreatorService {
.orElse(entity.getMatchedRule().isWriteValueWithLineBreaks() ? entity.getValueWithLineBreaks() : entity.getValue()))
.type(entity.type())
.section(entity.getManualOverwrite().getSection()
.orElse(entity.getDeepestFullyContainingNode().toString()))
.orElse(this.buildSectionString(entity.getDeepestFullyContainingNode())))
.containingNodeId(entity.getDeepestFullyContainingNode().getTreeId())
.closestHeadline(entity.getDeepestFullyContainingNode().getHeadline().getTextBlock().getSearchText())
.matchedRule(entity.getMatchedRule().getRuleIdentifier().toString())
@ -355,4 +356,10 @@ public class EntityLogCreatorService {
.collect(Collectors.toList());
}
private String buildSectionString(SemanticNode node) {
return node.getType().toString() + ": " + node.getTextBlock().buildSummary();
}
}

View File

@ -138,8 +138,10 @@ public class RedactionAcceptanceTest extends AbstractRedactionIntegrationTest {
var publishedInformationEntry1 = findEntityByTypeAndValue(entityLog, "published_information", "Oxford University Press").findFirst()
.orElseThrow();
assertThat(publishedInformationEntry1.getSection().startsWith("Paragraph:"));
var asyaLyon1 = findEntityByTypeAndValueAndSectionNumber(entityLog, "CBI_author", "Asya Lyon", publishedInformationEntry1.getContainingNodeId()).findFirst()
.orElseThrow();
assertThat(publishedInformationEntry1.getSection().startsWith("Paragraph:"));
assertEquals(EntryState.SKIPPED, asyaLyon1.getState());