Marmelator/redaction-service
1
0
Fork 0
Code Issues Pull Requests 14 Actions Packages Projects Releases 622 Wiki Activity

RED-7784 - Add position to UnprocessedManualEntity #180

Merged
andrei.isvoran.ext merged 1 commits from RED-7785-position into master 2023-10-26 12:00:57 +02:00
Conversation 13 Commits 1 Files Changed 3 +45 -24
andrei.isvoran.ext commented 2023-10-26 10:57:32 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Closes RED-7785

Closes RED-7785
kilian.schuettler1 (Migrated from gitlab.knecon.com) approved these changes 2023-10-26 10:57:32 +02:00
corina.olariu.ext1 (Migrated from gitlab.knecon.com) approved these changes 2023-10-26 10:57:32 +02:00
ali.oezyetimoglu1 (Migrated from gitlab.knecon.com) approved these changes 2023-10-26 10:57:32 +02:00
andrei.isvoran.ext commented 2023-10-26 10:57:33 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @andrei.isvoran.ext

assigned to @andrei.isvoran.ext
andrei.isvoran.ext commented 2023-10-26 10:58:10 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

requested review from @ali.oezyetimoglu1, @corina.olariu.ext1, @kilian.schuettler1, @dominique.eiflaender1, and @yannik.hampe

requested review from @ali.oezyetimoglu1, @corina.olariu.ext1, @kilian.schuettler1, @dominique.eiflaender1, and @yannik.hampe
andrei.isvoran.ext commented 2023-10-26 11:00:51 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

requested review from @timo.bejan.ext

requested review from @timo.bejan.ext
kilian.schuettler1 commented 2023-10-26 11:33:01 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

⁠When created via ManualEntity it is certain that every TextEntity is on exactly one page. Therefore the logic you copied from EntityLogCreatorService is unnecessary here and you can just do textEntity.getPositionsOnPagePerPage().get(0)

⁠When created via ManualEntity it is certain that every TextEntity is on exactly one page. Therefore the logic you copied from EntityLogCreatorService is unnecessary here and you can just do textEntity.getPositionsOnPagePerPage().get(0)
kilian.schuettler1 commented 2023-10-26 11:34:13 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

But i'm fine with leaving it as is

But i'm fine with leaving it as is
kilian.schuettler1 commented 2023-10-26 11:34:21 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
kilian.schuettler1 commented 2023-10-26 11:59:17 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

resolved all threads

resolved all threads
corina.olariu.ext1 commented 2023-10-26 12:00:21 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
ali.oezyetimoglu1 commented 2023-10-26 12:00:29 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
andrei.isvoran.ext commented 2023-10-26 12:00:58 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

mentioned in commit a248460e70

mentioned in commit a248460e707ad6ad3b6e076120ba7faa5779036a
andrei.isvoran.ext (Migrated from gitlab.knecon.com) merged commit a248460e70 into master 2023-10-26 12:00:58 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
kilian.schuettler1
corina.olariu.ext1
ali.oezyetimoglu1
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/redaction-service#180
No description provided.
Delete Branch "RED-7785-position"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?