Merge branch 'RED-8171' into 'master'

RED-8171: Traces do not stop at @Async

See merge request fforesight/ocr-service!39

buildSrc/src/main/kotlin/com.iqser.red.service.java-conventions.gradle.kts

@@ -12,6 +12,10 @@ group = "com.knecon.fforesight.service"
 java.sourceCompatibility = JavaVersion.VERSION_17
 java.targetCompatibility = JavaVersion.VERSION_17
 
+pmd {
+    isConsoleOutput = true
+}
+
 tasks.pmdMain {
     pmd.ruleSetFiles = files("${rootDir}/config/pmd/pmd.xml")
 }

config/pmd/pmd.xml

@@ -9,12 +9,12 @@
     </description>
 
     <rule ref="category/java/errorprone.xml">
-        <exclude name="DataflowAnomalyAnalysis"/>
         <exclude name="MissingSerialVersionUID"/>
-        <exclude name="NullAssignment"/>
         <exclude name="AvoidLiteralsInIfCondition"/>
         <exclude name="AvoidDuplicateLiterals"/>
-        <exclude name="AvoidFieldNameMatchingMethodName"/>
+        <exclude name="NullAssignment"/>
+        <exclude name="AssignmentInOperand"/>
+        <exclude name="BeanMembersShouldSerialize"/>
     </rule>
 
-</ruleset>
+</ruleset>

config/pmd/test_pmd.xml

@@ -10,14 +10,13 @@
 
 
     <rule ref="category/java/errorprone.xml">
-        <exclude name="DataflowAnomalyAnalysis"/>
         <exclude name="MissingSerialVersionUID"/>
-        <exclude name="NullAssignment"/>
         <exclude name="AvoidLiteralsInIfCondition"/>
         <exclude name="AvoidDuplicateLiterals"/>
-        <exclude name="AvoidFieldNameMatchingMethodName"/>
-        <exclude name="AvoidFieldNameMatchingTypeName"/>
+        <exclude name="NullAssignment"/>
+        <exclude name="AssignmentInOperand"/>
         <exclude name="TestClassWithoutTestCases"/>
+        <exclude name="BeanMembersShouldSerialize"/>
     </rule>
 
-</ruleset>
+</ruleset>

ocr-service-v1/ocr-service-api/build.gradle.kts

@@ -1,7 +1,7 @@
 plugins {
     `maven-publish`
     id("com.iqser.red.service.java-conventions")
-    id("io.freefair.lombok") version "8.2.2"
+    id("io.freefair.lombok") version "8.4"
 }
 
 publishing {

ocr-service-v1/ocr-service-processor/build.gradle.kts

@@ -1,6 +1,6 @@
 plugins {
     id("com.iqser.red.service.java-conventions")
-    id("io.freefair.lombok") version "8.2.2"
+    id("io.freefair.lombok") version "8.4"
 }
 
 configurations {
@@ -14,7 +14,7 @@ dependencies {
     api("net.sourceforge.tess4j:tess4j:5.8.0")
     api("com.iqser.red.commons:metric-commons:2.1.0")
     api("com.iqser.red.commons:storage-commons:2.45.0")
-    api("com.knecon.fforesight:tenant-commons:0.19.0")
+    api("com.knecon.fforesight:tenant-commons:0.21.0")
     api("com.pdftron:PDFNet:10.5.0")
     api("org.apache.pdfbox:pdfbox:3.0.0")
     api("org.apache.pdfbox:jbig2-imageio:3.0.4")
@@ -24,6 +24,6 @@ dependencies {
     api("io.github.karols:hocr4j:0.2.0")
     api("com.amazonaws:aws-java-sdk-kms:1.12.440")
     api("com.google.guava:guava:31.1-jre")
-    api("com.iqser.red.commons:pdftron-logic-commons:2.20.0")
+    api("com.iqser.red.commons:pdftron-logic-commons:2.23.0")
     testImplementation("org.junit.jupiter:junit-jupiter:5.8.1")
 }

ocr-service-v1/ocr-service-processor/src/main/java/com/knecon/fforesight/service/ocr/processor/service/OCRService.java

@@ -28,6 +28,8 @@ import com.knecon.fforesight.service.ocr.processor.service.scriptdetection.FontS
 import com.knecon.fforesight.service.ocr.processor.service.threads.OCRThread;
 import com.knecon.fforesight.service.ocr.processor.settings.OcrServiceSettings;
 
+import io.micrometer.observation.ObservationRegistry;
+import io.micrometer.observation.annotation.Observed;
 import lombok.AccessLevel;
 import lombok.RequiredArgsConstructor;
 import lombok.SneakyThrows;
@@ -48,6 +50,7 @@ public class OCRService {
     OcrResultWriter ocrResultWriter;
     GhostScriptService ghostScriptService;
     FontStyleDetector boldDetector;
+    ObservationRegistry registry;
 
 
     /**
@@ -59,12 +62,13 @@ public class OCRService {
      * @param fileId    Id of file
      * @param out       OutputStream where to write to
      */
+    @Observed(name = "OCRService", contextualName = "run-ocr-on-document")
     @SneakyThrows
     public void runOcrOnDocument(String dossierId, String fileId, OutputStream out) {
 
         try (InputStream fileStream = removeWatermarkIfEnabled(dossierId, fileId); ByteArrayOutputStream transferOutputStream = new ByteArrayOutputStream()) {
 
-            invisibleElementRemovalService.removeInvisibleElements(fileStream, transferOutputStream, false);
+            invisibleElementRemovalService.removeInvisibleElements(fileStream, transferOutputStream, false, false);
 
             try (InputStream transferInputStream = new ByteArrayInputStream(transferOutputStream.toByteArray())) {
                 log.info("Starting OCR for file {}", fileId);

ocr-service-v1/ocr-service-processor/src/main/java/com/knecon/fforesight/service/ocr/processor/service/fonts/Type0FontMetricsFactory.java

@@ -44,6 +44,8 @@ public class Type0FontMetricsFactory implements FontMetricsFactory {
 
 
     @SneakyThrows
+    @SuppressWarnings("PMD.CloseResource")
+    // Todo i think this is not ok to never close the font...
     private static Type0FontMetricsFactory createFromResource(String resourcePath, PDDocument document) {
 
         try (var in = Thread.currentThread().getContextClassLoader().getResourceAsStream(resourcePath); var buffer = new RandomAccessReadBuffer(in)) {

ocr-service-v1/ocr-service-processor/src/main/java/com/knecon/fforesight/service/ocr/processor/service/threads/GhostScriptOutputHandler.java

@@ -109,7 +109,6 @@ public class GhostScriptOutputHandler extends Thread {
         if (imageFile == null) {
             throw new IllegalArgumentException(String.format("Page number %d does not exist in this thread. It only has pagenumbers %s", pageNumber, pagesToProcess.keySet()));
         }
-        assert new File(imageFile.absoluteFilePath()).isFile();
         renderedPageImageFileOutput.add(imageFile);
     }
 

ocr-service-v1/ocr-service-processor/src/main/java/com/knecon/fforesight/service/ocr/processor/service/threads/ImageProcessingThread.java

@@ -107,6 +107,7 @@ public class ImageProcessingThread extends Thread {
     }
 
 
+    @SuppressWarnings("PMD.CompareObjectsWithEquals")
     private OcrImage processRenderedPageImageFile(RenderedPageImageFile renderedPageImageFile) {
 
         Pix pix = processPix(renderedPageImageFile.asPix(), settings.getDpi(), settings.getDpi());
@@ -127,7 +128,7 @@ public class ImageProcessingThread extends Thread {
         return ocrImage;
     }
 
-
+    @SuppressWarnings("PMD.CompareObjectsWithEquals")
     private OcrImage processExtractedImage(ExtractedImage extractedImage) {
 
         float imageDPI = Math.abs(extractedImage.image().getWidth() / (extractedImage.ctm().getScalingFactorX() / 72));
@@ -198,8 +199,10 @@ public class ImageProcessingThread extends Thread {
             grayScale = pix;
         } else if (pix.d == 32) {
             grayScale = Leptonica1.pixConvertRGBToGrayFast(pix);
+            LeptUtils.disposePix(pix);
         } else if (pix.d == 1) {
             grayScale = Leptonica1.pixConvert1To8(null, pix, (byte) 0, (byte) 255);
+            LeptUtils.disposePix(pix);
         } else {
             throw new UnsupportedOperationException(String.format("Unknown pix format with bpp of %d", pix.d));
         }
@@ -208,29 +211,27 @@ public class ImageProcessingThread extends Thread {
         float targetFactor = targetDpi / imageDpi;
         if (targetFactor > 2.1) {
             scaledUp = Leptonica1.pixScaleGray4xLI(grayScale);
+            LeptUtils.disposePix(grayScale);
         } else if (targetFactor > 1.1) {
             scaledUp = Leptonica1.pixScaleGray2xLI(grayScale);
+            LeptUtils.disposePix(grayScale);
         } else {
             scaledUp = grayScale;
         }
 
         // remove noise and prep for Otsu
         gaussian = Leptonica1.pixConvolve(scaledUp, gaussianKernel, 8, 1);
+        LeptUtils.disposePix(scaledUp);
 
         // Threshold to binary
         if (pix.w < 100 || pix.h < 100) {
             binarized = Leptonica1.pixThresholdToBinary(gaussian, 170);
         } else {
             binarized = Leptonica1.pixOtsuThreshOnBackgroundNorm(gaussian, null, 50, 50, 165, 10, 100, 5, 5, 0.2f, null);
-
             if (binarized == null) { // Sometimes Otsu just fails, then we binarize directly
                 binarized = Leptonica1.pixThresholdToBinary(gaussian, 170);
             }
         }
-
-        LeptUtils.disposePix(pix);
-        LeptUtils.disposePix(grayScale);
-        LeptUtils.disposePix(scaledUp);
         LeptUtils.disposePix(gaussian);
 
         return binarized;

ocr-service-v1/ocr-service-processor/src/main/java/com/knecon/fforesight/service/ocr/processor/utils/PdfDraw.java

@@ -17,58 +17,57 @@ public class PdfDraw {
     @SneakyThrows
     public static void drawGrid(ElementWriter writer, Page page) {
 
-        ElementBuilder eb = new ElementBuilder();
-        double dX = 15;
-        double dY = 15;
-        int nRows = (int) (page.getPageHeight() / dY) + 1;
-        int nCols = (int) (page.getPageWidth() / dX) + 1;
-        for (int row = 0; row < nRows; ++row) {
-            for (int col = 0; col < nCols; ++col) {
-                Element cell = eb.createRect(col * dX, row * dY, dX, dY);
-                cell.setPathStroke(true);
-                cell.getGState().setLineWidth(1);
-                cell.getGState().setStrokeOpacity(0.1);
-                cell.getGState().setStrokeColorSpace(ColorSpace.createDeviceRGB());
-                if (row == 0 && col == 0) {
-                    cell.getGState().setStrokeColor(new ColorPt(0, 0, 1));
-                    cell.setPathFill(true);
-                    cell.getGState().setFillOpacity(0.8);
-                    cell.getGState().setFillColorSpace(ColorSpace.createDeviceRGB());
-                    cell.getGState().setFillColor(new ColorPt(0, 0, 1));
-                } else {
-                    cell.setPathFill(false);
-                    cell.getGState().setStrokeColor(new ColorPt(0.1, 0.1, 0.1));
+        try (var eb = new ElementBuilder()) {
+            double dX = 15;
+            double dY = 15;
+            int nRows = (int) (page.getPageHeight() / dY) + 1;
+            int nCols = (int) (page.getPageWidth() / dX) + 1;
+            for (int row = 0; row < nRows; ++row) {
+                for (int col = 0; col < nCols; ++col) {
+                    Element cell = eb.createRect(col * dX, row * dY, dX, dY);
+                    cell.setPathStroke(true);
+                    cell.getGState().setLineWidth(1);
+                    cell.getGState().setStrokeOpacity(0.1);
+                    cell.getGState().setStrokeColorSpace(ColorSpace.createDeviceRGB());
+                    if (row == 0 && col == 0) {
+                        cell.getGState().setStrokeColor(new ColorPt(0, 0, 1));
+                        cell.setPathFill(true);
+                        cell.getGState().setFillOpacity(0.8);
+                        cell.getGState().setFillColorSpace(ColorSpace.createDeviceRGB());
+                        cell.getGState().setFillColor(new ColorPt(0, 0, 1));
+                    } else {
+                        cell.setPathFill(false);
+                        cell.getGState().setStrokeColor(new ColorPt(0.1, 0.1, 0.1));
+                    }
+                    writer.writePlacedElement(cell);
                 }
-                writer.writePlacedElement(cell);
             }
         }
-        eb.destroy();
     }
 
 
     @SneakyThrows
     public static void drawRectCollection(ElementWriter writer, RectCollection rectCollection) {
 
-        ColorPt colorPt = new ColorPt(1, 0, 0);
-        ElementBuilder eb = new ElementBuilder();
-        for (int i = 0; i < rectCollection.getNumRects(); ++i) {
-            Rect r = rectCollection.getRectAt(i);
-            Element rect = eb.createRect(r.getX1(), r.getY1(), r.getWidth(), r.getHeight());
+        try (var colorPt = new ColorPt(1, 0, 0); var eb = new ElementBuilder()) {
+            for (int i = 0; i < rectCollection.getNumRects(); ++i) {
+                try(var r = rectCollection.getRectAt(i)) {
+                    Element rect = eb.createRect(r.getX1(), r.getY1(), r.getWidth(), r.getHeight());
 
-            rect.setPathStroke(true);
-            rect.getGState().setLineWidth(5);
-            rect.getGState().setStrokeColorSpace(ColorSpace.createDeviceRGB());
-            rect.getGState().setStrokeColor(colorPt);
+                    rect.setPathStroke(true);
+                    rect.getGState().setLineWidth(5);
+                    rect.getGState().setStrokeColorSpace(ColorSpace.createDeviceRGB());
+                    rect.getGState().setStrokeColor(colorPt);
 
-            rect.setPathFill(true);
-            rect.getGState().setFillColorSpace(ColorSpace.createDeviceRGB());
-            rect.getGState().setFillColor(colorPt);
-            rect.getGState().setFillOpacity(0.5);
+                    rect.setPathFill(true);
+                    rect.getGState().setFillColorSpace(ColorSpace.createDeviceRGB());
+                    rect.getGState().setFillColor(colorPt);
+                    rect.getGState().setFillOpacity(0.5);
 
-            writer.writePlacedElement(rect);
+                    writer.writePlacedElement(rect);
+                }
+            }
         }
-        colorPt.destroy();
-        eb.destroy();
     }
 
 }

ocr-service-v1/ocr-service-processor/src/main/java/com/knecon/fforesight/service/ocr/processor/utils/Tesseract2.java

@@ -138,11 +138,4 @@ public class Tesseract2 extends Tesseract1 {
         return renderer;
     }
 
-    @Override
-    protected void dispose() {
-
-        TessBaseAPIEnd(getHandle());
-        TessBaseAPIDelete(getHandle());
-    }
-
 }

ocr-service-v1/ocr-service-server/build.gradle.kts

@@ -6,7 +6,7 @@ plugins {
     id("org.springframework.boot") version "3.1.5"
     id("io.spring.dependency-management") version "1.1.3"
     id("org.sonarqube") version "4.3.0.3225"
-    id("io.freefair.lombok") version "8.2.2"
+    id("io.freefair.lombok") version "8.4"
 }
 
 configurations {
@@ -23,7 +23,7 @@ dependencies {
     implementation(project(":ocr-service-processor"))
     implementation(project(":ocr-service-api"))
 
-    implementation("com.knecon.fforesight:tracing-commons:0.3.0")
+    implementation("com.knecon.fforesight:tracing-commons:0.5.0")
     implementation("org.springframework.cloud:spring-cloud-starter-openfeign:4.0.4")
     implementation("org.springframework.boot:spring-boot-starter-amqp:${springBootStarterVersion}")
 

ocr-service-v1/ocr-service-server/src/main/java/com/knecon/fforesight/service/ocr/v1/server/queue/OcrMessageReceiver.java

@@ -21,6 +21,7 @@ import com.knecon.fforesight.service.ocr.v1.api.model.DocumentRequest;
 import com.iqser.red.service.persistence.service.v1.api.shared.model.dossiertemplate.dossier.file.FileErrorInfo;
 
 import feign.FeignException;
+import io.micrometer.observation.annotation.Observed;
 import lombok.AccessLevel;
 import lombok.RequiredArgsConstructor;
 import lombok.experimental.FieldDefaults;

ocr-service-v1/ocr-service-server/src/main/resources/vcpkg.json

@@ -6,7 +6,7 @@
   "overrides": [
     {
       "name": "tesseract",
-      "version": "5.3.2"
+      "version": "5.3.3"
     },
     {
       "name": "leptonica",

ocr-service-v1/ocr-service-server/src/test/java/com/knecon/fforesight/service/ocr/v1/server/OcrServiceIntegrationTest.java

@@ -64,7 +64,7 @@ public class OcrServiceIntegrationTest extends AbstractTest {
     @SneakyThrows
     public void testOcr() {
 
-        String text = testOCR("files/402Study.pdf");
+        String text = testOCR("files/UNAPPROVED_VV-331155 (1).pdf");
     }