Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-04-19 11:44:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

Ensure that percent === NaN is consistently reported by the onProgress callback

Browse Source 
With these changes `0`, `NaN`, `null`, and `undefined` in the `total`-property all result in `percent === NaN` being reported by the callback, since previously e.g. `0` would result in `percent === 100` being reported unconditionally which doesn't make a lot of sense.

Also, remove the "indeterminate" loadingBar (in the viewer) if the `PDFDocumentLoadingTask` fails since there won't be any more data arriving and displaying the animation thus seems wrong.
This commit is contained in:
Jonas Jenwald 2026-03-08 09:47:11 +01:00
parent 98dc351cfa
commit 1f69cf964c
3 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/display/api.js
View File

@ -2524,7 +2524,9 @@ class WorkerTransport {
this.loadingTask.onProgress?.({
loaded,
total,
percent: MathClamp(Math.round((loaded / total) * 100), 0, 100),
percent: total
? MathClamp(Math.round((loaded / total) * 100), 0, 100)
: NaN,
});
}

4
web/app.js
View File

@ -1255,6 +1255,10 @@ const PDFViewerApplication = {
if (loadingTask !== this.pdfLoadingTask) {
return undefined; // Ignore errors for previously opened PDF files.
}
if (this.loadingBar) {
// Avoid the "indeterminate" loadingBar being displayed on error.
this.loadingBar.percent ||= 0;
}
let key = "pdfjs-loading-error";
if (reason instanceof InvalidPDFException) {

8
web/firefoxcom.js
View File

@ -577,11 +577,9 @@ class ExternalServices extends BaseExternalServices {
pdfDataRangeTransport?.onDataProgressiveDone();
break;
case "progress":
const percent = MathClamp(
Math.round((args.loaded / args.total) * 100),
0,
100
);
const percent = args.total
? MathClamp(Math.round((args.loaded / args.total) * 100), 0, 100)
: NaN;
viewerApp.progress(percent);
break;