Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-06-26 10:05:47 +02:00
Code Issues Packages Projects Releases Wiki Activity

Use locally-installed Gulp over globally-installed one

Tim van der Meij 2024-05-31 15:43:59 +02:00
parent 3c65fb0d6e
commit 20f3b6c4be
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Benchmarking-your-changes.md

@ -21,8 +21,8 @@ When working on issues related to performance, it is important to provide a perf
Run the following commands to create a 'baseline' measurement (i.e., before you make your changes): Run the following commands to create a 'baseline' measurement (i.e., before you make your changes):
$ git checkout master $ git checkout master
$ gulp generic $ npx gulp generic
$ gulp components $ npx gulp components
$ cd test $ cd test
$ node test.mjs --statsFile=stats/results/baseline.json --statsDelay=5000 --manifestFile=benchmark.json $ node test.mjs --statsFile=stats/results/baseline.json --statsDelay=5000 --manifestFile=benchmark.json
@ -30,8 +30,8 @@ Then apply your changes and create a 'current' measurement (replace `<feature-br
$ cd .. $ cd ..
$ git checkout <feature-branch> $ git checkout <feature-branch>
$ gulp generic $ npx gulp generic
$ gulp components $ npx gulp components
$ cd test $ cd test
$ node test.mjs --statsFile=stats/results/current.json --statsDelay=5000 --manifestFile=benchmark.json $ node test.mjs --statsFile=stats/results/current.json --statsDelay=5000 --manifestFile=benchmark.json
@ -70,7 +70,7 @@ When the test finishes there will be a section in the terminal with `------- Sum
#### Apply Your Changes & Test Again #### Apply Your Changes & Test Again
1. In the `<pdfjs_src_dir>`: 1. In the `<pdfjs_src_dir>`:
1. make your changes 1. make your changes
2. build `gulp mozcentral` 2. run `npx gulp mozcentral`
3. copy the pdf.js build to firefox `rsync -a -v <pdfjs_src_dir>/build/mozcentral/browser/extensions/pdfjs/ <firefox_src_dir>toolkit/components/pdfjs/` 3. copy the pdf.js build to firefox `rsync -a -v <pdfjs_src_dir>/build/mozcentral/browser/extensions/pdfjs/ <firefox_src_dir>toolkit/components/pdfjs/`
2. Back in `<firefox_src_dir>`: 2. Back in `<firefox_src_dir>`:
1. Build firefox `./mach build faster` 1. Build firefox `./mach build faster`