Marmelator/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Updated Contributing (markdown)

Brendan Dahl 2020-02-28 09:13:45 -08:00
parent 3c84606767
commit fec123b0e9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Contributing.md

@ -133,7 +133,7 @@ Create a pull request on GitHub for your feature branch. The code will then be r
Note that the translations for PDF.js in the `l10n` folder are synchronized with the Aurora branch of Mozilla Firefox. This means that we will only accept pull requests that add strings currently missing in the Aurora branch (as it will take at least six weeks before the most recent translations are in the Aurora branch), but keep in mind that the changes will be overwritten when we synchronize again.
### 7. Code review and automated testing
In addition to the GitHub pull request workflow, it is highly recommended that you communicate with the PDF.js team, for example via the `#pdfjs` IRC channel at `irc.mozilla.org`. That will help to find a reviewer for your patch and speed up the review process. The reviewer will kick off further testing and do a code review.
In addition to the GitHub pull request workflow, it is highly recommended that you communicate with the PDF.js team, for example via the [Matrix room](https://chat.mozilla.org/#/room/#pdfjs:mozilla.org). That will help to find a reviewer for your patch and speed up the review process. The reviewer will kick off further testing and do a code review.
You can speed up fetching a remote GitHub branch (possibly belonging to another user) using `git try {username} {branch_name}`. Add the following to the `.git/config` file to be able to do that:
```