Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

DM-285: add filename to component result #176

Merged
kilian.schuettler1 merged 2 commits from DM-285 into master 2023-10-13 11:25:33 +02:00
Conversation 21 Commits 2 Files Changed 5 +42 -4
kilian.schuettler1 commented 2023-10-13 10:40:03 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Closes DM-285

Closes DM-285
kilian.schuettler1 commented 2023-10-13 10:40:03 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @kilian.schuettler1

assigned to @kilian.schuettler1
andrei.isvoran.ext (Migrated from gitlab.knecon.com) approved these changes 2023-10-13 10:40:03 +02:00
corina.olariu.ext1 (Migrated from gitlab.knecon.com) approved these changes 2023-10-13 10:40:03 +02:00
kilian.schuettler1 commented 2023-10-13 10:40:24 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed title from {-RED-7375: integrate table extractor-} to {+DM-285: add filename to component result+}

changed title from **{-RED-7375: integrate table extractor-}** to **{+DM-285: add filename to component result+}**
kilian.schuettler1 commented 2023-10-13 10:40:24 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed the description

changed the description
kilian.schuettler1 commented 2023-10-13 10:41:52 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 7660350e - DM-285: add fileName to component endpoint

Compare with previous version

added 1 commit <ul><li>7660350e - DM-285: add fileName to component endpoint</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/176/diffs?diff_id=21859&start_sha=583aa9f7b32b9b09faa816197193c2aabd3c70cc)
kilian.schuettler1 commented 2023-10-13 10:43:56 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 0b44b5ab - DM-285: add fileName to component endpoint

Compare with previous version

added 1 commit <ul><li>0b44b5ab - DM-285: add fileName to component endpoint</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/176/diffs?diff_id=21861&start_sha=7660350e9f31a0bbb4c688d7f79d953152b9a415)
andrei.isvoran.ext commented 2023-10-13 10:47:51 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Is there a reason to manually define the query here?

Is there a reason to manually define the query here?
kilian.schuettler1 commented 2023-10-13 10:47:54 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

requested review from @corina.olariu.ext1, @ali.oezyetimoglu1, @andrei.isvoran.ext, @dominique.eiflaender1, @timo.bejan.ext, and @yannik.hampe

requested review from @corina.olariu.ext1, @ali.oezyetimoglu1, @andrei.isvoran.ext, @dominique.eiflaender1, @timo.bejan.ext, and @yannik.hampe
kilian.schuettler1 commented 2023-10-13 10:48:23 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Intellij marked it red before, idk why

Intellij marked it red before, idk why
andrei.isvoran.ext commented 2023-10-13 10:50:04 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

interesting, I think JPA should be able to automatically generate the query here

interesting, I think JPA should be able to automatically generate the query here
kilian.schuettler1 commented 2023-10-13 10:50:19 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Yea ill test that

Yea ill test that
kilian.schuettler1 commented 2023-10-13 10:56:54 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Yea nope, does not work: org.springframework.orm.jpa.JpaSystemException: Specified result type [java.lang.String] did not match Query selection type [com.iqser.red.service.persistence.management.v1.processor.entity.dossier.FileEntity] - multiple selections: use Tuple or array

Yea nope, does not work: `org.springframework.orm.jpa.JpaSystemException: Specified result type [java.lang.String] did not match Query selection type [com.iqser.red.service.persistence.management.v1.processor.entity.dossier.FileEntity] - multiple selections: use Tuple or array`
kilian.schuettler1 commented 2023-10-13 10:57:35 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

tried to rename function to findFilenameById, same result

tried to rename function to findFilenameById, same result
kilian.schuettler1 commented 2023-10-13 11:01:16 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 4ae0a7e6 - DM-285: add fileName to component endpoint

Compare with previous version

added 1 commit <ul><li>4ae0a7e6 - DM-285: add fileName to component endpoint</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/176/diffs?diff_id=21865&start_sha=0b44b5abe7e2c49f4b2d68c8b7a6edbac7ee98c0)
andrei.isvoran.ext commented 2023-10-13 11:02:03 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

probably needs projections: https://stackoverflow.com/questions/22007341/spring-jpa-selecting-specific-columns

probably needs projections: https://stackoverflow.com/questions/22007341/spring-jpa-selecting-specific-columns
kilian.schuettler1 commented 2023-10-13 11:06:36 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Not sure if i like that more than just defining a simple query

Not sure if i like that more than just defining a simple query
andrei.isvoran.ext commented 2023-10-13 11:06:54 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

resolved all threads

resolved all threads
andrei.isvoran.ext commented 2023-10-13 11:07:16 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
corina.olariu.ext1 commented 2023-10-13 11:07:39 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
kilian.schuettler1 commented 2023-10-13 11:25:33 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

mentioned in commit b8b9395654

mentioned in commit b8b93956542c33045913161060afbfd8ab0b1b85
kilian.schuettler1 (Migrated from gitlab.knecon.com) merged commit b8b9395654 into master 2023-10-13 11:25:33 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
andrei.isvoran.ext
corina.olariu.ext1
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/persistence-service#176
No description provided.
Delete Branch "DM-285"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?