Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

RED-7962 Changed response type to "text/plain; charset=utf-8" #236

Merged
kresnadi.budisantoso merged 4 commits from RED-7962 into master 2023-11-30 12:40:17 +01:00
Conversation 10 Commits 4 Files Changed 4 +9 -10
kresnadi.budisantoso commented 2023-11-29 22:34:08 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
  • Fixup of previous commit
  • Use "text/plain; charset=utf-8" instead of "application/octet-stream" as response type for rule files
    as they are actually text files.

Closes RED-7962

- Fixup of previous commit - Use "text/plain; charset=utf-8" instead of "application/octet-stream" as response type for rule files as they are actually text files. Closes RED-7962
kresnadi.budisantoso commented 2023-11-29 22:34:08 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

requested review from @dominique.eiflaender1

requested review from @dominique.eiflaender1
dominique.eiflaender1 (Migrated from gitlab.knecon.com) approved these changes 2023-11-29 22:34:08 +01:00
kresnadi.budisantoso commented 2023-11-29 22:34:09 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @kresnadi.budisantoso1

assigned to @kresnadi.budisantoso1
kresnadi.budisantoso commented 2023-11-29 23:07:32 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 4c4e1ced - RED-7962 Changed response type to "text/plain; charset=utf-8"

Compare with previous version

added 1 commit <ul><li>4c4e1ced - RED-7962 Changed response type to &quot;text/plain; charset=utf-8&quot;</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/236/diffs?diff_id=25727&start_sha=4a2d7511eba8b8be2642783bb39775395c82637c)
kresnadi.budisantoso commented 2023-11-29 23:30:09 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 2 commits

  • 9d84085d - Hotfix: Download rule file endpoint (old version) ignores the file type
  • b9d47367 - Hotfix: Download file name not properly recognized by the browser as the...

Compare with previous version

added 2 commits <ul><li>9d84085d - Hotfix: Download rule file endpoint (old version) ignores the file type</li><li>b9d47367 - Hotfix: Download file name not properly recognized by the browser as the...</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/236/diffs?diff_id=25734&start_sha=4c4e1ced91bb1610e51ac833d25a59fd4eb39747)
kresnadi.budisantoso commented 2023-11-29 23:58:52 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 1de62109 - RED-962 Fixup response type & error 500

Compare with previous version

added 1 commit <ul><li>1de62109 - RED-962 Fixup response type &amp; error 500</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/236/diffs?diff_id=25735&start_sha=b9d473677c95cde3190d86249b6d8489a40c3eaf)
kresnadi.budisantoso commented 2023-11-30 01:52:02 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

marked this merge request as ready

marked this merge request as **ready**
kresnadi.budisantoso commented 2023-11-30 01:52:02 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

requested review from @lena.maldacker, @kilian.schuettler1, @timo.bejan.ext, @ali.oezyetimoglu1, and @yannik.hampe

requested review from @lena.maldacker, @kilian.schuettler1, @timo.bejan.ext, @ali.oezyetimoglu1, and @yannik.hampe
dominique.eiflaender1 commented 2023-11-30 12:40:13 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
dominique.eiflaender1 (Migrated from gitlab.knecon.com) merged commit 815de4d184 into master 2023-11-30 12:40:17 +01:00
dominique.eiflaender1 commented 2023-11-30 12:40:18 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

mentioned in commit 815de4d184

mentioned in commit 815de4d18463761d171ef683df17ebf961712483
Sign in to join this conversation.
Reviewers
No Reviewers
dominique.eiflaender1
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/persistence-service#236
No description provided.
Delete Branch "RED-7962"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?