Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

RED-7256 - Overlapping annotation color from imported redaction and resized redaction #270

Merged
corina.olariu.ext1 merged 6 commits from RED-7256-npe into master 2023-12-20 11:48:52 +01:00
Conversation 16 Commits 6 Files Changed 2 +21 -7
corina.olariu.ext1 commented 2023-12-15 10:31:30 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
  • fix NPE which is caused by the null value in case of resize imported redaction

Closes RED-7256

- fix NPE which is caused by the null value in case of resize imported redaction Closes RED-7256
andrei.isvoran.ext (Migrated from gitlab.knecon.com) approved these changes 2023-12-15 10:31:30 +01:00
corina.olariu.ext1 commented 2023-12-15 10:31:31 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

requested review from @ali.oezyetimoglu1, @andrei.isvoran.ext, @dominique.eiflaender1, @kilian.schuettler1, @yannik.hampe, and @timo.bejan.ext

requested review from @ali.oezyetimoglu1, @andrei.isvoran.ext, @dominique.eiflaender1, @kilian.schuettler1, @yannik.hampe, and @timo.bejan.ext
corina.olariu.ext1 commented 2023-12-15 10:31:31 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @corina.olariu.ext1

assigned to @corina.olariu.ext1
kilian.schuettler1 commented 2023-12-15 10:35:39 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

Why not just use Java's {+resizeRedactionRequest.getValue().+}isEmpty()?

Why not just use Java's {+resizeRedactionRequest.getValue().+}isEmpty()?
ali.oezyetimoglu1 commented 2023-12-15 10:37:31 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

resolved all threads

resolved all threads
corina.olariu.ext1 commented 2023-12-15 10:38:29 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

Because isEmpty checks for length and the problem was that value was null

Because isEmpty checks for length and the problem was that value was null
andrei.isvoran.ext commented 2023-12-15 10:44:09 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

You can also use Strings.isNullOrEmpty() from guava.

You can also use Strings.isNullOrEmpty() from guava.
corina.olariu.ext1 commented 2023-12-15 11:50:54 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

resolved all threads

resolved all threads
corina.olariu.ext1 commented 2023-12-19 11:50:28 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/redactmanager/persistence-service/-/merge_requests/270/diffs?diff_id=27453&start_sha=36755e59589492ea6dc6b03c30da9d01f9d9567e#82b76052eb35ae7bc3d31f394a52ae22b32da93d_177_177)
corina.olariu.ext1 commented 2023-12-19 11:50:29 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 85737653 - RED-7256 - Overlapping annotation color from imported redaction and resized redaction

Compare with previous version

added 1 commit <ul><li>85737653 - RED-7256 - Overlapping annotation color from imported redaction and resized redaction</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/270/diffs?diff_id=27453&start_sha=36755e59589492ea6dc6b03c30da9d01f9d9567e)
andrei.isvoran.ext commented 2023-12-19 11:59:30 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
corina.olariu.ext1 commented 2023-12-19 12:50:42 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 705dd423 - RED-7256 - Overlapping annotation color from imported redaction and resized redaction

Compare with previous version

added 1 commit <ul><li>705dd423 - RED-7256 - Overlapping annotation color from imported redaction and resized redaction</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/270/diffs?diff_id=27457&start_sha=85737653f7b99ae8c245c52c7684d4de2197321f)
corina.olariu.ext1 commented 2023-12-19 13:17:19 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 6e7dadd0 - RED-7256 - Overlapping annotation color from imported redaction and resized redaction

Compare with previous version

added 1 commit <ul><li>6e7dadd0 - RED-7256 - Overlapping annotation color from imported redaction and resized redaction</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/270/diffs?diff_id=27464&start_sha=705dd423336f716b6047fad79602782792c507f6)
corina.olariu.ext1 commented 2023-12-20 10:07:44 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 11 commits

  • 6e7dadd0...f2352413 - 10 commits from branch master
  • 2948ae1c - Merge branch 'master' into RED-7256-npe

Compare with previous version

added 11 commits <ul><li>6e7dadd0...f2352413 - 10 commits from branch <code>master</code></li><li>2948ae1c - Merge branch &#39;master&#39; into RED-7256-npe</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/270/diffs?diff_id=27644&start_sha=6e7dadd0cf4f6f8a3d3f444338bb95b4eb72a493)
corina.olariu.ext1 commented 2023-12-20 10:14:49 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 85d12f93 - RED-7256 - Overlapping annotation color from imported redaction and resized redaction

Compare with previous version

added 1 commit <ul><li>85d12f93 - RED-7256 - Overlapping annotation color from imported redaction and resized redaction</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/270/diffs?diff_id=27646&start_sha=2948ae1c107ff969948834e8ca73f0e49e7adad5)
corina.olariu.ext1 (Migrated from gitlab.knecon.com) merged commit 9b972984cf into master 2023-12-20 11:48:52 +01:00
corina.olariu.ext1 commented 2023-12-20 11:48:55 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

mentioned in commit 9b972984cf

mentioned in commit 9b972984cf1cd15969dce5b887f1c7d231933960
Sign in to join this conversation.
Reviewers
No Reviewers
andrei.isvoran.ext
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/persistence-service#270
No description provided.
Delete Branch "RED-7256-npe"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?