Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

RED-5716 - Deprecate old prepare endpoints #356

Merged
corina.olariu.ext1 merged 1 commits from RED-5716 into master 2024-02-20 07:54:05 +01:00
Conversation 9 Commits 1 Files Changed 3 +9 -7
3 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
persistence-service-v1/persistence-service-external-api-impl-v1/src/main/java/com/iqser/red/persistence/service/v1/external/api/impl/controller/DownloadController.java vendored
View File

@ -83,6 +83,7 @@ public class DownloadController implements DownloadResource {
private String storageBackend;
@Deprecated(forRemoval = true)
@PreAuthorize("hasAuthority('" + PROCESS_DOWNLOAD + "')")
public DownloadResponse prepareDownload(@RequestBody PrepareDownloadRequest request) {
@ -94,12 +95,12 @@ public class DownloadController implements DownloadResource {
accessControlService.verifyUserIsDossierOwnerOrApprover(request.getDossierId());
var response = downloadService.prepareDownload(convert(request));
auditPersistenceService.insertRecord(AuditRequest.builder()
.userId(KeycloakSecurity.getUserId())
.objectId(response.getValue())
.category(AuditCategory.DOWNLOAD.name())
.message("Download was prepared")
.details(Map.of("dossierId", request.getDossierId()))
.build());
.userId(KeycloakSecurity.getUserId())
.objectId(response.getValue())
.category(AuditCategory.DOWNLOAD.name())
.message("Download was prepared")
.details(Map.of("dossierId", request.getDossierId()))
.build());
return new DownloadResponse(response.getValue());
}

1
persistence-service-v1/persistence-service-external-api-v1/src/main/java/com/iqser/red/service/persistence/service/v1/api/external/resource/DownloadResource.java vendored
View File

@ -35,6 +35,7 @@ public interface DownloadResource {
String OTT_PATH = "/with-ott";
@Deprecated(forRemoval = true)
@Operation(summary = "Prepares a download for given fileIds and types", description = "None")
@ApiResponses(value = {@ApiResponse(responseCode = "200", description = "Success."), @ApiResponse(responseCode = "400", description = "Request contains error."), @ApiResponse(responseCode = "404", description = "Dossier or file not found.")})
@PostMapping(value = REST_PATH + "/prepare", consumes = MediaType.APPLICATION_JSON_VALUE, produces = MediaType.APPLICATION_JSON_VALUE)

2
persistence-service-v1/persistence-service-server-v1/src/test/java/com/iqser/red/service/peristence/v1/server/integration/tests/DownloadTest.java
View File

@ -86,7 +86,7 @@ public class DownloadTest extends AbstractPersistenceServerServiceTest {
assertThat(file22.getWorkflowStatus()).isEqualTo(WorkflowStatus.APPROVED);
try {
downloadClient.prepareDownload(PrepareDownloadRequest.builder().dossierId(dossier.getId()).fileIds(List.of(file.getId(), file2.getId())).build());
downloadClient.prepareDownload(PrepareDownloadWithOptionRequest.builder().dossierId(dossier.getId()).fileIds(List.of(file.getId(), file2.getId())).build());
} catch (FeignException e) {
assertThat(e.status()).isEqualTo(400);
}