Marmelator/persistence-service
1
0
Fork 0
Code Issues Pull Requests 17 Actions Packages Projects Releases 1.1k Wiki Activity

RED-8727 - Add rank de-duplication to migration #397

Merged
corina.olariu.ext1 merged 3 commits from RED-8727-bp into release/2.349.x 2024-03-14 12:37:57 +01:00
Conversation 13 Commits 3 Files Changed 4 +273
corina.olariu.ext1 commented 2024-03-14 10:16:40 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
  • add RankDeDuplicationService to update the found duplicate ranks
  • junit tests added

Signed-off-by: Corina Olariu corina.olariu.ext@knecon.com

Closes RED-8727

- add RankDeDuplicationService to update the found duplicate ranks - junit tests added Signed-off-by: Corina Olariu <corina.olariu.ext@knecon.com> Closes RED-8727
corina.olariu.ext1 commented 2024-03-14 10:16:40 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @corina.olariu.ext1

assigned to @corina.olariu.ext1
andrei.isvoran.ext (Migrated from gitlab.knecon.com) approved these changes 2024-03-14 10:16:40 +01:00
andrei.isvoran.ext commented 2024-03-14 10:32:06 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

I don't think these are sorted?

I don't think these are sorted?
andrei.isvoran.ext commented 2024-03-14 10:35:38 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

this can be simplified:

dossierTemplateManagementService.getAllDossierTemplates()
                .stream()
                .map(DossierTemplate::getId)
                .forEach(this::deduplicate);
this can be simplified: ``` dossierTemplateManagementService.getAllDossierTemplates() .stream() .map(DossierTemplate::getId) .forEach(this::deduplicate); ```
corina.olariu.ext1 commented 2024-03-14 10:35:48 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 5ce82d90 - RED-8727 - Add rank de-duplication to migration

Compare with previous version

added 1 commit <ul><li>5ce82d90 - RED-8727 - Add rank de-duplication to migration</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/397/diffs?diff_id=35982&start_sha=dc7dfe4f3e06e26a6e880603344285defa6dc710)
corina.olariu.ext1 commented 2024-03-14 10:36:19 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

they are sorted based on the rank by treeMap

they are sorted based on the rank by treeMap
corina.olariu.ext1 commented 2024-03-14 10:38:34 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/redactmanager/persistence-service/-/merge_requests/397/diffs?diff_id=35984&start_sha=5ce82d90e549accbcf206ecbf7560cb486a80312#0b2e13fdc611a97579a8b6373e520cadf3b25a2d_33_33)
corina.olariu.ext1 commented 2024-03-14 10:38:34 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 8a03c34a - RED-8727 - Add rank de-duplication to migration

Compare with previous version

added 1 commit <ul><li>8a03c34a - RED-8727 - Add rank de-duplication to migration</li></ul> [Compare with previous version](/redactmanager/persistence-service/-/merge_requests/397/diffs?diff_id=35984&start_sha=5ce82d90e549accbcf206ecbf7560cb486a80312)
corina.olariu.ext1 commented 2024-03-14 10:38:42 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

agreed

agreed
andrei.isvoran.ext commented 2024-03-14 10:39:18 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

ah yes

ah yes
andrei.isvoran.ext commented 2024-03-14 10:39:28 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

resolved all threads

resolved all threads
andrei.isvoran.ext commented 2024-03-14 10:39:47 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
corina.olariu.ext1 commented 2024-03-14 12:37:57 +01:00 (Migrated from gitlab.knecon.com)
Copy Link

mentioned in commit 5cf629bc47

mentioned in commit 5cf629bc470ce57e04f41e4ff201dc4711aff2f7
corina.olariu.ext1 (Migrated from gitlab.knecon.com) merged commit 5cf629bc47 into release/2.349.x 2024-03-14 12:37:57 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
andrei.isvoran.ext
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/persistence-service#397
No description provided.
Delete Branch "RED-8727-bp"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?