Pull request #294 : RED-3075: Upgraded log4j to 2.15.0

Merge in RED/redaction-service from RED-3075-rs2 to master * commit '142c81d27d9e5e67532b3d8795c2d4c559342d37': RED-3075: Upgraded log4j to 2.15.0
RED-3075: Upgraded log4j to 2.15.0
2021-12-13 11:03:56 +01:00 · 2021-12-13 10:59:16 +01:00 · 2021-12-10 11:37:24 +01:00 · 2021-12-10 11:32:53 +01:00 · 2021-12-09 16:19:24 +01:00 · 2021-12-09 16:12:02 +01:00
14 changed files with 427 additions and 72 deletions
@@ -5,7 +5,7 @@
    <parent>
        <artifactId>platform-dependency</artifactId>
        <groupId>com.iqser.red</groupId>
-        <version>1.1.5</version>
+        <version>1.1.7</version>
    </parent>
    <modelVersion>4.0.0</modelVersion>

@@ -12,7 +12,7 @@
    <artifactId>redaction-service-api-v1</artifactId>

    <properties>
-        <persistence-service.version>0.121.0</persistence-service.version>
+        <persistence-service.version>0.135.0</persistence-service.version>
    </properties>

    <dependencies>
@@ -30,4 +30,9 @@ public class SectionArea {
        return page == other.getPage() && this.topLeft.getX() <= other.getTopLeft().getX() && this.topLeft.getX() + this.getWidth() >= other.getTopLeft().getX() + other.getWidth() && this.getTopLeft().getY() <= other.getTopLeft().getY() && this.getTopLeft().getY() + this.getHeight() >= other.getTopLeft().getY() + other.getHeight();
    }

+    // TODO we should only use one rectangle class.
+    public boolean contains(com.iqser.red.service.persistence.service.v1.api.model.annotations.Rectangle other) {
+        return page == other.getPage() && this.topLeft.getX() <= other.getTopLeftX() && this.topLeft.getX() + this.getWidth() >= other.getTopLeftX() + other.getWidth() && this.getTopLeft().getY() <= other.getTopLeftY() && this.getTopLeft().getY() + this.getHeight() >= other.getTopLeftY() + other.getHeight();
+    }
+
 }
@@ -1,29 +1,43 @@
 package com.iqser.red.service.redaction.v1.resources;

+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualRedactions;
 import com.iqser.red.service.redaction.v1.model.*;
+
 import org.springframework.http.MediaType;
 import org.springframework.web.bind.annotation.PathVariable;
 import org.springframework.web.bind.annotation.PostMapping;
 import org.springframework.web.bind.annotation.RequestBody;
+import org.springframework.web.bind.annotation.RequestParam;

 public interface RedactionResource {

    @PostMapping(value = "/annotate", produces = MediaType.APPLICATION_JSON_VALUE, consumes = MediaType.APPLICATION_JSON_VALUE)
    AnnotateResponse annotate(@RequestBody AnnotateRequest annotateRequest);

+
    @PostMapping(value = "/debug/classifications", produces = MediaType.APPLICATION_JSON_VALUE, consumes = MediaType.APPLICATION_JSON_VALUE)
    RedactionResult classify(@RequestBody RedactionRequest redactionRequest);

+
    @PostMapping(value = "/debug/sections", produces = MediaType.APPLICATION_JSON_VALUE, consumes = MediaType.APPLICATION_JSON_VALUE)
    RedactionResult sections(@RequestBody RedactionRequest redactionRequest);

+
    @PostMapping(value = "/debug/htmlTables", produces = MediaType.APPLICATION_JSON_VALUE, consumes = MediaType.APPLICATION_JSON_VALUE)
    RedactionResult htmlTables(@RequestBody RedactionRequest redactionRequest);

+
    @PostMapping(value = "/rules/test", consumes = MediaType.APPLICATION_JSON_VALUE)
    void testRules(@RequestBody String rules);

+
    @PostMapping(value = "/redaction-log/preview", consumes = MediaType.APPLICATION_JSON_VALUE)
    RedactionLog getRedactionLog(@RequestBody RedactionRequest redactionRequest);

+
+    @PostMapping(value = "/manual/surrounding-text/{dossierId}/{fileId}", consumes = MediaType.APPLICATION_JSON_VALUE, produces = MediaType.APPLICATION_JSON_VALUE)
+    ManualRedactions addSurroundingText(@PathVariable("dossierId") String dossierId,
+                                        @PathVariable("fileId") String fileId,
+                                        @RequestBody ManualRedactions manualRedactions);
+
 }
@@ -1,7 +1,24 @@
 package com.iqser.red.service.redaction.v1.server.controller;

+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.util.stream.Collectors;
+
+import org.apache.pdfbox.io.MemoryUsageSetting;
+import org.apache.pdfbox.pdmodel.PDDocument;
+import org.springframework.web.bind.annotation.PathVariable;
+import org.springframework.web.bind.annotation.RequestBody;
+import org.springframework.web.bind.annotation.RestController;
+
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualRedactions;
 import com.iqser.red.service.persistence.service.v1.api.model.dossiertemplate.dossier.file.FileType;
-import com.iqser.red.service.redaction.v1.model.*;
+import com.iqser.red.service.redaction.v1.model.AnnotateRequest;
+import com.iqser.red.service.redaction.v1.model.AnnotateResponse;
+import com.iqser.red.service.redaction.v1.model.RedactionLog;
+import com.iqser.red.service.redaction.v1.model.RedactionRequest;
+import com.iqser.red.service.redaction.v1.model.RedactionResult;
+import com.iqser.red.service.redaction.v1.model.SectionArea;
+import com.iqser.red.service.redaction.v1.model.SectionGrid;
 import com.iqser.red.service.redaction.v1.resources.RedactionResource;
 import com.iqser.red.service.redaction.v1.server.classification.model.Document;
 import com.iqser.red.service.redaction.v1.server.classification.model.Page;
@@ -10,22 +27,16 @@ import com.iqser.red.service.redaction.v1.server.exception.RedactionException;
 import com.iqser.red.service.redaction.v1.server.redaction.service.AnnotationService;
 import com.iqser.red.service.redaction.v1.server.redaction.service.DictionaryService;
 import com.iqser.red.service.redaction.v1.server.redaction.service.DroolsExecutionService;
+import com.iqser.red.service.redaction.v1.server.redaction.service.ManualRedactionSurroundingTextService;
 import com.iqser.red.service.redaction.v1.server.redaction.service.RedactionLogMergeService;
 import com.iqser.red.service.redaction.v1.server.segmentation.PdfSegmentationService;
 import com.iqser.red.service.redaction.v1.server.storage.RedactionStorageService;
 import com.iqser.red.service.redaction.v1.server.tableextraction.model.AbstractTextContainer;
 import com.iqser.red.service.redaction.v1.server.tableextraction.model.Table;
 import com.iqser.red.service.redaction.v1.server.visualization.service.PdfVisualisationService;
+
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
-import org.apache.pdfbox.io.MemoryUsageSetting;
-import org.apache.pdfbox.pdmodel.PDDocument;
-import org.springframework.web.bind.annotation.RequestBody;
-import org.springframework.web.bind.annotation.RestController;
-
-import java.io.ByteArrayOutputStream;
-import java.io.IOException;
-import java.util.stream.Collectors;

@Slf4j
@RestController
@@ -39,11 +50,19 @@ public class RedactionController implements RedactionResource {
    private final PdfSegmentationService pdfSegmentationService;
    private final RedactionStorageService redactionStorageService;
    private final RedactionLogMergeService redactionLogMergeService;
+    private final ManualRedactionSurroundingTextService manualRedactionSurroundingTextService;
+

    public AnnotateResponse annotate(@RequestBody AnnotateRequest annotateRequest) {

-        var storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(annotateRequest.getDossierId(), annotateRequest.getFileId(), FileType.ORIGIN));
-        var mergedRedactionLog = getRedactionLog(RedactionRequest.builder().fileId(annotateRequest.getFileId()).manualRedactions(annotateRequest.getManualRedactions()).dossierId(annotateRequest.getDossierId()).dossierTemplateId(annotateRequest.getDossierTemplateId()).build());
+        var storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(annotateRequest
+                .getDossierId(), annotateRequest.getFileId(), FileType.ORIGIN));
+        var mergedRedactionLog = getRedactionLog(RedactionRequest.builder()
+                .fileId(annotateRequest.getFileId())
+                .manualRedactions(annotateRequest.getManualRedactions())
+                .dossierId(annotateRequest.getDossierId())
+                .dossierTemplateId(annotateRequest.getDossierTemplateId())
+                .build());
        var sectionsGrid = redactionStorageService.getSectionGrid(annotateRequest.getDossierId(), annotateRequest.getFileId());

        try (PDDocument pdDocument = PDDocument.load(storedObjectStream, MemoryUsageSetting.setupTempFileOnly())) {
@@ -65,11 +84,14 @@ public class RedactionController implements RedactionResource {

    @Override
    public RedactionResult classify(@RequestBody RedactionRequest redactionRequest) {
-        var storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest.getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
+
+        var storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest
+                .getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
        try {
            Document classifiedDoc = pdfSegmentationService.parseDocument(storedObjectStream);

-            storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest.getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
+            storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest
+                    .getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
            try (PDDocument pdDocument = PDDocument.load(storedObjectStream)) {
                pdDocument.setAllSecurityToBeRemoved(true);

@@ -85,16 +107,19 @@ public class RedactionController implements RedactionResource {
            throw new RedactionException(e);
        }

-
    }

+
    @Override
    public RedactionResult sections(@RequestBody RedactionRequest redactionRequest) {
-        var storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest.getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
+
+        var storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest
+                .getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
        try {
            Document classifiedDoc = pdfSegmentationService.parseDocument(storedObjectStream);

-            storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest.getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
+            storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest
+                    .getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
            try (PDDocument pdDocument = PDDocument.load(storedObjectStream)) {
                pdDocument.setAllSecurityToBeRemoved(true);

@@ -109,7 +134,6 @@ public class RedactionController implements RedactionResource {
            throw new RedactionException(e);
        }

-
    }


@@ -119,13 +143,13 @@ public class RedactionController implements RedactionResource {
        Document classifiedDoc;

        try {
-            var storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest.getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
+            var storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest
+                    .getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
            classifiedDoc = pdfSegmentationService.parseDocument(storedObjectStream, true);
        } catch (Exception e) {
            throw new RedactionException(e);
        }

-
        StringBuilder sb = new StringBuilder();
        for (Page page : classifiedDoc.getPages()) {
            for (AbstractTextContainer textContainer : page.getTextBlocks()) {
@@ -140,12 +164,14 @@ public class RedactionController implements RedactionResource {

    }

+
    @Override
    public void testRules(@RequestBody String rules) {

        droolsExecutionService.testRules(rules);
    }

+
    @Override
    public RedactionLog getRedactionLog(RedactionRequest redactionRequest) {

@@ -160,7 +186,8 @@ public class RedactionController implements RedactionResource {

        log.info("Loaded redaction log with computationalVersion: {}", redactionLog.getAnalysisVersion());

-        SectionGrid sectionGrid = redactionStorageService.getSectionGrid(redactionRequest.getDossierId(), redactionRequest.getFileId());
+        SectionGrid sectionGrid = redactionStorageService.getSectionGrid(redactionRequest.getDossierId(), redactionRequest
+                .getFileId());
        if (sectionGrid.getSections().isEmpty()) {

            log.info("SectionGrid does not have headlines set. Computing headlines now!");
@@ -168,24 +195,27 @@ public class RedactionController implements RedactionResource {

            // enhance section grid with headline data
            for (var sectionText : text.getSectionTexts()) {
-                sectionGrid.getSections().add(new SectionGrid.SectionGridSection(sectionText.getSectionNumber(),
-                        sectionText.getHeadline(),
-                        sectionText.getSectionAreas().stream().map(SectionArea::getPage).collect(Collectors.toSet()),
-                        sectionText.getSectionAreas()));
+                sectionGrid.getSections()
+                        .add(new SectionGrid.SectionGridSection(sectionText.getSectionNumber(), sectionText.getHeadline(), sectionText
+                                .getSectionAreas()
+                                .stream()
+                                .map(SectionArea::getPage)
+                                .collect(Collectors.toSet()), sectionText.getSectionAreas()));
            }
            redactionStorageService.storeObject(redactionRequest.getDossierId(), redactionRequest.getFileId(), FileType.SECTION_GRID, sectionGrid);
        }

-
        log.info("Loaded redaction log with computationalVersion: {}", redactionLog.getAnalysisVersion());
        if (redactionLog.getAnalysisVersion() == 0) {
            // old redaction logs are returned directly
            return redactionLog;
        } else {
-            return redactionLogMergeService.mergeRedactionLogData(redactionLog, sectionGrid, redactionRequest.getDossierTemplateId(), redactionRequest.getManualRedactions(), redactionRequest.getExcludedPages());
+            return redactionLogMergeService.mergeRedactionLogData(redactionLog, sectionGrid, redactionRequest.getDossierTemplateId(), redactionRequest
+                    .getManualRedactions(), redactionRequest.getExcludedPages());
        }
    }

+
    private RedactionResult convert(PDDocument document, int numberOfPages) throws IOException {

        try (ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream()) {
@@ -199,4 +229,16 @@ public class RedactionController implements RedactionResource {
    }


+    @Override
+    public ManualRedactions addSurroundingText(@PathVariable("dossierId") String dossierId,
+                                               @PathVariable("fileId") String fileId,
+                                               @RequestBody ManualRedactions manualRedactions) {
+
+        long start = System.currentTimeMillis();
+        var result = manualRedactionSurroundingTextService.addSurroundingText(dossierId, fileId, manualRedactions);
+        log.info("add surrounding text for manual redaction in dossierId {} and fileId {} took: {}", dossierId, fileId, System
+                .currentTimeMillis() - start);
+        return result;
+    }
+
 }
@@ -0,0 +1,141 @@
+package com.iqser.red.service.redaction.v1.server.redaction.service;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+
+import org.apache.commons.lang3.tuple.Pair;
+import org.springframework.stereotype.Service;
+
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualRedactionEntry;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualRedactions;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualResizeRedaction;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.Rectangle;
+import com.iqser.red.service.redaction.v1.model.Engine;
+import com.iqser.red.service.redaction.v1.model.SectionArea;
+import com.iqser.red.service.redaction.v1.server.classification.model.SectionText;
+import com.iqser.red.service.redaction.v1.server.classification.model.Text;
+import com.iqser.red.service.redaction.v1.server.parsing.model.TextPositionSequence;
+import com.iqser.red.service.redaction.v1.server.redaction.model.Entity;
+import com.iqser.red.service.redaction.v1.server.redaction.model.EntityPositionSequence;
+import com.iqser.red.service.redaction.v1.server.redaction.utils.EntitySearchUtils;
+import com.iqser.red.service.redaction.v1.server.storage.RedactionStorageService;
+
+import lombok.RequiredArgsConstructor;
+
+@Service
+@RequiredArgsConstructor
+public class ManualRedactionSurroundingTextService {
+
+    private final RedactionStorageService redactionStorageService;
+    private final SurroundingWordsService surroundingWordsService;
+
+
+    public ManualRedactions addSurroundingText(String dossierId, String fileId, ManualRedactions manualRedactions) {
+
+        Text text = redactionStorageService.getText(dossierId, fileId);
+        List<ManualRedactionEntry> processedAddRedactions = new ArrayList<>();
+        List<ManualResizeRedaction> processedResizeRedactions = new ArrayList<>();
+
+        for (SectionText sectionText : text.getSectionTexts()) {
+
+            if (manualRedactions.getEntriesToAdd().isEmpty() && manualRedactions.getResizeRedactions().isEmpty()) {
+                break;
+            }
+
+            for (SectionArea sectionArea : sectionText.getSectionAreas()) {
+
+                var addItty = manualRedactions.getEntriesToAdd().iterator();
+                while (addItty.hasNext()) {
+                    var manualAddRedaction = addItty.next();
+                    if (sectionContainsEntry(sectionArea, manualAddRedaction.getPositions())) {
+                        var surroundingText = findSurroundingText(sectionText, manualAddRedaction.getValue(), manualAddRedaction
+                                .getPositions());
+                        manualAddRedaction.setTextBefore(surroundingText.getLeft());
+                        manualAddRedaction.setTextAfter(surroundingText.getRight());
+                        processedAddRedactions.add(manualAddRedaction);
+                        addItty.remove();
+                    }
+                }
+
+                var resizeItty = manualRedactions.getResizeRedactions().iterator();
+                while (resizeItty.hasNext()) {
+                    var manualResizeRedaction = resizeItty.next();
+                    if (sectionContainsEntry(sectionArea, manualResizeRedaction.getPositions())) {
+                        var surroundingText = findSurroundingText(sectionText, manualResizeRedaction.getValue(), manualResizeRedaction
+                                .getPositions());
+                        manualResizeRedaction.setTextBefore(surroundingText.getLeft());
+                        manualResizeRedaction.setTextAfter(surroundingText.getRight());
+                        processedResizeRedactions.add(manualResizeRedaction);
+                        resizeItty.remove();
+                    }
+                }
+            }
+        }
+
+        manualRedactions.getEntriesToAdd().addAll(processedAddRedactions);
+        manualRedactions.getResizeRedactions().addAll(processedResizeRedactions);
+        return manualRedactions;
+    }
+
+
+    private Pair<String, String> findSurroundingText(SectionText sectionText, String value,
+                                                     List<Rectangle> toFindPositions) {
+
+        Set<Entity> entities = EntitySearchUtils.find(sectionText.getText(), Set.of(value), "dummy", sectionText.getHeadline(), sectionText
+                .getSectionNumber(), false, false, Engine.DICTIONARY);
+        Set<Entity> entitiesWithPositions = EntitySearchUtils.clearAndFindPositions(entities, sectionText.getSearchableText(), null);
+
+        Entity correctEntity = getEntityOnCorrectPosition(entitiesWithPositions, toFindPositions);
+
+        if (sectionText.getCellStarts() != null && !sectionText.getCellStarts().isEmpty()) {
+            surroundingWordsService.addSurroundingText(Set.of(correctEntity), sectionText.getSearchableText(), null, sectionText
+                    .getCellStarts());
+        } else {
+            surroundingWordsService.addSurroundingText(Set.of(correctEntity), sectionText.getSearchableText(), null);
+        }
+
+        return Pair.of(correctEntity.getTextBefore(), correctEntity.getTextAfter());
+    }
+
+
+    private boolean sectionContainsEntry(SectionArea sectionArea, List<Rectangle> positions) {
+
+        for (Rectangle position : positions) {
+            if (sectionArea.contains(position)) {
+                return true;
+            }
+        }
+        return false;
+    }
+
+
+    private Entity getEntityOnCorrectPosition(Set<Entity> entitiesWithPositions, List<Rectangle> toFindPositions) {
+
+        for (Entity entityWithPos : entitiesWithPositions) {
+            for (EntityPositionSequence entityPositionSequence : entityWithPos.getPositionSequences()) {
+                for (TextPositionSequence textPositionSequence : entityPositionSequence.getSequences()) {
+                    for (Rectangle manualRedactionRectangle : toFindPositions) {
+                        if (intersects(manualRedactionRectangle, textPositionSequence.getRectangle())) {
+                            return entityWithPos;
+                        }
+                    }
+                }
+            }
+        }
+
+        return null;
+    }
+
+
+    public boolean intersects(Rectangle manualPosition,
+                              com.iqser.red.service.redaction.v1.model.Rectangle textPositionRectangle) {
+
+        return textPositionRectangle.getTopLeft()
+                .getX() + textPositionRectangle.getWidth() > manualPosition.getTopLeftX() && textPositionRectangle.getTopLeft()
+                .getY() + textPositionRectangle.getHeight() > manualPosition.getTopLeftY() && textPositionRectangle.getTopLeft()
+                .getX() < manualPosition.getTopLeftX() + manualPosition.getWidth() && textPositionRectangle.getTopLeft()
+                .getY() < manualPosition.getTopLeftY() + manualPosition.getHeight();
+    }
+
+}
@@ -1,17 +1,36 @@
 package com.iqser.red.service.redaction.v1.server.redaction.service;

-import com.iqser.red.service.persistence.service.v1.api.model.annotations.*;
+import java.time.OffsetDateTime;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import org.springframework.stereotype.Service;
+
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.AnnotationStatus;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.Comment;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.IdRemoval;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualForceRedaction;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualImageRecategorization;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualLegalBasisChange;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualRedactionEntry;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualRedactions;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualResizeRedaction;
+import com.iqser.red.service.redaction.v1.model.ManualRedactionType;
+import com.iqser.red.service.redaction.v1.model.Point;
 import com.iqser.red.service.redaction.v1.model.Rectangle;
-import com.iqser.red.service.redaction.v1.model.*;
+import com.iqser.red.service.redaction.v1.model.RedactionLog;
+import com.iqser.red.service.redaction.v1.model.RedactionLogEntry;
+import com.iqser.red.service.redaction.v1.model.SectionGrid;
+
 import lombok.AllArgsConstructor;
 import lombok.Data;
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
-import org.springframework.stereotype.Service;
-
-import java.time.OffsetDateTime;
-import java.util.*;
-import java.util.stream.Collectors;

@Slf4j
@Service
@@ -23,8 +42,9 @@ public class RedactionLogMergeService {
    private final SectionTextService sectionTextService;


-    public RedactionLog mergeRedactionLogData(RedactionLog redactionLog, SectionGrid sectionGrid, String dossierTemplateId,
-                                              ManualRedactions manualRedactions, Set<Integer> excludedPages) {
+    public RedactionLog mergeRedactionLogData(RedactionLog redactionLog, SectionGrid sectionGrid,
+                                              String dossierTemplateId, ManualRedactions manualRedactions,
+                                              Set<Integer> excludedPages) {

        log.info("Merging Redaction log with manual redactions");
        if (manualRedactions != null) {
@@ -56,7 +76,7 @@ public class RedactionLogMergeService {

        Set<String> processedIds = new HashSet<>();
        redactionLog.getRedactionLogEntry().removeIf(entry -> {
-            if(processedIds.contains(entry.getId())){
+            if (processedIds.contains(entry.getId())) {
                log.info("Duplicate annotation found with id {}", entry.getId());
                return true;
            }
@@ -120,12 +140,19 @@ public class RedactionLogMergeService {
                    redactionLogEntry.setType(imageRecategorization.getType());
                    redactionLogEntry.setHasBeenRecategorized(true);
                    redactionLogEntry.setSection("Image:" + redactionLogEntry.getType());
+
+                    if (dictionaryService.isHint(imageRecategorization.getType(), dossierTemplateId)) {
+                        redactionLogEntry.setRedacted(false);
+                        redactionLogEntry.setHint(true);
+                    } else {
+                        redactionLogEntry.setHint(false);
+                    }
+
                    manualOverrideReason = mergeReasonIfNecessary(redactionLogEntry.getReason(), ", recategorized by manual override");
                } else if (imageRecategorization.getStatus().equals(AnnotationStatus.REQUESTED)) {
                    manualOverrideReason = mergeReasonIfNecessary(redactionLogEntry.getReason(), ", requested to recategorize");
                    redactionLogEntry.setStatus(AnnotationStatus.REQUESTED);
-                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, false, redactionLogEntry
-                            .isRedacted(), false));
+                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, false, redactionLogEntry.isRedacted(), false));
                    redactionLogEntry.setRecategorizationType(imageRecategorization.getType());
                } else {
                    redactionLogEntry.setStatus(AnnotationStatus.DECLINED);
@@ -144,14 +171,12 @@ public class RedactionLogMergeService {
                    redactionLogEntry.setRedacted(false);
                    redactionLogEntry.setStatus(AnnotationStatus.APPROVED);
                    manualOverrideReason = mergeReasonIfNecessary(redactionLogEntry.getReason(), ", removed by manual override");
-                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, false, redactionLogEntry
-                            .isRedacted(), true));
+                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, false, redactionLogEntry.isRedacted(), true));
                    redactionLogEntry.setHasBeenRemovedByManualOverride(true);
                } else if (manualRemoval.getStatus().equals(AnnotationStatus.REQUESTED)) {
                    manualOverrideReason = mergeReasonIfNecessary(redactionLogEntry.getReason(), ", requested to remove");
                    redactionLogEntry.setStatus(AnnotationStatus.REQUESTED);
-                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, true, redactionLogEntry
-                            .isRedacted(), false));
+                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, true, redactionLogEntry.isRedacted(), false));
                } else {
                    redactionLogEntry.setStatus(AnnotationStatus.DECLINED);
                }
@@ -170,16 +195,14 @@ public class RedactionLogMergeService {
                if (manualForceRedact.getStatus().equals(AnnotationStatus.APPROVED)) {
                    redactionLogEntry.setRedacted(true);
                    redactionLogEntry.setStatus(AnnotationStatus.APPROVED);
-                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, false, redactionLogEntry
-                            .isRedacted(), false));
+                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, false, redactionLogEntry.isRedacted(), false));
                    manualOverrideReason = mergeReasonIfNecessary(redactionLogEntry.getReason(), ", forced by manual override");
                    redactionLogEntry.setHasBeenForced(true);
                    redactionLogEntry.setLegalBasis(manualForceRedact.getLegalBasis());
                } else if (manualForceRedact.getStatus().equals(AnnotationStatus.REQUESTED)) {
                    manualOverrideReason = mergeReasonIfNecessary(redactionLogEntry.getReason(), ", requested to force redact");
                    redactionLogEntry.setStatus(AnnotationStatus.REQUESTED);
-                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, true, redactionLogEntry
-                            .isRedacted(), false));
+                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, true, redactionLogEntry.isRedacted(), false));
                    redactionLogEntry.setLegalBasis(manualForceRedact.getLegalBasis());
                } else {
                    redactionLogEntry.setStatus(AnnotationStatus.DECLINED);
@@ -210,8 +233,7 @@ public class RedactionLogMergeService {
                } else if (manualLegalBasisChange.getStatus().equals(AnnotationStatus.REQUESTED)) {
                    manualOverrideReason = mergeReasonIfNecessary(redactionLogEntry.getReason(), ", legal basis change requested");
                    redactionLogEntry.setStatus(AnnotationStatus.REQUESTED);
-                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, true, redactionLogEntry
-                            .isRedacted(), false));
+                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, true, redactionLogEntry.isRedacted(), false));
                    redactionLogEntry.setLegalBasisChangeValue(manualLegalBasisChange.getLegalBasis());
                } else {
                    redactionLogEntry.setStatus(AnnotationStatus.DECLINED);
@@ -228,18 +250,20 @@ public class RedactionLogMergeService {
                String manualOverrideReason = null;
                if (manualResizeRedact.getStatus().equals(AnnotationStatus.APPROVED)) {
                    redactionLogEntry.setStatus(AnnotationStatus.APPROVED);
-                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, false, redactionLogEntry
-                            .isRedacted(), false));
+                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, false, redactionLogEntry.isRedacted(), false));
                    redactionLogEntry.setPositions(convertPositions(manualResizeRedact.getPositions()));
                    redactionLogEntry.setValue(manualResizeRedact.getValue());
                    redactionLogEntry.setHasBeenResized(true);
+                    redactionLogEntry.setTextBefore(manualResizeRedact.getTextBefore());
+                    redactionLogEntry.setTextAfter(manualResizeRedact.getTextAfter());
                    manualOverrideReason = mergeReasonIfNecessary(redactionLogEntry.getReason(), ", resized by manual override");
                } else if (manualResizeRedact.getStatus().equals(AnnotationStatus.REQUESTED)) {
                    manualOverrideReason = mergeReasonIfNecessary(redactionLogEntry.getReason(), ", requested to resize redact");
                    redactionLogEntry.setStatus(AnnotationStatus.REQUESTED);
-                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, true, redactionLogEntry
-                            .isRedacted(), false));
+                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, true, redactionLogEntry.isRedacted(), false));
                    redactionLogEntry.setPositions(convertPositions(manualResizeRedact.getPositions()));
+                    redactionLogEntry.setTextBefore(manualResizeRedact.getTextBefore());
+                    redactionLogEntry.setTextAfter(manualResizeRedact.getTextAfter());
                } else {
                    redactionLogEntry.setStatus(AnnotationStatus.DECLINED);
                }
@@ -280,6 +304,8 @@ public class RedactionLogMergeService {
                RedactionLogEntry redactionLogEntry = createRedactionLogEntry(manualRedactionEntry, manualRedactionEntry.getAnnotationId(), dossierTemplateId);
                redactionLogEntry.setPositions(convertPositions(manualRedactionEntry.getPositions()));
                redactionLogEntry.setComments(comments.get(manualRedactionEntry.getAnnotationId()));
+                redactionLogEntry.setTextBefore(manualRedactionEntry.getTextBefore());
+                redactionLogEntry.setTextAfter(manualRedactionEntry.getTextAfter());

                sectionTextService.handleSectionText(sectionGrid, redactionLogEntry);

@@ -290,9 +316,13 @@ public class RedactionLogMergeService {
        return redactionLogEntries;
    }

-    private List<Rectangle> convertPositions(List<com.iqser.red.service.persistence.service.v1.api.model.annotations.Rectangle> positions) {
-        return positions.stream().map(pos -> new Rectangle(new Point(pos.getTopLeftX(), pos.getTopLeftY()), pos.getWidth(), pos
-                .getHeight(), pos.getPage())).collect(Collectors.toList());
+
+    private List<Rectangle> convertPositions(
+            List<com.iqser.red.service.persistence.service.v1.api.model.annotations.Rectangle> positions) {
+
+        return positions.stream()
+                .map(pos -> new Rectangle(new Point(pos.getTopLeftX(), pos.getTopLeftY()), pos.getWidth(), pos.getHeight(), pos.getPage()))
+                .collect(Collectors.toList());
    }


@@ -375,6 +405,5 @@ public class RedactionLogMergeService {

    }

-
 }

@@ -28,7 +28,7 @@ public class SurroundingWordsService {
        try {
            for (Entity entity : entities) {

-                if (dictionary.isHint(entity.getType())) {
+                if (dictionary != null && dictionary.isHint(entity.getType())) {
                    continue;
                }
                findSurroundingWords(entity, searchableText.toString(), entity.getStart(), entity.getEnd());
@@ -64,7 +64,7 @@ public class SurroundingWordsService {
                    String text = searchableString.substring(startOffset, endOffset);
                    for (Entity entity : entities) {

-                        if (dictionary.isHint(entity.getType())) {
+                        if (dictionary != null && dictionary.isHint(entity.getType())) {
                            continue;
                        }

@@ -104,7 +104,7 @@ public class EntitySearchUtils {
                    .collect(Collectors.toList());
            Entity firstEntity = orderedEntities.get(0);
            List<EntityPositionSequence> positionSequences = text.getSequences(firstEntity.getWord()
-                    .trim(), dictionary.isCaseInsensitiveDictionary(firstEntity.getType()), firstEntity.getTargetSequences());
+                    .trim(), dictionary == null ? true : dictionary.isCaseInsensitiveDictionary(firstEntity.getType()), firstEntity.getTargetSequences());

            for (int i = 0; i <= orderedEntities.size() - 1; i++) {
                try {
@@ -193,15 +193,35 @@ public class EntitySearchUtils {

        Set<Entity> result = new HashSet<>();
        if (existingEntities != null && foundEntities != null) {
-            for (Entity existingEntity : existingEntities) {
-                for (Entity foundEntity : foundEntities) {
-                    if (existingEntity.getEnd() < foundEntity.getStart() || foundEntity.getEnd() < existingEntity.getStart()) {
-                        result.add(foundEntity);
-                    }
+            for (Entity foundEntity : foundEntities) {
+
+                if (!overlaps(existingEntities, foundEntity)) {
+                    result.add(foundEntity);
                }
+
            }
        }
        return result;
    }

+
+    private boolean overlaps(Set<Entity> existingEntities, Entity found) {
+
+        for (Entity existing : existingEntities) {
+
+            if(existing.getStart().equals(found.getStart())){
+                continue;
+            }
+
+            for (int i = existing.getStart(); i <= existing.getEnd(); i++) {
+                for (int j = found.getStart(); j <= found.getEnd(); j++) {
+                    if (i == j) {
+                        return true;
+                    }
+                }
+            }
+        }
+        return false;
+    }
+
 }
@@ -82,6 +82,7 @@ import com.iqser.red.service.redaction.v1.server.client.RulesClient;
 import com.iqser.red.service.redaction.v1.server.controller.RedactionController;
 import com.iqser.red.service.redaction.v1.server.memory.MemoryStats;
 import com.iqser.red.service.redaction.v1.server.redaction.service.AnalyzeService;
+import com.iqser.red.service.redaction.v1.server.redaction.service.ManualRedactionSurroundingTextService;
 import com.iqser.red.service.redaction.v1.server.redaction.utils.ResourceLoader;
 import com.iqser.red.service.redaction.v1.server.redaction.utils.TextNormalizationUtilities;
 import com.iqser.red.service.redaction.v1.server.storage.RedactionStorageService;
@@ -145,6 +146,9 @@ public class RedactionIntegrationTest {
    @Autowired
    private StorageService storageService;

+    @Autowired
+    private ManualRedactionSurroundingTextService manualRedactionSurroundingTextService;
+
    @MockBean
    private AmazonS3 amazonS3;

@@ -607,6 +611,23 @@ public class RedactionIntegrationTest {
    }


+    @Test
+    public void redactionExpansionOverlap() throws IOException {
+
+        ClassPathResource pdfFileResource = new ClassPathResource("files/Minimal Examples/ExpansionTest.pdf");
+        AnalyzeRequest request = prepareStorage(pdfFileResource.getInputStream());
+
+        analyzeService.analyzeDocumentStructure(new StructureAnalyzeRequest(request.getDossierId(), request.getFileId()));
+        AnalyzeResult result = analyzeService.analyze(request);
+
+        var redactionLog = redactionStorageService.getRedactionLog(TEST_DOSSIER_ID, TEST_FILE_ID);
+
+        var values = redactionLog.getRedactionLogEntry().stream().map(RedactionLogEntry::getValue).collect(Collectors.toList());
+
+        assertThat(values).containsExactlyInAnyOrder("Lastname M.", "Doe", "Doe J.", "M. Mustermann", "Mustermann M.", "F. Lastname");
+    }
+
+
    @Test
    @Ignore
    public void noExceptionShouldBeThrownForAnyFiles() throws IOException {
@@ -1329,6 +1350,86 @@ public class RedactionIntegrationTest {
    }


+    @Test
+    public void testManualSurroundingText() throws IOException {
+
+        ClassPathResource pdfFileResource = new ClassPathResource("files/new/S4.pdf");
+
+        ManualRedactions manualRedactions = new ManualRedactions();
+
+        ManualRedactionEntry manualRedactionEntry = new ManualRedactionEntry();
+        manualRedactionEntry.setAnnotationId(UUID.randomUUID().toString());
+        manualRedactionEntry.setFileId("fileId");
+        manualRedactionEntry.setStatus(AnnotationStatus.APPROVED);
+        manualRedactionEntry.setType("CBI_author");
+        manualRedactionEntry.setValue("rabbits");
+        manualRedactionEntry.setReason("Manual Redaction");
+        manualRedactionEntry.setPositions(List.of(Rectangle.builder()
+                .topLeftX(70.944f)
+                .topLeftY(670.1595f)
+                .width(30.07296f)
+                .height(10.048125f)
+                .page(1)
+                .build()));
+
+        ManualRedactionEntry manualRedactionEntry2 = new ManualRedactionEntry();
+        manualRedactionEntry2.setAnnotationId(UUID.randomUUID().toString());
+        manualRedactionEntry2.setFileId("fileId");
+        manualRedactionEntry2.setStatus(AnnotationStatus.APPROVED);
+        manualRedactionEntry2.setType("CBI_author");
+        manualRedactionEntry2.setValue("rabbits");
+        manualRedactionEntry2.setReason("Manual Redaction");
+        manualRedactionEntry2.setPositions(List.of(Rectangle.builder()
+                .topLeftX(470.5204f)
+                .topLeftY(746.1195f)
+                .width(29.96256f)
+                .height(10.048125f)
+                .page(1)
+                .build()));
+
+        ManualRedactionEntry manualRedactionEntry3 = new ManualRedactionEntry();
+        manualRedactionEntry3.setAnnotationId(UUID.randomUUID().toString());
+        manualRedactionEntry3.setFileId("fileId");
+        manualRedactionEntry3.setStatus(AnnotationStatus.APPROVED);
+        manualRedactionEntry3.setType("CBI_author");
+        manualRedactionEntry3.setValue("AOEL");
+        manualRedactionEntry3.setReason("Manual Redaction");
+        manualRedactionEntry3.setPositions(List.of(Rectangle.builder()
+                .topLeftX(355.53775f)
+                .topLeftY(266.1895f)
+                .width(29.32224f)
+                .height(10.048125f)
+                .page(1)
+                .build()));
+
+        manualRedactions.getEntriesToAdd().add(manualRedactionEntry);
+        manualRedactions.getEntriesToAdd().add(manualRedactionEntry2);
+        manualRedactions.getEntriesToAdd().add(manualRedactionEntry3);
+
+        AnalyzeRequest request = prepareStorage(pdfFileResource.getInputStream());
+        request.setManualRedactions(manualRedactions);
+        analyzeService.analyzeDocumentStructure(new StructureAnalyzeRequest(request.getDossierId(), request.getFileId()));
+        AnalyzeResult result = analyzeService.analyze(request);
+
+        AnnotateResponse annotateResponse = redactionController.annotate(AnnotateRequest.builder()
+                .dossierId(TEST_DOSSIER_ID)
+                .dossierTemplateId(TEST_DOSSIER_TEMPLATE_ID)
+                .fileId(TEST_FILE_ID)
+                .manualRedactions(manualRedactions)
+                .build());
+
+        try (FileOutputStream fileOutputStream = new FileOutputStream(getTemporaryDirectory() + "/Annotated.pdf")) {
+            fileOutputStream.write(annotateResponse.getDocument());
+        }
+
+        var surroundingTextResult = manualRedactionSurroundingTextService.addSurroundingText(TEST_DOSSIER_ID, TEST_FILE_ID, manualRedactions);
+        surroundingTextResult.getEntriesToAdd().forEach(addEntry -> {
+            assertThat(addEntry.getTextAfter()).isNotEmpty();
+        });
+
+    }
+
+
    private static String loadFromClassPath(String path) {

        URL resource = ResourceLoader.class.getClassLoader().getResource(path);
@@ -1375,4 +1476,4 @@ public class RedactionIntegrationTest {
        return "/tmp";
    }

-}
+}
@@ -151,8 +151,7 @@ public class EntitySearchUtilsTest {
        Set<Entity> result = EntitySearchUtils.findNonOverlappingMatchEntities(existingEntities, foundEntities);

        // Assert
-        assertThat(result.size()).isEqualTo(1);
-        assertThat(result).contains(foundEntities2);
+        assertThat(result.size()).isEqualTo(0);

    }

@@ -182,8 +181,7 @@ public class EntitySearchUtilsTest {
        Set<Entity> result = EntitySearchUtils.findNonOverlappingMatchEntities(existingEntities, foundEntities);

        // Assert
-        assertThat(result.size()).isEqualTo(1);
-        assertThat(result).contains(foundEntities2);
+        assertThat(result.size()).isEqualTo(0);

    }

@@ -8615,4 +8615,9 @@ Zoriki Hosomi R.
 Zoriki Hosomi Rosana
 Zuberer D
 Zubrod J
-Zwicker R.E.
+Zwicker R.E.
+Doe
+M. Mustermann
+F. Lastname
+Mustermann
+Lastname
Author	SHA1	Message	Date
Ali Oezyetimoglu	3f153c1df5	Pull request #294 : RED-3075: Upgraded log4j to 2.15.0 Merge in RED/redaction-service from RED-3075-rs2 to master * commit '142c81d27d9e5e67532b3d8795c2d4c559342d37': RED-3075: Upgraded log4j to 2.15.0	2021-12-13 11:03:56 +01:00
aoezyetimoglu	142c81d27d	RED-3075: Upgraded log4j to 2.15.0	2021-12-13 10:59:16 +01:00
Dominique Eiflaender	a2c57b94a2	Pull request #292 : RED-3059: Fixed inital expansion overlaps Merge in RED/redaction-service from RED-3059-port to master * commit '0e21e5b4d988d43040573a4fc71547829c815ec0': RED-3059: Fixed inital expansion overlaps	2021-12-10 11:37:24 +01:00
deiflaender	0e21e5b4d9	RED-3059: Fixed inital expansion overlaps	2021-12-10 11:32:53 +01:00
Dominique Eiflaender	29a66ee5cf	Pull request #290 : RED-2439: Added endpoint to calculate textBefore and textAfter for manual redactions Merge in RED/redaction-service from RED-2439 to master * commit '6950c00711dc113bb012a9cd3cc26c5c276409a0': RED-2439: Added endpoint to calculate textBefore and textAfter for manual redactions	2021-12-09 16:19:24 +01:00
deiflaender	6950c00711	RED-2439: Added endpoint to calculate textBefore and textAfter for manual redactions	2021-12-09 16:12:02 +01:00
Philipp Schramm	fa4b2263bc	Pull request #288 : RED-2795 Bugfix with inconsistent types for recategorizing Images in specific cases Merge in RED/redaction-service from bugfix/RED-2795 to master * commit '415df2b3658b4525120a15fb0f341164a73bb3d4': RED-2795 Bugfix with inconsistent types for recategorizing Images in specific cases	2021-12-07 11:15:30 +01:00
Philipp Schramm	415df2b365	RED-2795 Bugfix with inconsistent types for recategorizing Images in specific cases	2021-12-07 11:10:53 +01:00