Pull request #299 : RED-3061 rs3

Merge in RED/redaction-service from RED-3061-rs3 to master * commit '1ccf0ab493fcb367a071641e2fea050cf6ad26cf': RED-3061: Logic for value matcher for initials expansion rule is inverted RED-3061: Logic for value matcher for initials expansion rule is inverted
RED-3061: Logic for value matcher for initials expansion rule is inverted
2021-12-14 12:35:45 +01:00 · 2021-12-14 12:25:21 +01:00 · 2021-12-14 11:10:59 +01:00 · 2021-12-13 13:55:52 +01:00 · 2021-12-13 13:51:33 +01:00 · 2021-12-13 12:32:20 +01:00
26 changed files with 1152 additions and 203 deletions
@@ -5,7 +5,7 @@
    <parent>
        <artifactId>platform-dependency</artifactId>
        <groupId>com.iqser.red</groupId>
-        <version>1.1.5</version>
+        <version>1.1.7</version>
    </parent>
    <modelVersion>4.0.0</modelVersion>

@@ -12,7 +12,7 @@
    <artifactId>redaction-service-api-v1</artifactId>

    <properties>
-        <persistence-service.version>0.103.0</persistence-service.version>
+        <persistence-service.version>0.135.0</persistence-service.version>
    </properties>

    <dependencies>
@@ -19,10 +19,11 @@ import java.util.Set;
@AllArgsConstructor
 public class AnalyzeRequest {

+    private MessageType messageType;
+
    private String dossierId;
    private String fileId;
    private String dossierTemplateId;
-    private boolean reanalyseOnlyIfPossible;
    private ManualRedactions manualRedactions;
    private OffsetDateTime lastProcessed;

@@ -1,5 +1,7 @@
 package com.iqser.red.service.redaction.v1.model;

+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualRedactions;
+
 import lombok.AllArgsConstructor;
 import lombok.Builder;
 import lombok.Data;
@@ -11,6 +13,8 @@ import lombok.NoArgsConstructor;
@AllArgsConstructor
 public class AnalyzeResult {

+    private MessageType messageType;
+
    private String dossierId;
    private String fileId;
    private long duration;
@@ -25,6 +29,8 @@ public class AnalyzeResult {

    private int analysisVersion;

+    private ManualRedactions manualRedactions;
+

 }

@@ -0,0 +1,7 @@
+package com.iqser.red.service.redaction.v1.model;
+
+public enum MessageType {
+
+    FULL_ANALYSE, REANALYSE, SURROUNDING_TEXT
+
+}
@@ -26,12 +26,18 @@ public class RedactionLogEntry {
    private String value;
    private String reason;
    private int matchedRule;
+    private boolean rectangle;
    private String legalBasis;
    private boolean redacted;
    private boolean isHint;
    private boolean isRecommendation;
+
    private boolean hasBeenResized;
    private boolean hasBeenRecategorized;
+    private boolean hasLegalBasisChanged;
+    private boolean hasBeenForced;
+    private boolean hasBeenRemovedByManualOverride;
+
    private String section;
    private float[] color;

@@ -30,4 +30,9 @@ public class SectionArea {
        return page == other.getPage() && this.topLeft.getX() <= other.getTopLeft().getX() && this.topLeft.getX() + this.getWidth() >= other.getTopLeft().getX() + other.getWidth() && this.getTopLeft().getY() <= other.getTopLeft().getY() && this.getTopLeft().getY() + this.getHeight() >= other.getTopLeft().getY() + other.getHeight();
    }

+    // TODO we should only use one rectangle class.
+    public boolean contains(com.iqser.red.service.persistence.service.v1.api.model.annotations.Rectangle other) {
+        return page == other.getPage() && this.topLeft.getX() <= other.getTopLeftX() && this.topLeft.getX() + this.getWidth() >= other.getTopLeftX() + other.getWidth() && this.getTopLeft().getY() <= other.getTopLeftY() && this.getTopLeft().getY() + this.getHeight() >= other.getTopLeftY() + other.getHeight();
+    }
+
 }
@@ -1,29 +1,43 @@
 package com.iqser.red.service.redaction.v1.resources;

+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualRedactions;
 import com.iqser.red.service.redaction.v1.model.*;
+
 import org.springframework.http.MediaType;
 import org.springframework.web.bind.annotation.PathVariable;
 import org.springframework.web.bind.annotation.PostMapping;
 import org.springframework.web.bind.annotation.RequestBody;
+import org.springframework.web.bind.annotation.RequestParam;

 public interface RedactionResource {

    @PostMapping(value = "/annotate", produces = MediaType.APPLICATION_JSON_VALUE, consumes = MediaType.APPLICATION_JSON_VALUE)
    AnnotateResponse annotate(@RequestBody AnnotateRequest annotateRequest);

+
    @PostMapping(value = "/debug/classifications", produces = MediaType.APPLICATION_JSON_VALUE, consumes = MediaType.APPLICATION_JSON_VALUE)
    RedactionResult classify(@RequestBody RedactionRequest redactionRequest);

+
    @PostMapping(value = "/debug/sections", produces = MediaType.APPLICATION_JSON_VALUE, consumes = MediaType.APPLICATION_JSON_VALUE)
    RedactionResult sections(@RequestBody RedactionRequest redactionRequest);

+
    @PostMapping(value = "/debug/htmlTables", produces = MediaType.APPLICATION_JSON_VALUE, consumes = MediaType.APPLICATION_JSON_VALUE)
    RedactionResult htmlTables(@RequestBody RedactionRequest redactionRequest);

+
    @PostMapping(value = "/rules/test", consumes = MediaType.APPLICATION_JSON_VALUE)
    void testRules(@RequestBody String rules);

+
    @PostMapping(value = "/redaction-log/preview", consumes = MediaType.APPLICATION_JSON_VALUE)
    RedactionLog getRedactionLog(@RequestBody RedactionRequest redactionRequest);

+
+    @PostMapping(value = "/manual/surrounding-text/{dossierId}/{fileId}", consumes = MediaType.APPLICATION_JSON_VALUE, produces = MediaType.APPLICATION_JSON_VALUE)
+    ManualRedactions addSurroundingText(@PathVariable("dossierId") String dossierId,
+                                        @PathVariable("fileId") String fileId,
+                                        @RequestBody ManualRedactions manualRedactions);
+
 }
@@ -1,7 +1,24 @@
 package com.iqser.red.service.redaction.v1.server.controller;

+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.util.stream.Collectors;
+
+import org.apache.pdfbox.io.MemoryUsageSetting;
+import org.apache.pdfbox.pdmodel.PDDocument;
+import org.springframework.web.bind.annotation.PathVariable;
+import org.springframework.web.bind.annotation.RequestBody;
+import org.springframework.web.bind.annotation.RestController;
+
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualRedactions;
 import com.iqser.red.service.persistence.service.v1.api.model.dossiertemplate.dossier.file.FileType;
-import com.iqser.red.service.redaction.v1.model.*;
+import com.iqser.red.service.redaction.v1.model.AnnotateRequest;
+import com.iqser.red.service.redaction.v1.model.AnnotateResponse;
+import com.iqser.red.service.redaction.v1.model.RedactionLog;
+import com.iqser.red.service.redaction.v1.model.RedactionRequest;
+import com.iqser.red.service.redaction.v1.model.RedactionResult;
+import com.iqser.red.service.redaction.v1.model.SectionArea;
+import com.iqser.red.service.redaction.v1.model.SectionGrid;
 import com.iqser.red.service.redaction.v1.resources.RedactionResource;
 import com.iqser.red.service.redaction.v1.server.classification.model.Document;
 import com.iqser.red.service.redaction.v1.server.classification.model.Page;
@@ -10,22 +27,16 @@ import com.iqser.red.service.redaction.v1.server.exception.RedactionException;
 import com.iqser.red.service.redaction.v1.server.redaction.service.AnnotationService;
 import com.iqser.red.service.redaction.v1.server.redaction.service.DictionaryService;
 import com.iqser.red.service.redaction.v1.server.redaction.service.DroolsExecutionService;
+import com.iqser.red.service.redaction.v1.server.redaction.service.ManualRedactionSurroundingTextService;
 import com.iqser.red.service.redaction.v1.server.redaction.service.RedactionLogMergeService;
 import com.iqser.red.service.redaction.v1.server.segmentation.PdfSegmentationService;
 import com.iqser.red.service.redaction.v1.server.storage.RedactionStorageService;
 import com.iqser.red.service.redaction.v1.server.tableextraction.model.AbstractTextContainer;
 import com.iqser.red.service.redaction.v1.server.tableextraction.model.Table;
 import com.iqser.red.service.redaction.v1.server.visualization.service.PdfVisualisationService;
+
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
-import org.apache.pdfbox.io.MemoryUsageSetting;
-import org.apache.pdfbox.pdmodel.PDDocument;
-import org.springframework.web.bind.annotation.RequestBody;
-import org.springframework.web.bind.annotation.RestController;
-
-import java.io.ByteArrayOutputStream;
-import java.io.IOException;
-import java.util.stream.Collectors;

@Slf4j
@RestController
@@ -39,11 +50,19 @@ public class RedactionController implements RedactionResource {
    private final PdfSegmentationService pdfSegmentationService;
    private final RedactionStorageService redactionStorageService;
    private final RedactionLogMergeService redactionLogMergeService;
+    private final ManualRedactionSurroundingTextService manualRedactionSurroundingTextService;
+

    public AnnotateResponse annotate(@RequestBody AnnotateRequest annotateRequest) {

-        var storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(annotateRequest.getDossierId(), annotateRequest.getFileId(), FileType.ORIGIN));
-        var mergedRedactionLog = getRedactionLog(RedactionRequest.builder().fileId(annotateRequest.getFileId()).manualRedactions(annotateRequest.getManualRedactions()).dossierId(annotateRequest.getDossierId()).dossierTemplateId(annotateRequest.getDossierTemplateId()).build());
+        var storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(annotateRequest
+                .getDossierId(), annotateRequest.getFileId(), FileType.ORIGIN));
+        var mergedRedactionLog = getRedactionLog(RedactionRequest.builder()
+                .fileId(annotateRequest.getFileId())
+                .manualRedactions(annotateRequest.getManualRedactions())
+                .dossierId(annotateRequest.getDossierId())
+                .dossierTemplateId(annotateRequest.getDossierTemplateId())
+                .build());
        var sectionsGrid = redactionStorageService.getSectionGrid(annotateRequest.getDossierId(), annotateRequest.getFileId());

        try (PDDocument pdDocument = PDDocument.load(storedObjectStream, MemoryUsageSetting.setupTempFileOnly())) {
@@ -65,11 +84,14 @@ public class RedactionController implements RedactionResource {

    @Override
    public RedactionResult classify(@RequestBody RedactionRequest redactionRequest) {
-        var storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest.getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
+
+        var storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest
+                .getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
        try {
            Document classifiedDoc = pdfSegmentationService.parseDocument(storedObjectStream);

-            storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest.getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
+            storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest
+                    .getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
            try (PDDocument pdDocument = PDDocument.load(storedObjectStream)) {
                pdDocument.setAllSecurityToBeRemoved(true);

@@ -85,16 +107,19 @@ public class RedactionController implements RedactionResource {
            throw new RedactionException(e);
        }

-
    }

+
    @Override
    public RedactionResult sections(@RequestBody RedactionRequest redactionRequest) {
-        var storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest.getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
+
+        var storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest
+                .getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
        try {
            Document classifiedDoc = pdfSegmentationService.parseDocument(storedObjectStream);

-            storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest.getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
+            storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest
+                    .getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
            try (PDDocument pdDocument = PDDocument.load(storedObjectStream)) {
                pdDocument.setAllSecurityToBeRemoved(true);

@@ -109,7 +134,6 @@ public class RedactionController implements RedactionResource {
            throw new RedactionException(e);
        }

-
    }


@@ -119,13 +143,13 @@ public class RedactionController implements RedactionResource {
        Document classifiedDoc;

        try {
-            var storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest.getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
+            var storedObjectStream = redactionStorageService.getStoredObject(RedactionStorageService.StorageIdUtils.getStorageId(redactionRequest
+                    .getDossierId(), redactionRequest.getFileId(), FileType.ORIGIN));
            classifiedDoc = pdfSegmentationService.parseDocument(storedObjectStream, true);
        } catch (Exception e) {
            throw new RedactionException(e);
        }

-
        StringBuilder sb = new StringBuilder();
        for (Page page : classifiedDoc.getPages()) {
            for (AbstractTextContainer textContainer : page.getTextBlocks()) {
@@ -140,12 +164,14 @@ public class RedactionController implements RedactionResource {

    }

+
    @Override
    public void testRules(@RequestBody String rules) {

        droolsExecutionService.testRules(rules);
    }

+
    @Override
    public RedactionLog getRedactionLog(RedactionRequest redactionRequest) {

@@ -160,7 +186,8 @@ public class RedactionController implements RedactionResource {

        log.info("Loaded redaction log with computationalVersion: {}", redactionLog.getAnalysisVersion());

-        SectionGrid sectionGrid = redactionStorageService.getSectionGrid(redactionRequest.getDossierId(), redactionRequest.getFileId());
+        SectionGrid sectionGrid = redactionStorageService.getSectionGrid(redactionRequest.getDossierId(), redactionRequest
+                .getFileId());
        if (sectionGrid.getSections().isEmpty()) {

            log.info("SectionGrid does not have headlines set. Computing headlines now!");
@@ -168,24 +195,27 @@ public class RedactionController implements RedactionResource {

            // enhance section grid with headline data
            for (var sectionText : text.getSectionTexts()) {
-                sectionGrid.getSections().add(new SectionGrid.SectionGridSection(sectionText.getSectionNumber(),
-                        sectionText.getHeadline(),
-                        sectionText.getSectionAreas().stream().map(SectionArea::getPage).collect(Collectors.toSet()),
-                        sectionText.getSectionAreas()));
+                sectionGrid.getSections()
+                        .add(new SectionGrid.SectionGridSection(sectionText.getSectionNumber(), sectionText.getHeadline(), sectionText
+                                .getSectionAreas()
+                                .stream()
+                                .map(SectionArea::getPage)
+                                .collect(Collectors.toSet()), sectionText.getSectionAreas()));
            }
            redactionStorageService.storeObject(redactionRequest.getDossierId(), redactionRequest.getFileId(), FileType.SECTION_GRID, sectionGrid);
        }

-
        log.info("Loaded redaction log with computationalVersion: {}", redactionLog.getAnalysisVersion());
        if (redactionLog.getAnalysisVersion() == 0) {
            // old redaction logs are returned directly
            return redactionLog;
        } else {
-            return redactionLogMergeService.mergeRedactionLogData(redactionLog, sectionGrid, redactionRequest.getDossierTemplateId(), redactionRequest.getManualRedactions(), redactionRequest.getExcludedPages());
+            return redactionLogMergeService.mergeRedactionLogData(redactionLog, sectionGrid, redactionRequest.getDossierTemplateId(), redactionRequest
+                    .getManualRedactions(), redactionRequest.getExcludedPages());
        }
    }

+
    private RedactionResult convert(PDDocument document, int numberOfPages) throws IOException {

        try (ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream()) {
@@ -199,4 +229,16 @@ public class RedactionController implements RedactionResource {
    }


+    @Override
+    public ManualRedactions addSurroundingText(@PathVariable("dossierId") String dossierId,
+                                               @PathVariable("fileId") String fileId,
+                                               @RequestBody ManualRedactions manualRedactions) {
+
+        long start = System.currentTimeMillis();
+        var result = manualRedactionSurroundingTextService.addSurroundingText(dossierId, fileId, manualRedactions);
+        log.info("add surrounding text for manual redaction in dossierId {} and fileId {} took: {}", dossierId, fileId, System
+                .currentTimeMillis() - start);
+        return result;
+    }
+
 }
@@ -7,6 +7,7 @@ import com.iqser.red.service.redaction.v1.model.AnalyzeResult;
 import com.iqser.red.service.redaction.v1.model.StructureAnalyzeRequest;
 import com.iqser.red.service.redaction.v1.server.client.FileStatusProcessingUpdateClient;
 import com.iqser.red.service.redaction.v1.server.redaction.service.AnalyzeService;
+import com.iqser.red.service.redaction.v1.server.redaction.service.ManualRedactionSurroundingTextService;
 import com.iqser.red.service.redaction.v1.server.redaction.service.NerAnalyserService;

 import lombok.RequiredArgsConstructor;
@@ -28,6 +29,7 @@ public class RedactionMessageReceiver {
    private final AnalyzeService analyzeService;
    private final FileStatusProcessingUpdateClient fileStatusProcessingUpdateClient;
    private final NerAnalyserService nerAnalyserService;
+    private final ManualRedactionSurroundingTextService manualRedactionSurroundingTextService;


    @RabbitHandler
@@ -36,22 +38,37 @@ public class RedactionMessageReceiver {

        var analyzeRequest = objectMapper.readValue(in, AnalyzeRequest.class);
        log.info("Processing analyze request for file: {}", analyzeRequest.getFileId());
-        AnalyzeResult result;
-        if (analyzeRequest.isReanalyseOnlyIfPossible()) {
-            result = analyzeService.reanalyze(analyzeRequest);
-            log.info("Successfully reanalyzed dossier {} file {} took: {}", analyzeRequest.getDossierId(), analyzeRequest.getFileId(), result.getDuration());
-        } else {
-            // TODO Seperate stucture analysis by other queue
-            analyzeService.analyzeDocumentStructure(new StructureAnalyzeRequest(analyzeRequest.getDossierId(), analyzeRequest.getFileId()));
+        AnalyzeResult result = null;

-            // TODO NerEntities should be computed and stored in entity-recognition-service, should be triggered by a seperate queue after structure analysis
-            nerAnalyserService.computeNerEntities(analyzeRequest.getDossierId(), analyzeRequest.getFileId());
+        switch (analyzeRequest.getMessageType()){

-            result = analyzeService.analyze(analyzeRequest);
-            log.info("Successfully analyzed dossier {} file {} took: {}", analyzeRequest.getDossierId(), analyzeRequest.getFileId(), result
-                    .getDuration());
+            case REANALYSE:
+                result = analyzeService.reanalyze(analyzeRequest);
+                log.info("Successfully reanalyzed dossier {} file {} took: {}", analyzeRequest.getDossierId(), analyzeRequest.getFileId(), result.getDuration());
+                break;
+            case FULL_ANALYSE:
+                // TODO Seperate stucture analysis by other queue
+                analyzeService.analyzeDocumentStructure(new StructureAnalyzeRequest(analyzeRequest.getDossierId(), analyzeRequest.getFileId()));
+
+                // TODO NerEntities should be computed and stored in entity-recognition-service, should be triggered by a seperate queue after structure analysis
+                nerAnalyserService.computeNerEntities(analyzeRequest.getDossierId(), analyzeRequest.getFileId());
+
+                result = analyzeService.analyze(analyzeRequest);
+                log.info("Successfully analyzed dossier {} file {} took: {}", analyzeRequest.getDossierId(), analyzeRequest.getFileId(), result
+                        .getDuration());
+
+                break;
+            case SURROUNDING_TEXT:
+                var manualRedactions = manualRedactionSurroundingTextService.addSurroundingText(analyzeRequest.getDossierId(), analyzeRequest.getFileId(), analyzeRequest.getManualRedactions());
+                result = AnalyzeResult.builder()
+                        .dossierId(analyzeRequest.getDossierId())
+                        .fileId(analyzeRequest.getFileId())
+                        .manualRedactions(manualRedactions)
+                        .build();
+                break;
        }

+        result.setMessageType(analyzeRequest.getMessageType());
        fileStatusProcessingUpdateClient.analysisSuccessful(analyzeRequest.getDossierId(), analyzeRequest.getFileId(), result);
    }

@@ -1,26 +1,34 @@
 package com.iqser.red.service.redaction.v1.server.redaction.model;

+import static com.iqser.red.service.redaction.v1.server.redaction.model.Dictionary.RECOMMENDATION_PREFIX;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+import java.util.stream.Collectors;
+
+import org.apache.commons.lang3.StringUtils;
+
 import com.iqser.red.service.redaction.v1.model.ArgumentType;
 import com.iqser.red.service.redaction.v1.model.Engine;
 import com.iqser.red.service.redaction.v1.model.FileAttribute;
 import com.iqser.red.service.redaction.v1.server.classification.model.TextBlock;
 import com.iqser.red.service.redaction.v1.server.redaction.utils.EntitySearchUtils;
 import com.iqser.red.service.redaction.v1.server.redaction.utils.Patterns;
+
 import lombok.Builder;
 import lombok.Data;
 import lombok.extern.slf4j.Slf4j;
-import org.apache.commons.lang3.StringUtils;
-
-import java.lang.annotation.ElementType;
-import java.lang.annotation.Retention;
-import java.lang.annotation.RetentionPolicy;
-import java.lang.annotation.Target;
-import java.util.*;
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
-import java.util.stream.Collectors;
-
-import static com.iqser.red.service.redaction.v1.server.redaction.model.Dictionary.RECOMMENDATION_PREFIX;

@Data
@Slf4j
@@ -62,39 +70,69 @@ public class Section {
    @WhenCondition
    public boolean fileAttributeByIdEquals(@Argument(ArgumentType.FILE_ATTRIBUTE) String id,
                                           @Argument(ArgumentType.STRING) String value) {
-        return fileAttributes != null && fileAttributes.stream().filter(attribute -> id.equals(attribute.getId()) && value.equals(attribute.getValue())).findFirst().isPresent();
+
+        return fileAttributes != null && fileAttributes.stream()
+                .filter(attribute -> id.equals(attribute.getId()) && value.equals(attribute.getValue()))
+                .findFirst()
+                .isPresent();
    }

+
    @WhenCondition
    public boolean fileAttributeByPlaceholderEquals(@Argument(ArgumentType.FILE_ATTRIBUTE) String placeholder,
                                                    @Argument(ArgumentType.STRING) String value) {
-        return fileAttributes != null && fileAttributes.stream().filter(attribute -> placeholder.equals(attribute.getPlaceholder()) && value.equals(attribute.getValue())).findFirst().isPresent();
+
+        return fileAttributes != null && fileAttributes.stream()
+                .filter(attribute -> placeholder.equals(attribute.getPlaceholder()) && value.equals(attribute.getValue()))
+                .findFirst()
+                .isPresent();
    }

+
    @WhenCondition
    public boolean fileAttributeByLabelEquals(@Argument(ArgumentType.FILE_ATTRIBUTE) String label,
                                              @Argument(ArgumentType.STRING) String value) {
-        return fileAttributes != null && fileAttributes.stream().filter(attribute -> label.equals(attribute.getLabel()) && value.equals(attribute.getValue())).findFirst().isPresent();
+
+        return fileAttributes != null && fileAttributes.stream()
+                .filter(attribute -> label.equals(attribute.getLabel()) && value.equals(attribute.getValue()))
+                .findFirst()
+                .isPresent();
    }

+
    @WhenCondition
    public boolean fileAttributeByIdEqualsIgnoreCase(@Argument(ArgumentType.FILE_ATTRIBUTE) String id,
                                                     @Argument(ArgumentType.STRING) String value) {
-        return fileAttributes != null && fileAttributes.stream().filter(attribute -> id.equals(attribute.getId()) && value.equalsIgnoreCase(attribute.getValue())).findFirst().isPresent();
+
+        return fileAttributes != null && fileAttributes.stream()
+                .filter(attribute -> id.equals(attribute.getId()) && value.equalsIgnoreCase(attribute.getValue()))
+                .findFirst()
+                .isPresent();
    }

+
    @WhenCondition
    public boolean fileAttributeByPlaceholderEqualsIgnoreCase(@Argument(ArgumentType.FILE_ATTRIBUTE) String placeholder,
                                                              @Argument(ArgumentType.STRING) String value) {
-        return fileAttributes != null && fileAttributes.stream().filter(attribute -> placeholder.equals(attribute.getPlaceholder()) && value.equalsIgnoreCase(attribute.getValue())).findFirst().isPresent();
+
+        return fileAttributes != null && fileAttributes.stream()
+                .filter(attribute -> placeholder.equals(attribute.getPlaceholder()) && value.equalsIgnoreCase(attribute.getValue()))
+                .findFirst()
+                .isPresent();
    }

+
    @WhenCondition
    public boolean fileAttributeByLabelEqualsIgnoreCase(@Argument(ArgumentType.FILE_ATTRIBUTE) String label,
                                                        @Argument(ArgumentType.STRING) String value) {
-        return fileAttributes != null && fileAttributes.stream().filter(attribute -> label.equals(attribute.getLabel()) && value.equalsIgnoreCase(attribute.getValue())).findFirst().isPresent();
+
+        return fileAttributes != null && fileAttributes.stream()
+                .filter(attribute -> label.equals(attribute.getLabel()) && value.equalsIgnoreCase(attribute.getValue()))
+                .findFirst()
+                .isPresent();
    }

+
    @WhenCondition
    public boolean rowEquals(@Argument(ArgumentType.STRING) String headerName,
                             @Argument(ArgumentType.STRING) String value) {
@@ -106,6 +144,7 @@ public class Section {
                .equals(value);
    }

+
    @WhenCondition
    public boolean hasTableHeader(@Argument(ArgumentType.STRING) String headerName) {

@@ -113,31 +152,50 @@ public class Section {
        return tabularData != null && tabularData.containsKey(cleanHeaderName);
    }

+
    @WhenCondition
    public boolean matchesType(@Argument(ArgumentType.TYPE) String type) {

        return entities.stream().anyMatch(entity -> entity.getType().equals(type));
    }

+
    @WhenCondition
    public boolean matchesImageType(@Argument(ArgumentType.TYPE) String type) {

        return images.stream().anyMatch(image -> image.getType().equals(type));
    }

+
    @WhenCondition
    public boolean headlineContainsWord(@Argument(ArgumentType.STRING) String word) {

        return StringUtils.containsIgnoreCase(headline, word);
    }

+
    @ThenAction
-    public void expandByRegEx(@Argument(ArgumentType.TYPE) String type,
-                              @Argument(ArgumentType.REGEX) String pattern,
+    public void expandByRegEx(@Argument(ArgumentType.TYPE) String type, @Argument(ArgumentType.REGEX) String suffixPattern,
                              @Argument(ArgumentType.BOOLEAN) boolean patternCaseInsensitive,
                              @Argument(ArgumentType.INTEGER) int group) {

-        Pattern compiledPattern = Patterns.getCompiledPattern(pattern, patternCaseInsensitive);
+        expandByRegEx(type, suffixPattern, patternCaseInsensitive, group, null);
+    }
+
+
+    @ThenAction
+    public void expandByRegEx(@Argument(ArgumentType.TYPE) String type, @Argument(ArgumentType.REGEX) String suffixPattern,
+                              @Argument(ArgumentType.BOOLEAN) boolean patternCaseInsensitive,
+                              @Argument(ArgumentType.INTEGER) int group,
+                              @Argument(ArgumentType.REGEX) String valuePattern) {
+
+        Pattern compiledValuePattern = null;
+
+        if (valuePattern != null) {
+            compiledValuePattern = Patterns.getCompiledPattern(valuePattern, patternCaseInsensitive);
+        }
+
+        Pattern compiledPattern = Patterns.getCompiledPattern(suffixPattern, patternCaseInsensitive);

        Set<Entity> expanded = new HashSet<>();
        for (Entity entity : entities) {
@@ -146,14 +204,21 @@ public class Section {
                continue;
            }

+            if (valuePattern != null) {
+                Matcher valueMatcher = compiledValuePattern.matcher(entity.getWord());
+                if (!valueMatcher.matches()) {
+                    continue;
+                }
+            }
+
            Matcher matcher = compiledPattern.matcher(entity.getTextAfter());

            while (matcher.find()) {
                String match = matcher.group(group);
-                if (StringUtils.isNotBlank(match)) {
-                    expanded.addAll(findEntities(entity.getWord() + match, type, false, entity.isRedaction(), entity.getMatchedRule(), entity
-                            .getRedactionReason(), entity.getLegalBasis()));

+                if (StringUtils.isNotBlank(match)) {
+                    Set<Entity> expandedEntities = findEntities(entity.getWord() + match, type, false, entity.isRedaction(), entity.getMatchedRule(), entity.getRedactionReason(), entity.getLegalBasis());
+                    expanded.addAll(EntitySearchUtils.findNonOverlappingMatchEntities(entities, expandedEntities));
                }
            }
        }
@@ -162,6 +227,7 @@ public class Section {
        EntitySearchUtils.removeEntitiesContainedInLarger(entities);
    }

+
    @ThenAction
    public void redactImage(@Argument(ArgumentType.TYPE) String type,
                            @Argument(ArgumentType.RULE_NUMBER) int ruleNumber,
@@ -178,9 +244,9 @@ public class Section {
        });
    }

+
    @ThenAction
-    public void redact(@Argument(ArgumentType.TYPE) String type,
-                       @Argument(ArgumentType.RULE_NUMBER) int ruleNumber,
+    public void redact(@Argument(ArgumentType.TYPE) String type, @Argument(ArgumentType.RULE_NUMBER) int ruleNumber,
                       @Argument(ArgumentType.STRING) String reason,
                       @Argument(ArgumentType.LEGAL_BASIS) String legalBasis) {

@@ -197,6 +263,7 @@ public class Section {
        });
    }

+
    @ThenAction
    public void redactNotImage(@Argument(ArgumentType.TYPE) String type,
                               @Argument(ArgumentType.RULE_NUMBER) int ruleNumber,
@@ -211,9 +278,9 @@ public class Section {
        });
    }

+
    @ThenAction
-    public void redactNot(@Argument(ArgumentType.TYPE) String type,
-                          @Argument(ArgumentType.RULE_NUMBER) int ruleNumber,
+    public void redactNot(@Argument(ArgumentType.TYPE) String type, @Argument(ArgumentType.RULE_NUMBER) int ruleNumber,
                          @Argument(ArgumentType.STRING) String reason) {

        boolean hasRecommendationDictionary = dictionaryTypes.contains(RECOMMENDATION_PREFIX + type);
@@ -229,15 +296,22 @@ public class Section {
    }


+    public void ignore(String type){
+        entities.removeIf(entity -> entity.getType().equals(type));
+    }
+
+
    @ThenAction
    public void redactNotAndReference(@Argument(ArgumentType.TYPE) String type,
                                      @Argument(ArgumentType.REFERENCE_TYPE) String referenceType,
-                          @Argument(ArgumentType.RULE_NUMBER) int ruleNumber,
-                          @Argument(ArgumentType.STRING) String reason) {
+                                      @Argument(ArgumentType.RULE_NUMBER) int ruleNumber,
+                                      @Argument(ArgumentType.STRING) String reason) {

        boolean hasRecommendationDictionary = dictionaryTypes.contains(RECOMMENDATION_PREFIX + type);

-        Set<Entity> references = entities.stream().filter(entity -> entity.getType().equals(referenceType)).collect(Collectors.toSet());
+        Set<Entity> references = entities.stream()
+                .filter(entity -> entity.getType().equals(referenceType))
+                .collect(Collectors.toSet());

        entities.forEach(entity -> {
            if (entity.getType().equals(type) || hasRecommendationDictionary && entity.getType()
@@ -251,7 +325,6 @@ public class Section {
    }


-
    @ThenAction
    public void expandToHintAnnotationByRegEx(@Argument(ArgumentType.TYPE) String type,
                                              @Argument(ArgumentType.STRING) String pattern,
@@ -282,6 +355,7 @@ public class Section {
        EntitySearchUtils.removeEntitiesContainedInLarger(entities);
    }

+
    @ThenAction
    public void addHintAnnotationByRegEx(@Argument(ArgumentType.REGEX) String pattern,
                                         @Argument(ArgumentType.BOOLEAN) boolean patternCaseInsensitive,
@@ -301,6 +375,7 @@ public class Section {
        }
    }

+
    @ThenAction
    public void redactIfPrecededBy(@Argument(ArgumentType.STRING) String prefix,
                                   @Argument(ArgumentType.TYPE) String type,
@@ -318,6 +393,7 @@ public class Section {
        });
    }

+
    @ThenAction
    public void addHintAnnotation(@Argument(ArgumentType.STRING) String value,
                                  @Argument(ArgumentType.TYPE) String asType) {
@@ -326,9 +402,9 @@ public class Section {
        EntitySearchUtils.addEntitiesIgnoreRank(entities, found);
    }

+
    @ThenAction
-    public void addRedaction(@Argument(ArgumentType.STRING) String value,
-                             @Argument(ArgumentType.TYPE) String asType,
+    public void addRedaction(@Argument(ArgumentType.STRING) String value, @Argument(ArgumentType.TYPE) String asType,
                             @Argument(ArgumentType.RULE_NUMBER) int ruleNumber,
                             @Argument(ArgumentType.STRING) String reason,
                             @Argument(ArgumentType.LEGAL_BASIS) String legalBasis) {
@@ -337,9 +413,9 @@ public class Section {
        EntitySearchUtils.addEntitiesIgnoreRank(entities, found);
    }

+
    @ThenAction
-    public void redactLineAfter(@Argument(ArgumentType.STRING) String start,
-                                @Argument(ArgumentType.TYPE) String asType,
+    public void redactLineAfter(@Argument(ArgumentType.STRING) String start, @Argument(ArgumentType.TYPE) String asType,
                                @Argument(ArgumentType.RULE_NUMBER) int ruleNumber,
                                @Argument(ArgumentType.BOOLEAN) boolean redactEverywhere,
                                @Argument(ArgumentType.STRING) String reason,
@@ -361,6 +437,7 @@ public class Section {
        }
    }

+
    @ThenAction
    public void recommendLineAfter(@Argument(ArgumentType.STRING) String start,
                                   @Argument(ArgumentType.TYPE) String asType) {
@@ -386,11 +463,11 @@ public class Section {
        }
    }

+
    @ThenAction
    public void redactByRegEx(@Argument(ArgumentType.REGEX) String pattern,
                              @Argument(ArgumentType.BOOLEAN) boolean patternCaseInsensitive,
-                              @Argument(ArgumentType.INTEGER) int group,
-                              @Argument(ArgumentType.TYPE) String asType,
+                              @Argument(ArgumentType.INTEGER) int group, @Argument(ArgumentType.TYPE) String asType,
                              @Argument(ArgumentType.RULE_NUMBER) int ruleNumber,
                              @Argument(ArgumentType.STRING) String reason,
                              @Argument(ArgumentType.LEGAL_BASIS) String legalBasis) {
@@ -408,6 +485,7 @@ public class Section {
        }
    }

+
    @ThenAction
    public void addRecommendationByRegEx(@Argument(ArgumentType.REGEX) String pattern,
                                         @Argument(ArgumentType.BOOLEAN) boolean patternCaseInsensitive,
@@ -426,6 +504,7 @@ public class Section {
        }
    }

+
    @ThenAction
    public void redactAndRecommendByRegEx(@Argument(ArgumentType.REGEX) String pattern,
                                          @Argument(ArgumentType.BOOLEAN) boolean patternCaseInsensitive,
@@ -448,9 +527,9 @@ public class Section {
        }
    }

+
    @ThenAction
-    public void redactBetween(@Argument(ArgumentType.STRING) String start,
-                              @Argument(ArgumentType.STRING) String stop,
+    public void redactBetween(@Argument(ArgumentType.STRING) String start, @Argument(ArgumentType.STRING) String stop,
                              @Argument(ArgumentType.TYPE) String asType,
                              @Argument(ArgumentType.RULE_NUMBER) int ruleNumber,
                              @Argument(ArgumentType.BOOLEAN) boolean redactEverywhere,
@@ -474,6 +553,7 @@ public class Section {
        }
    }

+
    @ThenAction
    public void redactLinesBetween(@Argument(ArgumentType.STRING) String start,
                                   @Argument(ArgumentType.STRING) String stop,
@@ -508,6 +588,7 @@ public class Section {
        }
    }

+
    @ThenAction
    public void highlightCell(@Argument(ArgumentType.STRING) String cellHeader,
                              @Argument(ArgumentType.RULE_NUMBER) int ruleNumber,
@@ -516,10 +597,10 @@ public class Section {
        annotateCell(cellHeader, ruleNumber, type, false, false, null, null);
    }

+
    @ThenAction
    public void redactCell(@Argument(ArgumentType.STRING) String cellHeader,
-                           @Argument(ArgumentType.RULE_NUMBER) int ruleNumber,
-                           @Argument(ArgumentType.TYPE) String type,
+                           @Argument(ArgumentType.RULE_NUMBER) int ruleNumber, @Argument(ArgumentType.TYPE) String type,
                           @Argument(ArgumentType.BOOLEAN) boolean addAsRecommendations,
                           @Argument(ArgumentType.STRING) String reason,
                           @Argument(ArgumentType.LEGAL_BASIS) String legalBasis) {
@@ -527,6 +608,7 @@ public class Section {
        annotateCell(cellHeader, ruleNumber, type, true, addAsRecommendations, reason, legalBasis);
    }

+
    @ThenAction
    public void redactNotCell(@Argument(ArgumentType.STRING) String cellHeader,
                              @Argument(ArgumentType.RULE_NUMBER) int ruleNumber,
@@ -613,6 +695,7 @@ public class Section {
        }
    }

+
    @Retention(RetentionPolicy.RUNTIME)
    @Target(ElementType.METHOD)
    public @interface WhenCondition {
@@ -630,6 +713,7 @@ public class Section {
    public @interface Argument {

        ArgumentType value() default ArgumentType.STRING;
+
    }

 }
@@ -0,0 +1,141 @@
+package com.iqser.red.service.redaction.v1.server.redaction.service;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+
+import org.apache.commons.lang3.tuple.Pair;
+import org.springframework.stereotype.Service;
+
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualRedactionEntry;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualRedactions;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualResizeRedaction;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.Rectangle;
+import com.iqser.red.service.redaction.v1.model.Engine;
+import com.iqser.red.service.redaction.v1.model.SectionArea;
+import com.iqser.red.service.redaction.v1.server.classification.model.SectionText;
+import com.iqser.red.service.redaction.v1.server.classification.model.Text;
+import com.iqser.red.service.redaction.v1.server.parsing.model.TextPositionSequence;
+import com.iqser.red.service.redaction.v1.server.redaction.model.Entity;
+import com.iqser.red.service.redaction.v1.server.redaction.model.EntityPositionSequence;
+import com.iqser.red.service.redaction.v1.server.redaction.utils.EntitySearchUtils;
+import com.iqser.red.service.redaction.v1.server.storage.RedactionStorageService;
+
+import lombok.RequiredArgsConstructor;
+
+@Service
+@RequiredArgsConstructor
+public class ManualRedactionSurroundingTextService {
+
+    private final RedactionStorageService redactionStorageService;
+    private final SurroundingWordsService surroundingWordsService;
+
+
+    public ManualRedactions addSurroundingText(String dossierId, String fileId, ManualRedactions manualRedactions) {
+
+        Text text = redactionStorageService.getText(dossierId, fileId);
+        List<ManualRedactionEntry> processedAddRedactions = new ArrayList<>();
+        List<ManualResizeRedaction> processedResizeRedactions = new ArrayList<>();
+
+        for (SectionText sectionText : text.getSectionTexts()) {
+
+            if (manualRedactions.getEntriesToAdd().isEmpty() && manualRedactions.getResizeRedactions().isEmpty()) {
+                break;
+            }
+
+            for (SectionArea sectionArea : sectionText.getSectionAreas()) {
+
+                var addItty = manualRedactions.getEntriesToAdd().iterator();
+                while (addItty.hasNext()) {
+                    var manualAddRedaction = addItty.next();
+                    if (sectionContainsEntry(sectionArea, manualAddRedaction.getPositions())) {
+                        var surroundingText = findSurroundingText(sectionText, manualAddRedaction.getValue(), manualAddRedaction
+                                .getPositions());
+                        manualAddRedaction.setTextBefore(surroundingText.getLeft());
+                        manualAddRedaction.setTextAfter(surroundingText.getRight());
+                        processedAddRedactions.add(manualAddRedaction);
+                        addItty.remove();
+                    }
+                }
+
+                var resizeItty = manualRedactions.getResizeRedactions().iterator();
+                while (resizeItty.hasNext()) {
+                    var manualResizeRedaction = resizeItty.next();
+                    if (sectionContainsEntry(sectionArea, manualResizeRedaction.getPositions())) {
+                        var surroundingText = findSurroundingText(sectionText, manualResizeRedaction.getValue(), manualResizeRedaction
+                                .getPositions());
+                        manualResizeRedaction.setTextBefore(surroundingText.getLeft());
+                        manualResizeRedaction.setTextAfter(surroundingText.getRight());
+                        processedResizeRedactions.add(manualResizeRedaction);
+                        resizeItty.remove();
+                    }
+                }
+            }
+        }
+
+        manualRedactions.getEntriesToAdd().addAll(processedAddRedactions);
+        manualRedactions.getResizeRedactions().addAll(processedResizeRedactions);
+        return manualRedactions;
+    }
+
+
+    private Pair<String, String> findSurroundingText(SectionText sectionText, String value,
+                                                     List<Rectangle> toFindPositions) {
+
+        Set<Entity> entities = EntitySearchUtils.find(sectionText.getText(), Set.of(value), "dummy", sectionText.getHeadline(), sectionText
+                .getSectionNumber(), false, false, Engine.DICTIONARY);
+        Set<Entity> entitiesWithPositions = EntitySearchUtils.clearAndFindPositions(entities, sectionText.getSearchableText(), null);
+
+        Entity correctEntity = getEntityOnCorrectPosition(entitiesWithPositions, toFindPositions);
+
+        if (sectionText.getCellStarts() != null && !sectionText.getCellStarts().isEmpty()) {
+            surroundingWordsService.addSurroundingText(Set.of(correctEntity), sectionText.getSearchableText(), null, sectionText
+                    .getCellStarts());
+        } else {
+            surroundingWordsService.addSurroundingText(Set.of(correctEntity), sectionText.getSearchableText(), null);
+        }
+
+        return Pair.of(correctEntity.getTextBefore(), correctEntity.getTextAfter());
+    }
+
+
+    private boolean sectionContainsEntry(SectionArea sectionArea, List<Rectangle> positions) {
+
+        for (Rectangle position : positions) {
+            if (sectionArea.contains(position)) {
+                return true;
+            }
+        }
+        return false;
+    }
+
+
+    private Entity getEntityOnCorrectPosition(Set<Entity> entitiesWithPositions, List<Rectangle> toFindPositions) {
+
+        for (Entity entityWithPos : entitiesWithPositions) {
+            for (EntityPositionSequence entityPositionSequence : entityWithPos.getPositionSequences()) {
+                for (TextPositionSequence textPositionSequence : entityPositionSequence.getSequences()) {
+                    for (Rectangle manualRedactionRectangle : toFindPositions) {
+                        if (intersects(manualRedactionRectangle, textPositionSequence.getRectangle())) {
+                            return entityWithPos;
+                        }
+                    }
+                }
+            }
+        }
+
+        return null;
+    }
+
+
+    public boolean intersects(Rectangle manualPosition,
+                              com.iqser.red.service.redaction.v1.model.Rectangle textPositionRectangle) {
+
+        return textPositionRectangle.getTopLeft()
+                .getX() + textPositionRectangle.getWidth() > manualPosition.getTopLeftX() && textPositionRectangle.getTopLeft()
+                .getY() + textPositionRectangle.getHeight() > manualPosition.getTopLeftY() && textPositionRectangle.getTopLeft()
+                .getX() < manualPosition.getTopLeftX() + manualPosition.getWidth() && textPositionRectangle.getTopLeft()
+                .getY() < manualPosition.getTopLeftY() + manualPosition.getHeight();
+    }
+
+}
@@ -1,5 +1,15 @@
 package com.iqser.red.service.redaction.v1.server.redaction.service;

+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import org.apache.commons.collections4.CollectionUtils;
+import org.springframework.stereotype.Service;
+
 import com.iqser.red.service.redaction.v1.model.Point;
 import com.iqser.red.service.redaction.v1.model.Rectangle;
 import com.iqser.red.service.redaction.v1.model.RedactionLogEntry;
@@ -10,21 +20,20 @@ import com.iqser.red.service.redaction.v1.server.redaction.model.EntityPositionS
 import com.iqser.red.service.redaction.v1.server.redaction.model.Image;
 import com.iqser.red.service.redaction.v1.server.redaction.model.PageEntities;
 import com.iqser.red.service.redaction.v1.server.redaction.utils.IdBuilder;
-import lombok.RequiredArgsConstructor;
-import org.apache.commons.collections4.CollectionUtils;
-import org.springframework.stereotype.Service;

-import java.util.*;
-import java.util.stream.Collectors;
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;

@Service
+@Slf4j
@RequiredArgsConstructor
 public class RedactionLogCreatorService {

    private final DictionaryService dictionaryService;


-    public List<RedactionLogEntry> createRedactionLog(PageEntities pageEntities, int numberOfPages, String dossierTemplateId) {
+    public List<RedactionLogEntry> createRedactionLog(PageEntities pageEntities, int numberOfPages,
+                                                      String dossierTemplateId) {

        List<RedactionLogEntry> entries = new ArrayList<>();

@@ -129,16 +138,27 @@ public class RedactionLogCreatorService {
        if (textPositions.size() == 1) {
            rectangles.add(TextPositionSequence.fromData(textPositions, page).getRectangle());
        } else {
+            float x = textPositions.get(0).getXDirAdj();
            float y = textPositions.get(0).getYDirAdj();
+            float width = textPositions.get(0).getWidth();
+            float height = textPositions.get(0).getHeightDir();
            int startIndex = 0;
+
            for (int i = 1; i < textPositions.size(); i++) {
+                float xDirAdj = textPositions.get(i).getXDirAdj();
                float yDirAdj = textPositions.get(i).getYDirAdj();
-                if (round(yDirAdj,3) != round(y, 3)) {
+                float widthDir = textPositions.get(i).getWidth();
+                float heightDir = textPositions.get(i).getHeightDir();
+
+                if (!(isCharInSameLine(y, yDirAdj, height, heightDir) && isCharClose(x, xDirAdj, width))) {
                    rectangles.add(TextPositionSequence.fromData(textPositions.subList(startIndex, i), page)
                            .getRectangle());
                    y = yDirAdj;
+                    width = widthDir;
+                    height = heightDir;
                    startIndex = i;
                }
+                x = xDirAdj;
            }
            if (startIndex != textPositions.size()) {
                rectangles.add(TextPositionSequence.fromData(textPositions.subList(startIndex, textPositions.size()), page)
@@ -149,9 +169,32 @@ public class RedactionLogCreatorService {
        return rectangles;
    }

-    private double round(float value, int decimalPoints) {
-        var d = Math.pow(10, decimalPoints);
-        return Math.round(value * d) / d;
+
+    private boolean isCharClose(float x, float xDirAdj, float width) {
+
+        float max = x + (5 * width);
+        if (xDirAdj < max) {
+            return true;
+        }
+        return false;
+    }
+
+
+    private boolean isCharInSameLine(float y, float yCompare, float height, float heightCompare) {
+
+        float offsetHeight = height / 2;
+        float minHeight = height - offsetHeight;
+        float maxHeight = height + offsetHeight;
+
+        float offsetY = height / 10;
+        float minY = y - offsetY;
+        float maxY = y + offsetY;
+
+        if (yCompare > minY && yCompare < maxY && heightCompare > minHeight && heightCompare < maxHeight) {
+            return true;
+        }
+
+        return false;
    }


@@ -204,5 +247,4 @@ public class RedactionLogCreatorService {
        return dictionaryService.isRecommendation(type, dossierTemplateId);
    }

-
 }
@@ -1,17 +1,36 @@
 package com.iqser.red.service.redaction.v1.server.redaction.service;

-import com.iqser.red.service.persistence.service.v1.api.model.annotations.*;
+import java.time.OffsetDateTime;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import org.springframework.stereotype.Service;
+
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.AnnotationStatus;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.Comment;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.IdRemoval;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualForceRedaction;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualImageRecategorization;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualLegalBasisChange;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualRedactionEntry;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualRedactions;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualResizeRedaction;
+import com.iqser.red.service.redaction.v1.model.ManualRedactionType;
+import com.iqser.red.service.redaction.v1.model.Point;
 import com.iqser.red.service.redaction.v1.model.Rectangle;
-import com.iqser.red.service.redaction.v1.model.*;
+import com.iqser.red.service.redaction.v1.model.RedactionLog;
+import com.iqser.red.service.redaction.v1.model.RedactionLogEntry;
+import com.iqser.red.service.redaction.v1.model.SectionGrid;
+
 import lombok.AllArgsConstructor;
 import lombok.Data;
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
-import org.springframework.stereotype.Service;
-
-import java.time.OffsetDateTime;
-import java.util.*;
-import java.util.stream.Collectors;

@Slf4j
@Service
@@ -23,8 +42,9 @@ public class RedactionLogMergeService {
    private final SectionTextService sectionTextService;


-    public RedactionLog mergeRedactionLogData(RedactionLog redactionLog, SectionGrid sectionGrid, String dossierTemplateId,
-                                              ManualRedactions manualRedactions, Set<Integer> excludedPages) {
+    public RedactionLog mergeRedactionLogData(RedactionLog redactionLog, SectionGrid sectionGrid,
+                                              String dossierTemplateId, ManualRedactions manualRedactions,
+                                              Set<Integer> excludedPages) {

        log.info("Merging Redaction log with manual redactions");
        if (manualRedactions != null) {
@@ -54,6 +74,15 @@ public class RedactionLogMergeService {

        }

+        Set<String> processedIds = new HashSet<>();
+        redactionLog.getRedactionLogEntry().removeIf(entry -> {
+            if (processedIds.contains(entry.getId())) {
+                log.info("Duplicate annotation found with id {}", entry.getId());
+                return true;
+            }
+            processedIds.add(entry.getId());
+            return false;
+        });
        return redactionLog;
    }

@@ -111,12 +140,19 @@ public class RedactionLogMergeService {
                    redactionLogEntry.setType(imageRecategorization.getType());
                    redactionLogEntry.setHasBeenRecategorized(true);
                    redactionLogEntry.setSection("Image:" + redactionLogEntry.getType());
+
+                    if (dictionaryService.isHint(imageRecategorization.getType(), dossierTemplateId)) {
+                        redactionLogEntry.setRedacted(false);
+                        redactionLogEntry.setHint(true);
+                    } else {
+                        redactionLogEntry.setHint(false);
+                    }
+
                    manualOverrideReason = mergeReasonIfNecessary(redactionLogEntry.getReason(), ", recategorized by manual override");
                } else if (imageRecategorization.getStatus().equals(AnnotationStatus.REQUESTED)) {
                    manualOverrideReason = mergeReasonIfNecessary(redactionLogEntry.getReason(), ", requested to recategorize");
                    redactionLogEntry.setStatus(AnnotationStatus.REQUESTED);
-                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, false, redactionLogEntry
-                            .isRedacted(), false));
+                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, false, redactionLogEntry.isRedacted(), false));
                    redactionLogEntry.setRecategorizationType(imageRecategorization.getType());
                } else {
                    redactionLogEntry.setStatus(AnnotationStatus.DECLINED);
@@ -135,13 +171,12 @@ public class RedactionLogMergeService {
                    redactionLogEntry.setRedacted(false);
                    redactionLogEntry.setStatus(AnnotationStatus.APPROVED);
                    manualOverrideReason = mergeReasonIfNecessary(redactionLogEntry.getReason(), ", removed by manual override");
-                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, false, redactionLogEntry
-                            .isRedacted(), true));
+                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, false, redactionLogEntry.isRedacted(), true));
+                    redactionLogEntry.setHasBeenRemovedByManualOverride(true);
                } else if (manualRemoval.getStatus().equals(AnnotationStatus.REQUESTED)) {
                    manualOverrideReason = mergeReasonIfNecessary(redactionLogEntry.getReason(), ", requested to remove");
                    redactionLogEntry.setStatus(AnnotationStatus.REQUESTED);
-                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, true, redactionLogEntry
-                            .isRedacted(), false));
+                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, true, redactionLogEntry.isRedacted(), false));
                } else {
                    redactionLogEntry.setStatus(AnnotationStatus.DECLINED);
                }
@@ -160,15 +195,14 @@ public class RedactionLogMergeService {
                if (manualForceRedact.getStatus().equals(AnnotationStatus.APPROVED)) {
                    redactionLogEntry.setRedacted(true);
                    redactionLogEntry.setStatus(AnnotationStatus.APPROVED);
-                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, false, redactionLogEntry
-                            .isRedacted(), false));
+                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, false, redactionLogEntry.isRedacted(), false));
                    manualOverrideReason = mergeReasonIfNecessary(redactionLogEntry.getReason(), ", forced by manual override");
+                    redactionLogEntry.setHasBeenForced(true);
                    redactionLogEntry.setLegalBasis(manualForceRedact.getLegalBasis());
                } else if (manualForceRedact.getStatus().equals(AnnotationStatus.REQUESTED)) {
                    manualOverrideReason = mergeReasonIfNecessary(redactionLogEntry.getReason(), ", requested to force redact");
                    redactionLogEntry.setStatus(AnnotationStatus.REQUESTED);
-                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, true, redactionLogEntry
-                            .isRedacted(), false));
+                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, true, redactionLogEntry.isRedacted(), false));
                    redactionLogEntry.setLegalBasis(manualForceRedact.getLegalBasis());
                } else {
                    redactionLogEntry.setStatus(AnnotationStatus.DECLINED);
@@ -189,14 +223,17 @@ public class RedactionLogMergeService {
                    manualOverrideReason = mergeReasonIfNecessary(redactionLogEntry.getReason(), ", legal basis was manually changed");
                    redactionLogEntry.setLegalBasis(manualLegalBasisChange.getLegalBasis());
                    redactionLogEntry.setRedacted(true);
+                    redactionLogEntry.setHasLegalBasisChanged(true);
                    if (manualLegalBasisChange.getSection() != null) {
                        redactionLogEntry.setSection(manualLegalBasisChange.getSection());
                    }
+                    if (redactionLogEntry.isRectangle() && manualLegalBasisChange.getValue() != null) {
+                        redactionLogEntry.setValue(manualLegalBasisChange.getValue());
+                    }
                } else if (manualLegalBasisChange.getStatus().equals(AnnotationStatus.REQUESTED)) {
                    manualOverrideReason = mergeReasonIfNecessary(redactionLogEntry.getReason(), ", legal basis change requested");
                    redactionLogEntry.setStatus(AnnotationStatus.REQUESTED);
-                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, true, redactionLogEntry
-                            .isRedacted(), false));
+                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, true, redactionLogEntry.isRedacted(), false));
                    redactionLogEntry.setLegalBasisChangeValue(manualLegalBasisChange.getLegalBasis());
                } else {
                    redactionLogEntry.setStatus(AnnotationStatus.DECLINED);
@@ -213,18 +250,20 @@ public class RedactionLogMergeService {
                String manualOverrideReason = null;
                if (manualResizeRedact.getStatus().equals(AnnotationStatus.APPROVED)) {
                    redactionLogEntry.setStatus(AnnotationStatus.APPROVED);
-                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, false, redactionLogEntry
-                            .isRedacted(), false));
+                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, false, redactionLogEntry.isRedacted(), false));
                    redactionLogEntry.setPositions(convertPositions(manualResizeRedact.getPositions()));
                    redactionLogEntry.setValue(manualResizeRedact.getValue());
                    redactionLogEntry.setHasBeenResized(true);
+                    redactionLogEntry.setTextBefore(manualResizeRedact.getTextBefore());
+                    redactionLogEntry.setTextAfter(manualResizeRedact.getTextAfter());
                    manualOverrideReason = mergeReasonIfNecessary(redactionLogEntry.getReason(), ", resized by manual override");
                } else if (manualResizeRedact.getStatus().equals(AnnotationStatus.REQUESTED)) {
                    manualOverrideReason = mergeReasonIfNecessary(redactionLogEntry.getReason(), ", requested to resize redact");
                    redactionLogEntry.setStatus(AnnotationStatus.REQUESTED);
-                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, true, redactionLogEntry
-                            .isRedacted(), false));
+                    redactionLogEntry.setColor(getColor(redactionLogEntry.getType(), dossierTemplateId, true, redactionLogEntry.isRedacted(), false));
                    redactionLogEntry.setPositions(convertPositions(manualResizeRedact.getPositions()));
+                    redactionLogEntry.setTextBefore(manualResizeRedact.getTextBefore());
+                    redactionLogEntry.setTextAfter(manualResizeRedact.getTextAfter());
                } else {
                    redactionLogEntry.setStatus(AnnotationStatus.DECLINED);
                }
@@ -265,6 +304,8 @@ public class RedactionLogMergeService {
                RedactionLogEntry redactionLogEntry = createRedactionLogEntry(manualRedactionEntry, manualRedactionEntry.getAnnotationId(), dossierTemplateId);
                redactionLogEntry.setPositions(convertPositions(manualRedactionEntry.getPositions()));
                redactionLogEntry.setComments(comments.get(manualRedactionEntry.getAnnotationId()));
+                redactionLogEntry.setTextBefore(manualRedactionEntry.getTextBefore());
+                redactionLogEntry.setTextAfter(manualRedactionEntry.getTextAfter());

                sectionTextService.handleSectionText(sectionGrid, redactionLogEntry);

@@ -275,9 +316,13 @@ public class RedactionLogMergeService {
        return redactionLogEntries;
    }

-    private List<Rectangle> convertPositions(List<com.iqser.red.service.persistence.service.v1.api.model.annotations.Rectangle> positions) {
-        return positions.stream().map(pos -> new Rectangle(new Point(pos.getTopLeftX(), pos.getTopLeftY()), pos.getWidth(), pos
-                .getHeight(), pos.getPage())).collect(Collectors.toList());
+
+    private List<Rectangle> convertPositions(
+            List<com.iqser.red.service.persistence.service.v1.api.model.annotations.Rectangle> positions) {
+
+        return positions.stream()
+                .map(pos -> new Rectangle(new Point(pos.getTopLeftX(), pos.getTopLeftY()), pos.getWidth(), pos.getHeight(), pos.getPage()))
+                .collect(Collectors.toList());
    }


@@ -308,6 +353,7 @@ public class RedactionLogMergeService {
                .status(manualRedactionEntry.getStatus())
                .manualRedactionType(ManualRedactionType.ADD)
                .manualRedactionUserId(manualRedactionEntry.getUser())
+                .rectangle(manualRedactionEntry.isRectangle())
                .build();
    }

@@ -359,6 +405,5 @@ public class RedactionLogMergeService {

    }

-
 }

@@ -28,7 +28,7 @@ public class SurroundingWordsService {
        try {
            for (Entity entity : entities) {

-                if (dictionary.isHint(entity.getType())) {
+                if (dictionary != null && dictionary.isHint(entity.getType())) {
                    continue;
                }
                findSurroundingWords(entity, searchableText.toString(), entity.getStart(), entity.getEnd());
@@ -64,7 +64,7 @@ public class SurroundingWordsService {
                    String text = searchableString.substring(startOffset, endOffset);
                    for (Entity entity : entities) {

-                        if (dictionary.isHint(entity.getType())) {
+                        if (dictionary != null && dictionary.isHint(entity.getType())) {
                            continue;
                        }

@@ -1,5 +1,17 @@
 package com.iqser.red.service.redaction.v1.server.redaction.utils;

+import java.util.ArrayList;
+import java.util.Comparator;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Locale;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Set;
+import java.util.regex.Pattern;
+import java.util.stream.Collectors;
+
 import com.iqser.red.service.redaction.v1.model.Engine;
 import com.iqser.red.service.redaction.v1.server.redaction.model.Dictionary;
 import com.iqser.red.service.redaction.v1.server.redaction.model.DictionaryIncrementValue;
@@ -10,10 +22,6 @@ import com.iqser.red.service.redaction.v1.server.redaction.model.SearchableText;
 import lombok.experimental.UtilityClass;
 import lombok.extern.slf4j.Slf4j;

-import java.util.*;
-import java.util.regex.Pattern;
-import java.util.stream.Collectors;
-
@Slf4j
@UtilityClass
@SuppressWarnings("PMD")
@@ -37,8 +45,7 @@ public class EntitySearchUtils {
                startIndex = inputString.indexOf(cleanValue, stopIndex);
                stopIndex = startIndex + cleanValue.length();

-                if (startIndex > -1 && (startIndex == 0 || Character.isWhitespace(inputString.charAt(startIndex - 1)) || isSeparator(inputString
-                        .charAt(startIndex - 1))) && (stopIndex == inputString.length() || isSeparator(inputString.charAt(stopIndex)))) {
+                if (startIndex > -1 && (startIndex == 0 || Character.isWhitespace(inputString.charAt(startIndex - 1)) || isSeparator(inputString.charAt(startIndex - 1))) && (stopIndex == inputString.length() || isSeparator(inputString.charAt(stopIndex)))) {
                    return true;
                }
            } while (startIndex > -1);
@@ -66,8 +73,7 @@ public class EntitySearchUtils {
                startIndex = inputString.indexOf(cleanValue, stopIndex);
                stopIndex = startIndex + cleanValue.length();

-                if (startIndex > -1 && (startIndex == 0 || Character.isWhitespace(inputString.charAt(startIndex - 1)) || isSeparator(inputString
-                        .charAt(startIndex - 1))) && (stopIndex == inputString.length() || isSeparator(inputString.charAt(stopIndex)))) {
+                if (startIndex > -1 && (startIndex == 0 || Character.isWhitespace(inputString.charAt(startIndex - 1)) || isSeparator(inputString.charAt(startIndex - 1))) && (stopIndex == inputString.length() || isSeparator(inputString.charAt(stopIndex)))) {
                    found.add(new Entity(inputString.substring(startIndex, stopIndex), type, startIndex, stopIndex, headline, sectionNumber, isDictionaryEntry, isDossierDictionary, engine));
                }
            } while (startIndex > -1);
@@ -98,7 +104,7 @@ public class EntitySearchUtils {
                    .collect(Collectors.toList());
            Entity firstEntity = orderedEntities.get(0);
            List<EntityPositionSequence> positionSequences = text.getSequences(firstEntity.getWord()
-                    .trim(), dictionary.isCaseInsensitiveDictionary(firstEntity.getType()), firstEntity.getTargetSequences());
+                    .trim(), dictionary == null ? true : dictionary.isCaseInsensitiveDictionary(firstEntity.getType()), firstEntity.getTargetSequences());

            for (int i = 0; i <= orderedEntities.size() - 1; i++) {
                try {
@@ -121,8 +127,7 @@ public class EntitySearchUtils {
        for (Entity word : entities) {
            for (Entity inner : entities) {
                if (inner.getWord().length() < word.getWord()
-                        .length() && inner.getStart() >= word.getStart() && inner.getEnd() <= word.getEnd() && word != inner && word
-                        .getSectionNumber() == inner.getSectionNumber()) {
+                        .length() && inner.getStart() >= word.getStart() && inner.getEnd() <= word.getEnd() && word != inner && word.getSectionNumber() == inner.getSectionNumber()) {
                    wordsToRemove.add(inner);
                }
            }
@@ -141,14 +146,14 @@ public class EntitySearchUtils {

        if (entities.contains(found)) {
            Optional<Entity> existingOptional = entities.stream().filter(entity -> entity.equals(found)).findFirst();
-            if(!existingOptional.isPresent()){
+            if (!existingOptional.isPresent()) {
                return;
            }
            var existing = existingOptional.get();

-            if(existing.getType().equals(found.getType())){
+            if (existing.getType().equals(found.getType())) {
                existing.getEngines().addAll(found.getEngines());
-            } else if (dictionary.getDictionaryRank(existing.getType()) <= dictionary.getDictionaryRank(found.getType())){
+            } else if (dictionary.getDictionaryRank(existing.getType()) <= dictionary.getDictionaryRank(found.getType())) {
                entities.remove(found);
                entities.add(found);
            }
@@ -165,12 +170,14 @@ public class EntitySearchUtils {
    }


-    public void addOrAddEngine(Set<Entity> existing, Set<Entity> toBeAdded){
+    public void addOrAddEngine(Set<Entity> existing, Set<Entity> toBeAdded) {

-        for(Entity toAdd: toBeAdded){
+        for (Entity toAdd : toBeAdded) {
            if (existing.contains(toAdd)) {
-                Optional<Entity> existingOptional  = existing.stream().filter(entity -> entity.equals(toAdd)).findFirst();
-                if(!existingOptional.isPresent()){
+                Optional<Entity> existingOptional = existing.stream()
+                        .filter(entity -> entity.equals(toAdd))
+                        .findFirst();
+                if (!existingOptional.isPresent()) {
                    return;
                }
                var existingEntity = existingOptional.get();
@@ -181,4 +188,40 @@ public class EntitySearchUtils {
        }
    }

+
+    public Set<Entity> findNonOverlappingMatchEntities(Set<Entity> existingEntities, Set<Entity> foundEntities) {
+
+        Set<Entity> result = new HashSet<>();
+        if (existingEntities != null && foundEntities != null) {
+            for (Entity foundEntity : foundEntities) {
+
+                if (!overlaps(existingEntities, foundEntity)) {
+                    result.add(foundEntity);
+                }
+
+            }
+        }
+        return result;
+    }
+
+
+    private boolean overlaps(Set<Entity> existingEntities, Entity found) {
+
+        for (Entity existing : existingEntities) {
+
+            if(existing.getStart().equals(found.getStart())){
+                continue;
+            }
+
+            for (int i = existing.getStart(); i <= existing.getEnd(); i++) {
+                for (int j = found.getStart(); j <= found.getEnd(); j++) {
+                    if (i == j) {
+                        return true;
+                    }
+                }
+            }
+        }
+        return false;
+    }
+
 }
@@ -1,30 +1,27 @@
 package com.iqser.red.service.redaction.v1.server;

-import com.amazonaws.services.s3.AmazonS3;
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.iqser.red.service.persistence.service.v1.api.model.annotations.Rectangle;
-import com.iqser.red.service.persistence.service.v1.api.model.annotations.*;
-import com.iqser.red.service.persistence.service.v1.api.model.common.JSONPrimitive;
-import com.iqser.red.service.persistence.service.v1.api.model.dossiertemplate.configuration.Colors;
-import com.iqser.red.service.persistence.service.v1.api.model.dossiertemplate.dossier.file.FileType;
-import com.iqser.red.service.persistence.service.v1.api.model.dossiertemplate.type.DictionaryEntry;
-import com.iqser.red.service.persistence.service.v1.api.model.dossiertemplate.type.Type;
-import com.iqser.red.service.redaction.v1.model.*;
-import com.iqser.red.service.redaction.v1.server.classification.model.SectionText;
-import com.iqser.red.service.redaction.v1.server.client.DictionaryClient;
-import com.iqser.red.service.redaction.v1.server.client.ImageClassificationClient;
-import com.iqser.red.service.redaction.v1.server.client.LegalBasisClient;
-import com.iqser.red.service.redaction.v1.server.client.RulesClient;
-import com.iqser.red.service.redaction.v1.server.controller.RedactionController;
-import com.iqser.red.service.redaction.v1.server.memory.MemoryStats;
-import com.iqser.red.service.redaction.v1.server.redaction.service.AnalyzeService;
-import com.iqser.red.service.redaction.v1.server.redaction.utils.ResourceLoader;
-import com.iqser.red.service.redaction.v1.server.redaction.utils.TextNormalizationUtilities;
-import com.iqser.red.service.redaction.v1.server.storage.RedactionStorageService;
-import com.iqser.red.storage.commons.StorageAutoConfiguration;
-import com.iqser.red.storage.commons.service.StorageService;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.Mockito.when;

-import lombok.SneakyThrows;
+import java.io.BufferedReader;
+import java.io.ByteArrayInputStream;
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.net.URL;
+import java.nio.charset.StandardCharsets;
+import java.time.OffsetDateTime;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.stream.Collectors;

 import org.apache.commons.io.IOUtils;
 import org.apache.commons.lang3.StringUtils;
@@ -51,15 +48,48 @@ import org.springframework.context.annotation.Primary;
 import org.springframework.core.io.ClassPathResource;
 import org.springframework.test.context.junit4.SpringRunner;

-import java.io.*;
-import java.net.URL;
-import java.nio.charset.StandardCharsets;
-import java.time.OffsetDateTime;
-import java.util.*;
-import java.util.stream.Collectors;
+import com.amazonaws.services.s3.AmazonS3;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.AnnotationStatus;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.Comment;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.IdRemoval;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualForceRedaction;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualImageRecategorization;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualLegalBasisChange;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualRedactionEntry;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualRedactions;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.ManualResizeRedaction;
+import com.iqser.red.service.persistence.service.v1.api.model.annotations.Rectangle;
+import com.iqser.red.service.persistence.service.v1.api.model.common.JSONPrimitive;
+import com.iqser.red.service.persistence.service.v1.api.model.dossiertemplate.configuration.Colors;
+import com.iqser.red.service.persistence.service.v1.api.model.dossiertemplate.dossier.file.FileType;
+import com.iqser.red.service.persistence.service.v1.api.model.dossiertemplate.type.DictionaryEntry;
+import com.iqser.red.service.persistence.service.v1.api.model.dossiertemplate.type.Type;
+import com.iqser.red.service.redaction.v1.model.AnalyzeRequest;
+import com.iqser.red.service.redaction.v1.model.AnalyzeResult;
+import com.iqser.red.service.redaction.v1.model.AnnotateRequest;
+import com.iqser.red.service.redaction.v1.model.AnnotateResponse;
+import com.iqser.red.service.redaction.v1.model.FileAttribute;
+import com.iqser.red.service.redaction.v1.model.RedactionLogEntry;
+import com.iqser.red.service.redaction.v1.model.RedactionRequest;
+import com.iqser.red.service.redaction.v1.model.RedactionResult;
+import com.iqser.red.service.redaction.v1.model.StructureAnalyzeRequest;
+import com.iqser.red.service.redaction.v1.server.classification.model.SectionText;
+import com.iqser.red.service.redaction.v1.server.client.DictionaryClient;
+import com.iqser.red.service.redaction.v1.server.client.ImageClassificationClient;
+import com.iqser.red.service.redaction.v1.server.client.LegalBasisClient;
+import com.iqser.red.service.redaction.v1.server.client.RulesClient;
+import com.iqser.red.service.redaction.v1.server.controller.RedactionController;
+import com.iqser.red.service.redaction.v1.server.memory.MemoryStats;
+import com.iqser.red.service.redaction.v1.server.redaction.service.AnalyzeService;
+import com.iqser.red.service.redaction.v1.server.redaction.service.ManualRedactionSurroundingTextService;
+import com.iqser.red.service.redaction.v1.server.redaction.utils.ResourceLoader;
+import com.iqser.red.service.redaction.v1.server.redaction.utils.TextNormalizationUtilities;
+import com.iqser.red.service.redaction.v1.server.storage.RedactionStorageService;
+import com.iqser.red.storage.commons.StorageAutoConfiguration;
+import com.iqser.red.storage.commons.service.StorageService;

-import static org.assertj.core.api.Assertions.assertThat;
-import static org.mockito.Mockito.when;
+import lombok.SneakyThrows;

@RunWith(SpringRunner.class)
@SpringBootTest(classes = Application.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
@@ -116,6 +146,9 @@ public class RedactionIntegrationTest {
    @Autowired
    private StorageService storageService;

+    @Autowired
+    private ManualRedactionSurroundingTextService manualRedactionSurroundingTextService;
+
    @MockBean
    private AmazonS3 amazonS3;

@@ -578,6 +611,23 @@ public class RedactionIntegrationTest {
    }


+    @Test
+    public void redactionExpansionOverlap() throws IOException {
+
+        ClassPathResource pdfFileResource = new ClassPathResource("files/Minimal Examples/ExpansionTest.pdf");
+        AnalyzeRequest request = prepareStorage(pdfFileResource.getInputStream());
+
+        analyzeService.analyzeDocumentStructure(new StructureAnalyzeRequest(request.getDossierId(), request.getFileId()));
+        AnalyzeResult result = analyzeService.analyze(request);
+
+        var redactionLog = redactionStorageService.getRedactionLog(TEST_DOSSIER_ID, TEST_FILE_ID);
+
+        var values = redactionLog.getRedactionLogEntry().stream().map(RedactionLogEntry::getValue).collect(Collectors.toList());
+
+        assertThat(values).containsExactlyInAnyOrder("Lastname M.", "Doe", "Doe J.", "M. Mustermann", "Mustermann M.", "F. Lastname");
+    }
+
+
    @Test
    @Ignore
    public void noExceptionShouldBeThrownForAnyFiles() throws IOException {
@@ -631,29 +681,14 @@ public class RedactionIntegrationTest {
    }


-    private List<File> getPathsRecursively(File path) {
-
-        List<File> result = new ArrayList<>();
-        if (path == null || path.listFiles() == null) {
-            return result;
-        }
-        for (File f : path.listFiles()) {
-            if (f.isFile()) {
-                result.add(f);
-            } else {
-                result.addAll(getPathsRecursively(f));
-            }
-        }
-        return result;
-
-    }
-
-
    @Test
-    public void redactionTest() throws IOException {
+    public void redactionTestSeparatedRedaction() throws IOException {
+
+        String fileName = "scanned/VV-380943_page38.pdf";
+        String outputFileName = getTemporaryDirectory() + "/AnnotatedRedactionTestSeparatedRedaction.pdf";

        long start = System.currentTimeMillis();
-        ClassPathResource pdfFileResource = new ClassPathResource("files/new/VV-919901.pdf");
+        ClassPathResource pdfFileResource = new ClassPathResource(fileName);
        AnalyzeRequest request = prepareStorage(pdfFileResource.getInputStream());
        request.setExcludedPages(Set.of(1));

@@ -744,7 +779,124 @@ public class RedactionIntegrationTest {
                .fileId(TEST_FILE_ID)
                .build());

-        try (FileOutputStream fileOutputStream = new FileOutputStream(getTemporaryDirectory() + "/Annotated.pdf")) {
+        try (FileOutputStream fileOutputStream = new FileOutputStream(outputFileName)) {
+            fileOutputStream.write(annotateResponse.getDocument());
+        }
+
+        deleted.remove("mouse");
+        reanlysisVersions.put("mouse", 4L);
+
+        when(dictionaryClient.getVersion(TEST_DOSSIER_TEMPLATE_ID)).thenReturn(4L);
+
+        when(dictionaryClient.getDictionaryForType(VERTEBRATE)).thenReturn(getDictionaryResponse(VERTEBRATE, false));
+
+        analyzeService.reanalyze(request);
+
+        redactionLog = redactionStorageService.getRedactionLog(TEST_DOSSIER_ID, TEST_FILE_ID);
+
+        System.out.println("hi");
+    }
+
+
+    @Test
+    public void redactionTest() throws IOException {
+
+        String fileName = "files/new/VV-919901.pdf";
+        String outputFileName = getTemporaryDirectory() + "/Annotated.pdf";
+
+        long start = System.currentTimeMillis();
+        ClassPathResource pdfFileResource = new ClassPathResource(fileName);
+        AnalyzeRequest request = prepareStorage(pdfFileResource.getInputStream());
+        request.setExcludedPages(Set.of(1));
+
+        request.setFileAttributes(List.of(FileAttribute.builder()
+                .id("fileAttributeId")
+                .label("Vertebrate Study")
+                .placeholder("{fileattributes.vertebrateStudy}")
+                .value("true")
+                .build()));
+
+        analyzeService.analyzeDocumentStructure(new StructureAnalyzeRequest(request.getDossierId(), request.getFileId()));
+        AnalyzeResult result = analyzeService.analyze(request);
+
+        var redactionLog = redactionStorageService.getRedactionLog(TEST_DOSSIER_ID, TEST_FILE_ID);
+        var text = redactionStorageService.getText(TEST_DOSSIER_ID, TEST_FILE_ID);
+
+        long end = System.currentTimeMillis();
+
+        System.out.println("first analysis duration: " + (end - start));
+
+        try (FileOutputStream fileOutputStream = new FileOutputStream(getTemporaryDirectory() + "/Test.json")) {
+            fileOutputStream.write(objectMapper.writeValueAsBytes(redactionStorageService.getText(TEST_DOSSIER_ID, TEST_FILE_ID)));
+        }
+
+        int correctFound = 0;
+        loop:
+        for (RedactionLogEntry redactionLogEntry : redactionLog.getRedactionLogEntry()) {
+            for (SectionText sectionText : text.getSectionTexts()) {
+                if (redactionLogEntry.isImage()) {
+                    correctFound++;
+                    continue loop;
+                }
+                if (redactionLogEntry.getSectionNumber() == sectionText.getSectionNumber()) {
+                    String value = sectionText.getText()
+                            .substring(redactionLogEntry.getStartOffset(), redactionLogEntry.getEndOffset());
+                    if (redactionLogEntry.getValue().equalsIgnoreCase(value)) {
+                        correctFound++;
+                    } else {
+                        throw new RuntimeException("WTF");
+                    }
+                }
+            }
+        }
+        assertThat(correctFound).isEqualTo(redactionLog.getRedactionLogEntry().size());
+
+        dictionary.get(AUTHOR).add("properties");
+        reanlysisVersions.put("properties", 1L);
+
+        dictionary.get(AUTHOR).add("physical");
+        reanlysisVersions.put("physical", 2L);
+
+        deleted.add("David Chubb");
+        deleted.add("mouse");
+
+        dictionary.get(FALSE_POSITIVE).add("David Chubb");
+        reanlysisVersions.put("David Chubb", 3L);
+
+        reanlysisVersions.put("mouse", 3L);
+
+        when(dictionaryClient.getVersion(TEST_DOSSIER_TEMPLATE_ID)).thenReturn(3L);
+
+        when(dictionaryClient.getDictionaryForType(VERTEBRATE)).thenReturn(getDictionaryResponse(VERTEBRATE, false));
+
+        when(dictionaryClient.getDictionaryForType(FALSE_POSITIVE)).thenReturn(getDictionaryResponse(FALSE_POSITIVE, false));
+
+        start = System.currentTimeMillis();
+
+        ManualRedactions manualRedactions = new ManualRedactions();
+
+        manualRedactions.setImageRecategorization(Set.of(ManualImageRecategorization.builder()
+                .annotationId("37eee3e9d589a5cc529bfec38c3ba479")
+                .fileId("fileId")
+                .status(AnnotationStatus.APPROVED)
+                .type("signature")
+                .build()));
+
+        request.setManualRedactions(manualRedactions);
+
+        AnalyzeResult reanalyzeResult = analyzeService.reanalyze(request);
+
+        redactionLog = redactionStorageService.getRedactionLog(TEST_DOSSIER_ID, TEST_FILE_ID);
+
+        end = System.currentTimeMillis();
+        System.out.println("reanalysis analysis duration: " + (end - start));
+
+        AnnotateResponse annotateResponse = redactionController.annotate(AnnotateRequest.builder()
+                .dossierId(TEST_DOSSIER_ID)
+                .fileId(TEST_FILE_ID)
+                .build());
+
+        try (FileOutputStream fileOutputStream = new FileOutputStream(outputFileName)) {
            fileOutputStream.write(annotateResponse.getDocument());
        }

@@ -1173,6 +1325,110 @@ public class RedactionIntegrationTest {

    }

+    @Test
+    public void testExpandByRegEx() throws IOException {
+
+        System.out.println("expandByRegex");
+        long start = System.currentTimeMillis();
+
+        AnalyzeRequest request = prepareStorage("files/Metolachlor/S-Metolachlor_RAR_02_Volume_2_2018-09-06.pdf");
+        analyzeService.analyzeDocumentStructure(new StructureAnalyzeRequest(request.getDossierId(), request.getFileId()));
+        AnalyzeResult result = analyzeService.analyze(request);
+
+        AnnotateResponse annotateResponse = redactionController.annotate(AnnotateRequest.builder()
+                .dossierId(TEST_DOSSIER_ID)
+                .fileId(TEST_FILE_ID)
+                .build());
+
+        try (FileOutputStream fileOutputStream = new FileOutputStream(getTemporaryDirectory() + "/Annotated.pdf")) {
+            fileOutputStream.write(annotateResponse.getDocument());
+        }
+        long end = System.currentTimeMillis();
+
+        System.out.println("duration: " + (end - start));
+        System.out.println("numberOfPages: " + result.getNumberOfPages());
+    }
+
+
+    @Test
+    public void testManualSurroundingText() throws IOException {
+
+        ClassPathResource pdfFileResource = new ClassPathResource("files/new/S4.pdf");
+
+        ManualRedactions manualRedactions = new ManualRedactions();
+
+        ManualRedactionEntry manualRedactionEntry = new ManualRedactionEntry();
+        manualRedactionEntry.setAnnotationId(UUID.randomUUID().toString());
+        manualRedactionEntry.setFileId("fileId");
+        manualRedactionEntry.setStatus(AnnotationStatus.APPROVED);
+        manualRedactionEntry.setType("CBI_author");
+        manualRedactionEntry.setValue("rabbits");
+        manualRedactionEntry.setReason("Manual Redaction");
+        manualRedactionEntry.setPositions(List.of(Rectangle.builder()
+                .topLeftX(70.944f)
+                .topLeftY(670.1595f)
+                .width(30.07296f)
+                .height(10.048125f)
+                .page(1)
+                .build()));
+
+        ManualRedactionEntry manualRedactionEntry2 = new ManualRedactionEntry();
+        manualRedactionEntry2.setAnnotationId(UUID.randomUUID().toString());
+        manualRedactionEntry2.setFileId("fileId");
+        manualRedactionEntry2.setStatus(AnnotationStatus.APPROVED);
+        manualRedactionEntry2.setType("CBI_author");
+        manualRedactionEntry2.setValue("rabbits");
+        manualRedactionEntry2.setReason("Manual Redaction");
+        manualRedactionEntry2.setPositions(List.of(Rectangle.builder()
+                .topLeftX(470.5204f)
+                .topLeftY(746.1195f)
+                .width(29.96256f)
+                .height(10.048125f)
+                .page(1)
+                .build()));
+
+        ManualRedactionEntry manualRedactionEntry3 = new ManualRedactionEntry();
+        manualRedactionEntry3.setAnnotationId(UUID.randomUUID().toString());
+        manualRedactionEntry3.setFileId("fileId");
+        manualRedactionEntry3.setStatus(AnnotationStatus.APPROVED);
+        manualRedactionEntry3.setType("CBI_author");
+        manualRedactionEntry3.setValue("AOEL");
+        manualRedactionEntry3.setReason("Manual Redaction");
+        manualRedactionEntry3.setPositions(List.of(Rectangle.builder()
+                .topLeftX(355.53775f)
+                .topLeftY(266.1895f)
+                .width(29.32224f)
+                .height(10.048125f)
+                .page(1)
+                .build()));
+
+        manualRedactions.getEntriesToAdd().add(manualRedactionEntry);
+        manualRedactions.getEntriesToAdd().add(manualRedactionEntry2);
+        manualRedactions.getEntriesToAdd().add(manualRedactionEntry3);
+
+        AnalyzeRequest request = prepareStorage(pdfFileResource.getInputStream());
+        request.setManualRedactions(manualRedactions);
+        analyzeService.analyzeDocumentStructure(new StructureAnalyzeRequest(request.getDossierId(), request.getFileId()));
+        AnalyzeResult result = analyzeService.analyze(request);
+
+        AnnotateResponse annotateResponse = redactionController.annotate(AnnotateRequest.builder()
+                .dossierId(TEST_DOSSIER_ID)
+                .dossierTemplateId(TEST_DOSSIER_TEMPLATE_ID)
+                .fileId(TEST_FILE_ID)
+                .manualRedactions(manualRedactions)
+                .build());
+
+        try (FileOutputStream fileOutputStream = new FileOutputStream(getTemporaryDirectory() + "/Annotated.pdf")) {
+            fileOutputStream.write(annotateResponse.getDocument());
+        }
+
+        var surroundingTextResult = manualRedactionSurroundingTextService.addSurroundingText(TEST_DOSSIER_ID, TEST_FILE_ID, manualRedactions);
+        surroundingTextResult.getEntriesToAdd().forEach(addEntry -> {
+            assertThat(addEntry.getTextAfter()).isNotEmpty();
+        });
+
+    }
+

    private static String loadFromClassPath(String path) {

@@ -1193,6 +1449,24 @@ public class RedactionIntegrationTest {
    }


+    private List<File> getPathsRecursively(File path) {
+
+        List<File> result = new ArrayList<>();
+        if (path == null || path.listFiles() == null) {
+            return result;
+        }
+        for (File f : path.listFiles()) {
+            if (f.isFile()) {
+                result.add(f);
+            } else {
+                result.addAll(getPathsRecursively(f));
+            }
+        }
+        return result;
+
+    }
+
+
    private static String getTemporaryDirectory() {

        String tmpdir = System.getProperty("java.io.tmpdir");
@@ -1202,4 +1476,4 @@ public class RedactionIntegrationTest {
        return "/tmp";
    }

-}
+}
@@ -27,4 +27,162 @@ public class EntitySearchUtilsTest {

    }

+
+    /*
+     * Text:     Batman X. Superman Y.
+     * Position: 0123456789
+     *                     0123456789
+     *                               0123456789
+     */
+    @Test
+    public void testNotOverlappingEntitiesExpandedEnd() {
+
+        // Arrange
+        Set<Entity> existingEntities = new HashSet<>();
+        Entity existingEntity1 = new Entity("Batman", "fake type", 0, 5, "fake headline", 0, false, false, Engine.RULE);
+        Entity existingEntity2 = new Entity("Superman", "fake type", 10, 17, "fake headline", 0, false, false, Engine.RULE);
+        existingEntities.add(existingEntity1);
+        existingEntities.add(existingEntity2);
+
+        Set<Entity> foundEntities = new HashSet<>();
+        Entity foundEntities1 = new Entity("Batman X.", "fake type", 0, 8, "fake headline", 0, false, false, Engine.RULE);
+        Entity foundEntities2 = new Entity("Superman Y.", "fake type", 10, 20, "fake headline", 0, false, false, Engine.RULE);
+        foundEntities.add(foundEntities1);
+        foundEntities.add(foundEntities2);
+
+        // Act
+        Set<Entity> result = EntitySearchUtils.findNonOverlappingMatchEntities(existingEntities, foundEntities);
+
+        // Assert
+        assertThat(result.size()).isEqualTo(2);
+        assertThat(result).contains(foundEntities1);
+        assertThat(result).contains(foundEntities2);
+
+    }
+
+
+    /*
+     * Text:     Batman X. Superman Y.
+     * Position: 0123456789
+     *                     0123456789
+     *                               0123456789
+     */
+    @Test
+    public void testNotOverlappingEntitiesExpandedStartAndEndOverlapping() {
+
+        // Arrange
+        Set<Entity> existingEntities = new HashSet<>();
+        Entity existingEntity1 = new Entity("Batman X.", "fake type", 0, 8, "fake headline", 0, false, false, Engine.RULE);
+        Entity existingEntity2 = new Entity("Superman", "fake type", 10, 17, "fake headline", 0, false, false, Engine.RULE);
+        existingEntities.add(existingEntity1);
+        existingEntities.add(existingEntity2);
+
+        Set<Entity> foundEntities = new HashSet<>();
+        Entity foundEntities1 = new Entity("Batman X.", "fake type", 0, 8, "fake headline", 0, false, false, Engine.RULE);
+        Entity foundEntities2 = new Entity("X. Superman Y.", "fake type", 7, 20, "fake headline", 0, false, false, Engine.RULE);
+        foundEntities.add(foundEntities1);
+        foundEntities.add(foundEntities2);
+
+        // Act
+        Set<Entity> result = EntitySearchUtils.findNonOverlappingMatchEntities(existingEntities, foundEntities);
+
+        // Assert
+        assertThat(result.size()).isEqualTo(1);
+        assertThat(result).contains(foundEntities1);
+
+    }
+
+
+    /*
+     * Text:     Batman X. Superman Y.
+     * Position: 0123456789
+     *                     0123456789
+     *                               0123456789
+     */
+    @Test
+    public void testNotOverlappingEntitiesExpandedStartAndEnd() {
+
+        // Arrange
+        Set<Entity> existingEntities = new HashSet<>();
+        Entity existingEntity1 = new Entity("Batman X.", "fake type", 0, 8, "fake headline", 0, false, false, Engine.RULE);
+        Entity existingEntity2 = new Entity("Superman", "fake type", 10, 17, "fake headline", 0, false, false, Engine.RULE);
+        existingEntities.add(existingEntity1);
+        existingEntities.add(existingEntity2);
+
+        Set<Entity> foundEntities = new HashSet<>();
+        Entity foundEntities1 = new Entity("Batman X.", "fake type", 0, 8, "fake headline", 0, false, false, Engine.RULE);
+        Entity foundEntities2 = new Entity("X. Superman", "fake type", 7, 17, "fake headline", 0, false, false, Engine.RULE);
+        foundEntities.add(foundEntities1);
+        foundEntities.add(foundEntities2);
+
+        // Act
+        Set<Entity> result = EntitySearchUtils.findNonOverlappingMatchEntities(existingEntities, foundEntities);
+
+        // Assert
+        assertThat(result.size()).isEqualTo(1);
+        assertThat(result).contains(foundEntities1);
+
+    }
+
+
+    /*
+     * Text:     Batman X. Superman Y.
+     * Position: 0123456789
+     *                     0123456789
+     *                               0123456789
+     */
+    @Test
+    public void testNotOverlappingEntitiesExpandedExistingAndExpandedEnd() {
+
+        // Arrange
+        Set<Entity> existingEntities = new HashSet<>();
+        Entity existingEntity1 = new Entity("X. Superman", "fake type", 7, 17, "fake headline", 0, false, false, Engine.RULE);
+        Entity existingEntity2 = new Entity("Batman", "fake type", 0, 5, "fake headline", 0, false, false, Engine.RULE);
+        existingEntities.add(existingEntity1);
+        existingEntities.add(existingEntity2);
+
+        Set<Entity> foundEntities = new HashSet<>();
+        Entity foundEntities1 = new Entity("Batman X.", "fake type", 0, 8, "fake headline", 0, false, false, Engine.RULE);
+        Entity foundEntities2 = new Entity("Superman", "fake type", 10, 17, "fake headline", 0, false, false, Engine.RULE);
+        foundEntities.add(foundEntities1);
+        foundEntities.add(foundEntities2);
+
+        // Act
+        Set<Entity> result = EntitySearchUtils.findNonOverlappingMatchEntities(existingEntities, foundEntities);
+
+        // Assert
+        assertThat(result.size()).isEqualTo(0);
+
+    }
+
+    /*
+     * Text:     Batman X. Superman Y.
+     * Position: 0123456789
+     *                     0123456789
+     *                               0123456789
+     */
+    @Test
+    public void testNotOverlappingEntitiesExpandedEndLong() {
+
+        // Arrange
+        Set<Entity> existingEntities = new HashSet<>();
+        Entity existingEntity1 = new Entity("X. Superman", "fake type", 7, 17, "fake headline", 0, false, false, Engine.RULE);
+        Entity existingEntity2 = new Entity("Batman", "fake type", 0, 5, "fake headline", 0, false, false, Engine.RULE);
+        existingEntities.add(existingEntity1);
+        existingEntities.add(existingEntity2);
+
+        Set<Entity> foundEntities = new HashSet<>();
+        Entity foundEntities1 = new Entity("Batman X. Superman", "fake type", 0, 17, "fake headline", 0, false, false, Engine.RULE);
+        Entity foundEntities2 = new Entity("Superman", "fake type", 10, 17, "fake headline", 0, false, false, Engine.RULE);
+        foundEntities.add(foundEntities1);
+        foundEntities.add(foundEntities2);
+
+        // Act
+        Set<Entity> result = EntitySearchUtils.findNonOverlappingMatchEntities(existingEntities, foundEntities);
+
+        // Assert
+        assertThat(result.size()).isEqualTo(0);
+
+    }
+
 }
@@ -1,3 +1,8 @@
+A & L Laboratories, 3505 Conestoga Drive, Fort Wayne, IN 46806-4413, Indiana, USA
+Jealotts Hill Research Station, Bracknell
+Jealott s Hill Research Station, Bracknell
+Western Research Center, 120
+Fort Wayne, IN 46806-4413, Indiana
 Abandoned vineyard, Northern Italy
 ABC Analytical Bio-Chemistry Lab. Inc.
 ABC Analytical Bio-Chemistry Lab. Inc., Columbia, USA
@@ -1633,6 +1638,7 @@ XenoTech, LLC, 16825 West 116th Street, Lenexa, KS, USA
 Zeneca Ag Products
 Zeneca Ag Products, Richmond, USA
 Zeneca Agrochemicals
+ZENECA Agrochemicals
 Zeneca Agrochemicals, Fernhurst, United Kingdom
 Zeneca Agrochemicals, Jealott’s Hill Research Station, Bracknell, Berkshire, UK
 Zeneca Agrochemical s, Jealott’s Hill, United Kingdom
@@ -1,3 +1,33 @@
+Foo
+F. Bar
+B. Foo
+Johnson R |
+Weissler M S and Butters C A
+AD Hurt
+N Pengelly
+HA J Napper
+E M Roper
+Earl M
+Weissler M S
+Warrinton J S
+Kuet SF
+Hadeld ST
+Butters C A
+Hurt AD
+Campbell AJ
+Runnalls JK
+Tummon O J
+Chapman PF
+Snell RJ
+MclIndoe EC
+Johnson R I
+Richard Andrews
+James Paul
+Walter Richard Andrews
+Wilbur H. Palmer
+Jeff Mueller
+James McDonelI
+Jeffrey S. Heither
 1 Braid S.and Tsui G
 1 Schwader A.L.
 2 Lee MR
@@ -8585,4 +8615,9 @@ Zoriki Hosomi R.
 Zoriki Hosomi Rosana
 Zuberer D
 Zubrod J
-Zwicker R.E.
+Zwicker R.E.
+Doe
+M. Mustermann
+F. Lastname
+Mustermann
+Lastname
@@ -7,12 +7,20 @@ global Section section

 // --------------------------------------- CBI rules -------------------------------------------------------------------

+//rule "0: Expand CBI Authors with firstname initials"
+//    when
+//        Section(matchesType("CBI_author") || matchesType("recommendation_CBI_author"))
+//    then
+//        section.expandByRegEx("CBI_author", "(,? [A-Z]\\.?( ?[A-Z]\\.?)?( ?[A-Z]\\.?)?\\b\\.?)", false, 1);
+//        section.expandByRegEx("recommendation_CBI_author", "(,? [A-Z]\\.?( ?[A-Z]\\.?)?( ?[A-Z]\\.?)?\\b\\.?)", false, 1);
+//    end
+
 rule "0: Expand CBI Authors with firstname initials"
    when
        Section(matchesType("CBI_author") || matchesType("recommendation_CBI_author"))
    then
-        section.expandByRegEx("CBI_author", "(,? [A-Z]\\.?( ?[A-Z]\\.?)?( ?[A-Z]\\.?)?\\b\\.?)", false, 1);
-        section.expandByRegEx("recommendation_CBI_author", "(,? [A-Z]\\.?( ?[A-Z]\\.?)?( ?[A-Z]\\.?)?\\b\\.?)", false, 1);
+        section.expandByRegEx("CBI_author", "(,? [A-Z]\\.?( ?[A-Z]\\.?)?( ?[A-Z]\\.?)?\\b\\.?)", false, 1, "[^\\s]+");
+        section.expandByRegEx("recommendation_CBI_author", "(,? [A-Z]\\.?( ?[A-Z]\\.?)?( ?[A-Z]\\.?)?\\b\\.?)", false, 1, "[^\\s]+");
    end


@@ -7,12 +7,20 @@ global Section section

 // --------------------------------------- CBI rules -------------------------------------------------------------------

+//rule "0: Expand CBI Authors with firstname initials"
+//    when
+//        Section(matchesType("CBI_author") || matchesType("recommendation_CBI_author"))
+//    then
+//        section.expandByRegEx("CBI_author", "(,? [A-Z]\\.?( ?[A-Z]\\.?)?( ?[A-Z]\\.?)?\\b\\.?)", false, 1);
+//        section.expandByRegEx("recommendation_CBI_author", "(,? [A-Z]\\.?( ?[A-Z]\\.?)?( ?[A-Z]\\.?)?\\b\\.?)", false, 1);
+//    end
+
 rule "0: Expand CBI Authors with firstname initials"
    when
        Section(matchesType("CBI_author") || matchesType("recommendation_CBI_author"))
    then
-        section.expandByRegEx("CBI_author", "(,? [A-Z]\\.?( ?[A-Z]\\.?)?( ?[A-Z]\\.?)?\\b\\.?)", false, 1);
-        section.expandByRegEx("recommendation_CBI_author", "(,? [A-Z]\\.?( ?[A-Z]\\.?)?( ?[A-Z]\\.?)?\\b\\.?)", false, 1);
+        section.expandByRegEx("CBI_author", "(,? [A-Z]\\.?( ?[A-Z]\\.?)?( ?[A-Z]\\.?)?\\b\\.?)", false, 1, "[^\\s]+");
+        section.expandByRegEx("recommendation_CBI_author", "(,? [A-Z]\\.?( ?[A-Z]\\.?)?( ?[A-Z]\\.?)?\\b\\.?)", false, 1, "[^\\s]+");
    end


@@ -336,4 +344,11 @@ rule "29: Redact Dossier Redactions"
         Section(matchesType("dossier_redactions"))
     then
         section.redact("dossier_redactions", 29, "Dossier Redaction found", "Article 39(1)(2) of Regulation (EC) No 178/2002");
-     end
+     end
+
+rule "30: Ignore dossier_redactions if confidential"
+    when
+        Section(!fileAttributeByLabelEqualsIgnoreCase("Confidentiality","confidential") && matchesType("dossier_redactions"));
+    then
+        section.ignore("dossier_redactions");
+    end
Author	SHA1	Message	Date
Ali Oezyetimoglu	a155f18adc	Pull request #299 : RED-3061 rs3 Merge in RED/redaction-service from RED-3061-rs3 to master * commit '1ccf0ab493fcb367a071641e2fea050cf6ad26cf': RED-3061: Logic for value matcher for initials expansion rule is inverted RED-3061: Logic for value matcher for initials expansion rule is inverted	2021-12-14 12:35:45 +01:00
aoezyetimoglu	1ccf0ab493	RED-3061: Logic for value matcher for initials expansion rule is inverted	2021-12-14 12:25:21 +01:00
aoezyetimoglu	1b9251b0a2	RED-3061: Logic for value matcher for initials expansion rule is inverted	2021-12-14 11:10:59 +01:00
Dominique Eiflaender	6bfa54583f	Pull request #297 : RED-2439: Fixed missing MessageType in AnalyseResult Merge in RED/redaction-service from RED-2439-4 to master * commit '83a757976adf26cfeae8fb682593ce1d5f606dfc': RED-2439: Fixed missing MessageType in AnalyseResult	2021-12-13 13:55:52 +01:00
deiflaender	83a757976a	RED-2439: Fixed missing MessageType in AnalyseResult	2021-12-13 13:51:33 +01:00
Dominique Eiflaender	bd5c997572	Pull request #296 : RED-2439: Enabled to find surrounding text for manual redactions via queue Merge in RED/redaction-service from RED-2439-3 to master * commit 'e4cf3bfa602014cd8a2f2162199557880600e93f': RED-2439: Enabled to find surrounding text for manual redactions via queue	2021-12-13 12:32:20 +01:00
deiflaender	e4cf3bfa60	RED-2439: Enabled to find surrounding text for manual redactions via queue	2021-12-13 12:24:26 +01:00
Ali Oezyetimoglu	3f153c1df5	Pull request #294 : RED-3075: Upgraded log4j to 2.15.0 Merge in RED/redaction-service from RED-3075-rs2 to master * commit '142c81d27d9e5e67532b3d8795c2d4c559342d37': RED-3075: Upgraded log4j to 2.15.0	2021-12-13 11:03:56 +01:00
aoezyetimoglu	142c81d27d	RED-3075: Upgraded log4j to 2.15.0	2021-12-13 10:59:16 +01:00
Dominique Eiflaender	a2c57b94a2	Pull request #292 : RED-3059: Fixed inital expansion overlaps Merge in RED/redaction-service from RED-3059-port to master * commit '0e21e5b4d988d43040573a4fc71547829c815ec0': RED-3059: Fixed inital expansion overlaps	2021-12-10 11:37:24 +01:00
deiflaender	0e21e5b4d9	RED-3059: Fixed inital expansion overlaps	2021-12-10 11:32:53 +01:00
Dominique Eiflaender	29a66ee5cf	Pull request #290 : RED-2439: Added endpoint to calculate textBefore and textAfter for manual redactions Merge in RED/redaction-service from RED-2439 to master * commit '6950c00711dc113bb012a9cd3cc26c5c276409a0': RED-2439: Added endpoint to calculate textBefore and textAfter for manual redactions	2021-12-09 16:19:24 +01:00
deiflaender	6950c00711	RED-2439: Added endpoint to calculate textBefore and textAfter for manual redactions	2021-12-09 16:12:02 +01:00
Philipp Schramm	fa4b2263bc	Pull request #288 : RED-2795 Bugfix with inconsistent types for recategorizing Images in specific cases Merge in RED/redaction-service from bugfix/RED-2795 to master * commit '415df2b3658b4525120a15fb0f341164a73bb3d4': RED-2795 Bugfix with inconsistent types for recategorizing Images in specific cases	2021-12-07 11:15:30 +01:00
Philipp Schramm	415df2b365	RED-2795 Bugfix with inconsistent types for recategorizing Images in specific cases	2021-12-07 11:10:53 +01:00
Philipp Schramm	cda8e51d9d	Pull request #286 : Bugfix/RED-2845 3.0 Merge in RED/redaction-service from bugfix/RED-2845_3.0 to master * commit '1c982a40422a16e9caa8d264e4221524c7e1c92b': RED-2845 Bugfix: Avoid the expansion if it would result in a redaction overlap and bugfix in RegExp in drools	2021-12-02 14:07:45 +01:00
Philipp Schramm	1c982a4042	RED-2845 Bugfix: Avoid the expansion if it would result in a redaction overlap and bugfix in RegExp in drools	2021-12-02 14:02:31 +01:00
Dominique Eiflaender	456bd7e093	Pull request #285 : RED-2862: Added possibility to ignore dictionaries by rule Merge in RED/redaction-service from RED-2862-3.0.0 to master * commit 'f37f3b2dcf10102d03bbf3fb3233a801537d45ad': RED-2862: Added possibility to ignore dictionaries by rule	2021-12-01 12:46:10 +01:00
deiflaender	f37f3b2dcf	RED-2862: Added possibility to ignore dictionaries by rule	2021-12-01 12:40:59 +01:00
Dominique Eiflaender	809c563934	Pull request #283 : Hotfix for duplicate entries in redactionLog Merge in RED/redaction-service from DuplicateIdsMaster to master * commit '46d14cfc6441588ee57e19d4780ffebcf70e3367': Hotfix for duplicate entries in redactionLog	2021-11-30 16:36:03 +01:00
deiflaender	46d14cfc64	Hotfix for duplicate entries in redactionLog	2021-11-30 16:27:59 +01:00
Dominique Eiflaender	459c977f7e	Pull request #281 : RED-2861: Ported changes for rectangle redaction improvements Merge in RED/redaction-service from RED-2861-port to master * commit '7b1c9c97e672d78e0fbf7f05138db853a11e7d04': RED-2861: Ported changes for rectangle redaction improvements	2021-11-30 12:52:26 +01:00
deiflaender	7b1c9c97e6	RED-2861: Ported changes for rectangle redaction improvements	2021-11-30 12:47:22 +01:00
Philipp Schramm	8d881d4ca6	Pull request #280 : RED-2756 Bugfix with redactions are not continuous and added some entries to dictionary Merge in RED/redaction-service from bugfix/RED-2756 to master * commit '35a4d004fda0404e9b19e7112d25627cbde2a932': RED-2756 Bugfix with redactions are not continuous and added some entries to dictionary	2021-11-30 11:15:32 +01:00
Philipp Schramm	35a4d004fd	RED-2756 Bugfix with redactions are not continuous and added some entries to dictionary	2021-11-30 11:05:06 +01:00
Ali Oezyetimoglu	ad80d4247c	Pull request #278 : RED-2841: INC6207970 Rule for initials expansion should be applied only to dictionary entries without whitespaces Merge in RED/redaction-service from RED-2841-rs1 to master * commit 'd1317c5bd4f9522eecd78775656a0f7b5a74c3d7': RED-2841: INC6207970 Rule for initials expansion should be applied only to dictionary entries without whitespaces	2021-11-29 15:40:51 +01:00
aoezyetimoglu	d1317c5bd4	RED-2841: INC6207970 Rule for initials expansion should be applied only to dictionary entries without whitespaces	2021-11-29 12:38:53 +01:00
Philipp Schramm	f5817204bf	Pull request #277 : Bugfix/RED-2756 Merge in RED/redaction-service from bugfix/RED-2756 to master * commit '9d0fafd63ddb23fd8ee2f154e02df88687e08f96': RED-2756 Bugfix with redactions are not continuous RED-2756 Bugfix for 'Redaction is not continuous', compare line height and y position instead of rounding y values	2021-11-29 10:36:05 +01:00
Philipp Schramm	9d0fafd63d	RED-2756 Bugfix with redactions are not continuous	2021-11-29 10:31:32 +01:00
Philipp Schramm	6230f42fcf	RED-2756 Bugfix for 'Redaction is not continuous', compare line height and y position instead of rounding y values	2021-11-25 16:40:26 +01:00
Timo Bejan	571035dda1	Pull request #275 : redaction-log info for RED-2659 Merge in RED/redaction-service from section-info to master * commit '892fa6ade0c9f260183686535612e7423ed2ec09': redaction-log info for RED-2659	2021-11-22 13:49:44 +01:00
Timo Bejan	892fa6ade0	redaction-log info for RED-2659	2021-11-22 14:45:02 +02:00
Timo Bejan	ab9dcbbafb	Pull request #274 : section info port Merge in RED/redaction-service from section-info to master * commit '980d14b6049c0e7f52c2cc4fffbffa7d5bf54b08': section info port	2021-11-22 08:51:10 +01:00