Marmelator/redaction-service
1
0
Fork 0
Code Issues Pull Requests 14 Actions Packages Projects Releases 622 Wiki Activity

DM-483: endless loops with false positive #159

Closed
kilian.schuettler1 wants to merge 6 commits from DM-483 into master
pull from: DM-483
merge into: Marmelator:master
Conversation 9 Commits 6 Files Changed 12 +278 -314
kilian.schuettler1 commented 2023-10-12 12:33:23 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
  • fix byNerEntity always creating a new Entity and therefore enabling endless loops
  • same thing for copyEntity

Signed-off-by: Kilian Schuettler kilian.schuettler@knecon.com

Closes DM-483

* fix byNerEntity always creating a new Entity and therefore enabling endless loops * same thing for copyEntity Signed-off-by: Kilian Schuettler <kilian.schuettler@knecon.com> Closes DM-483
kilian.schuettler1 commented 2023-10-12 12:33:23 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @andrei.isvoran.ext and @kilian.schuettler1

assigned to @andrei.isvoran.ext and @kilian.schuettler1
kilian.schuettler1 commented 2023-10-12 12:37:22 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 92ea6fdb - DM-483: endless loops with false positive

Compare with previous version

added 1 commit <ul><li>92ea6fdb - DM-483: endless loops with false positive</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/159/diffs?diff_id=21785&start_sha=b78f6d2d0f2b23028b24601935f09f01012def7d)
corina.olariu.ext1 commented 2023-10-12 12:39:47 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

maybe rename also redactionLog to entityLog and redactionLogPerPage to EntityLogPerPage

maybe rename also redactionLog to entityLog and redactionLogPerPage to EntityLogPerPage
andrei.isvoran.ext commented 2023-10-12 14:15:02 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 5cf8a067 - DM-483 - Prevent endless loops

Compare with previous version

added 1 commit <ul><li>5cf8a067 - DM-483 - Prevent endless loops</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/159/diffs?diff_id=21794&start_sha=92ea6fdb9930fc1f095936a89355740c47a52530)
andrei.isvoran.ext commented 2023-10-12 14:15:08 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

resolved all threads

resolved all threads
andrei.isvoran.ext commented 2023-10-12 14:15:50 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/redactmanager/redaction-service/-/merge_requests/159/diffs?diff_id=21796&start_sha=5cf8a06761f9989744e978f894f92d3ea88a79be#1a6a2be04bf1e2751d9965d9eeea1b2b5962fd00_99_99)
andrei.isvoran.ext commented 2023-10-12 14:15:50 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 700383cf - DM-483 - Prevent endless loops

Compare with previous version

added 1 commit <ul><li>700383cf - DM-483 - Prevent endless loops</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/159/diffs?diff_id=21796&start_sha=5cf8a06761f9989744e978f894f92d3ea88a79be)
corina.olariu.ext1 commented 2023-10-12 14:39:08 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

approved this merge request

approved this merge request
andrei.isvoran.ext commented 2023-10-12 16:23:35 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

added 1 commit

  • 90cb7c4d - DM-483 - Prevent endless loops

Compare with previous version

added 1 commit <ul><li>90cb7c4d - DM-483 - Prevent endless loops</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/159/diffs?diff_id=21804&start_sha=700383cfbd479d9d483df5e24f4adb1e3ac8cc5f)
andrei.isvoran.ext (Migrated from gitlab.knecon.com) closed this pull request 2023-10-13 14:20:42 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/redaction-service#159
No description provided.
Delete Branch "DM-483"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?