Marmelator/redaction-service
1
0
Fork 0
Code Issues Pull Requests 14 Actions Packages Projects Releases 622 Wiki Activity

Resolve RED-9472 "Feature/" #537

Open
yannik.hampe wants to merge 113 commits from feature/RED-9472 into master
pull from: feature/RED-9472
merge into: :master
Conversation 119 Commits 113 Files Changed 78
+1277 -704
yannik.hampe commented 2024-10-10 09:41:52 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

Closes RED-9472

Closes RED-9472
yannik.hampe commented 2024-10-10 09:41:52 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

assigned to @yannik.hampe

assigned to @yannik.hampe
yannik.hampe commented 2024-10-10 09:44:01 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 10 commits

  • fb8f227a - RED-9472: seperation of system rules
  • b42b5762 - RED-9472: seperation of system rules
  • 1ccdcf58 - RED-9472: seperation of system rules
  • 4978259f - RED-9472: seperation of system rules
  • ae385068 - RED-9472: seperation of system rules
  • a8df56b2 - RED-9472: seperation of system rules
  • 3f043c5f - RED-9472: seperation of system rules
  • 56011341 - RED-9472: seperation of system rules
  • 9c3dc265 - RED-9472: seperation of system rules
  • 2a5cefc6 - Merge branch 'RED-9472' into feature/RED-9472

Compare with previous version

added 10 commits <ul><li>fb8f227a - RED-9472: seperation of system rules</li><li>b42b5762 - RED-9472: seperation of system rules</li><li>1ccdcf58 - RED-9472: seperation of system rules</li><li>4978259f - RED-9472: seperation of system rules</li><li>ae385068 - RED-9472: seperation of system rules</li><li>a8df56b2 - RED-9472: seperation of system rules</li><li>3f043c5f - RED-9472: seperation of system rules</li><li>56011341 - RED-9472: seperation of system rules</li><li>9c3dc265 - RED-9472: seperation of system rules</li><li>2a5cefc6 - Merge branch &#39;RED-9472&#39; into feature/RED-9472</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=53065&start_sha=0aea884da221b51445d0994d3c4006d311a6d2a8)
yannik.hampe commented 2024-10-10 13:14:26 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 74599683 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>74599683 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=53115&start_sha=2a5cefc6bf15cd7660d1261d8a65cb029e93db1a)
yannik.hampe commented 2024-10-14 17:08:32 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 5ff0b3ac - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>5ff0b3ac - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=53197&start_sha=74599683a5ad4e0d843ddbbe6b4ab7c29a58b1ce)
yannik.hampe commented 2024-10-15 09:36:02 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 30a9de6b - changed logback version

Compare with previous version

added 1 commit <ul><li>30a9de6b - changed logback version</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=53214&start_sha=5ff0b3acfb32913f9d4fe455e1c58d8e64f5a857)
yannik.hampe commented 2024-10-15 12:53:02 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 76135e0c - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>76135e0c - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=53254&start_sha=30a9de6b1b7f66bf6c43e8c55bf755a2d25879ae)
yannik.hampe commented 2024-10-16 09:06:02 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 370b7662 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>370b7662 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=53282&start_sha=74599683a5ad4e0d843ddbbe6b4ab7c29a58b1ce)
yannik.hampe commented 2024-10-16 09:29:11 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • ed9f2def - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>ed9f2def - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=53283&start_sha=370b76628b447bbb629ca81e3675f815b9053d59)
yannik.hampe commented 2024-10-16 11:21:58 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 1306e4ac - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>1306e4ac - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=53287&start_sha=ed9f2defbc5e8f9120194d9af230840af16f10d4)
yannik.hampe commented 2024-10-16 12:12:59 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 514cba83 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>514cba83 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=53294&start_sha=1306e4ac326a29718916a7da1d2e7a0371d00ce2)
yannik.hampe commented 2024-10-17 09:43:49 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • a4fe510b - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>a4fe510b - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=53325&start_sha=514cba835bd0cca47efba178f185be8994bdcaf2)
yannik.hampe commented 2024-10-17 10:49:52 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 848de2bc - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>848de2bc - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=53334&start_sha=a4fe510b6d61c428f8ebede59f2a1b125fc78de9)
yannik.hampe commented 2024-10-21 10:33:58 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • d497c368 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>d497c368 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=53442&start_sha=848de2bc4f054f883cc82200421e6f6aa4255b78)
yannik.hampe commented 2024-10-21 11:16:03 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 8bf929df - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>8bf929df - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=53446&start_sha=d497c3689fba1a276b1ff0c2e0c404d950142d88)
yannik.hampe commented 2024-10-22 11:47:23 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 583f244d - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>583f244d - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=53484&start_sha=8bf929df9284d1cbc593590e8310ed4a9df4f2b0)
yannik.hampe commented 2024-10-22 11:47:29 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • a95352e4 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>a95352e4 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=53485&start_sha=583f244d45bffdd0358d7cdf8d492cde3875c521)
yannik.hampe commented 2024-10-23 09:30:03 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • de7ea74c - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>de7ea74c - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=53544&start_sha=a95352e40c6ce9760778868fcf5805c88c5b233d)
yannik.hampe commented 2024-10-23 09:30:44 +02:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

requested review from @kilian.schuettler1, @dominique.eiflaender1, @corina.olariu.ext1, and @maverick.studer

requested review from @kilian.schuettler1, @dominique.eiflaender1, @corina.olariu.ext1, and @maverick.studer
kilian.schuettler1 commented 2024-10-29 18:15:40 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

This name does not seem to reflect what the function is doing

This name does not seem to reflect what the function is doing
kilian.schuettler1 commented 2024-10-29 18:16:00 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

Don't leave as many info logs, it will completely spam the console

Don't leave as many info logs, it will completely spam the console
kilian.schuettler1 commented 2024-10-29 18:16:36 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

Why is systemRules a List<String>?

Shouldn't it be like a List of RuleIdentifiers?

Why is systemRules a List\<String\>? Shouldn't it be like a List of RuleIdentifiers?
kilian.schuettler1 commented 2024-10-29 18:17:55 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

Why do you want to keep the linebreaks in all but the first import?

Why do you want to keep the linebreaks in all but the first import?
kilian.schuettler1 commented 2024-10-29 18:22:23 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

Now that the project is inside the processor it has access to spring dependencies so we can use the class ClassPathRessource instead of the classloader to access these files.

Would make for a cleaner implementation imo.

Now that the project is inside the processor it has access to spring dependencies so we can use the class ClassPathRessource instead of the classloader to access these files. Would make for a cleaner implementation imo.
kilian.schuettler1 commented 2024-10-29 18:26:11 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

For all the functions below there is already a class, the RuleFileFactory.

Also, ChatGPT leaves an excessive amount of comments, imo we should remove them, as the operations are obvious and only help the model for generating the correct code.

For all the functions below there is already a class, the RuleFileFactory. Also, ChatGPT leaves an excessive amount of comments, imo we should remove them, as the operations are obvious and only help the model for generating the correct code.
kilian.schuettler1 commented 2024-10-29 18:33:00 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

cannot happen, groupingBy operator always returns a map

cannot happen, groupingBy operator always returns a map
kilian.schuettler1 commented 2024-10-29 18:34:07 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

An AssertionError would be more appropriate here

An AssertionError would be more appropriate here
kilian.schuettler1 commented 2024-10-29 18:36:50 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

These should be RuleIdentifiers and not just the RuleTypes. E.g. syngenta has their own X rule (X.50.0 and X.50.1)

Also RuleIdentifiers can use wildcards, such as *, we could extend that a bit and support regex there as well and only lock X.0 - X.49 or smth.

These should be RuleIdentifiers and not just the RuleTypes. E.g. syngenta has their own X rule (X.50.0 and X.50.1) Also RuleIdentifiers can use wildcards, such as \*, we could extend that a bit and support regex there as well and only lock X.0 - X.49 or smth.
kilian.schuettler1 commented 2024-10-29 18:39:52 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

If the SystemRules are RuleIdentifiers, you could use the removeRule function directly. Or at least make a new one, which removes an entire ruleClass at once.

This seems very convoluted to first search for them, just to obtain the RuleIdentifier and then remove them.

If the SystemRules are RuleIdentifiers, you could use the removeRule function directly. Or at least make a new one, which removes an entire ruleClass at once. This seems very convoluted to first search for them, just to obtain the RuleIdentifier and then remove them.
kilian.schuettler1 commented 2024-10-29 18:40:18 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

Why do we need to check that all are removed?

Shouldn't this be more of a Unit Test and not production code?

Why do we need to check that all are removed? Shouldn't this be more of a Unit Test and not production code?
kilian.schuettler1 commented 2024-10-29 18:41:36 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

There is already a function in the RuleFileBluePrint doing almost exactly that. See RuleFileBluePrint::buildFilteredBluePrintByRuleIdentifiers

There is already a function in the RuleFileBluePrint doing almost exactly that. See RuleFileBluePrint::buildFilteredBluePrintByRuleIdentifiers
kilian.schuettler1 commented 2024-10-29 18:44:12 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

Raw use of parameterized class

Raw use of parameterized class
kilian.schuettler1 commented 2024-10-29 18:46:49 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

unused method

unused method
kilian.schuettler1 commented 2024-10-29 18:47:12 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

Also, it's unused

Also, it's unused
kilian.schuettler1 commented 2024-10-29 18:47:30 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

imo this does not need comments

imo this does not need comments
kilian.schuettler1 commented 2024-10-29 18:48:12 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

If you want to put one, put javadoc with something like:

Groups basic rules into classes and units based on their RuleIdentifier

If you want to put one, put javadoc with something like: Groups basic rules into classes and units based on their RuleIdentifier
kilian.schuettler1 commented 2024-10-29 18:54:09 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

This does not need to be a spring test, as all services you need for this test is the RuleBuilderService and that does not have any other dependencies. So this can be a simple Junit test.

This does not need to be a spring test, as all services you need for this test is the RuleBuilderService and that does not have any other dependencies. So this can be a simple Junit test.
kilian.schuettler1 commented 2024-10-29 18:55:24 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

I would add a test, which takes a rule file, removes the system rules and adds them again, then asserts, the initial and final rule file are equal.

Then run that for all rule files present in the drools folder

I would add a test, which takes a rule file, removes the system rules and adds them again, then asserts, the initial and final rule file are equal. Then run that for all rule files present in the drools folder
yannik.hampe commented 2024-11-05 10:47:31 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed.

changed.
yannik.hampe commented 2024-11-05 10:48:38 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

fixed

fixed
yannik.hampe commented 2024-11-06 09:27:41 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

yes this can be a unit tests.

removed it

yes this can be a unit tests. removed it
yannik.hampe commented 2024-11-13 09:39:20 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

resolved all threads

resolved all threads
yannik.hampe commented 2024-11-13 09:46:31 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54480&start_sha=de7ea74ccf11e5dc4a5cfbfb1bb3f78bc6102197#b748fb8473c6ded91844a8761cd4746197aa72af_95_57)
yannik.hampe commented 2024-11-13 09:46:31 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54480&start_sha=de7ea74ccf11e5dc4a5cfbfb1bb3f78bc6102197#b748fb8473c6ded91844a8761cd4746197aa72af_86_57)
yannik.hampe commented 2024-11-13 09:46:31 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54480&start_sha=de7ea74ccf11e5dc4a5cfbfb1bb3f78bc6102197#b748fb8473c6ded91844a8761cd4746197aa72af_60_57)
yannik.hampe commented 2024-11-13 09:46:31 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54480&start_sha=de7ea74ccf11e5dc4a5cfbfb1bb3f78bc6102197#b748fb8473c6ded91844a8761cd4746197aa72af_103_59)
yannik.hampe commented 2024-11-13 09:46:32 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54480&start_sha=de7ea74ccf11e5dc4a5cfbfb1bb3f78bc6102197#b3138431ffe90cfb746c9de062870f6d2b0d56c7_13_16)
yannik.hampe commented 2024-11-13 09:46:32 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54480&start_sha=de7ea74ccf11e5dc4a5cfbfb1bb3f78bc6102197#f9307efb000e871a17a98c22b18ec14d9c69abf7_124_96)
yannik.hampe commented 2024-11-13 09:46:32 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54480&start_sha=de7ea74ccf11e5dc4a5cfbfb1bb3f78bc6102197#753e55bb10624bd7ff2f43479f2a9997139a62e6_124_123)
yannik.hampe commented 2024-11-13 09:46:33 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54480&start_sha=de7ea74ccf11e5dc4a5cfbfb1bb3f78bc6102197#92ac1de4dc00686fc98f3a56f663c731c5dd53ec_48_48)
yannik.hampe commented 2024-11-13 09:46:33 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54480&start_sha=de7ea74ccf11e5dc4a5cfbfb1bb3f78bc6102197#b04078475c37802ed4e4db518eab38e2bf50213e_29_25)
yannik.hampe commented 2024-11-13 09:46:33 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54480&start_sha=de7ea74ccf11e5dc4a5cfbfb1bb3f78bc6102197#b04078475c37802ed4e4db518eab38e2bf50213e_156_103)
yannik.hampe commented 2024-11-13 09:46:33 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54480&start_sha=de7ea74ccf11e5dc4a5cfbfb1bb3f78bc6102197#b04078475c37802ed4e4db518eab38e2bf50213e_138_98)
yannik.hampe commented 2024-11-13 09:46:33 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54480&start_sha=de7ea74ccf11e5dc4a5cfbfb1bb3f78bc6102197#b04078475c37802ed4e4db518eab38e2bf50213e_120_96)
yannik.hampe commented 2024-11-13 09:46:34 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54480&start_sha=de7ea74ccf11e5dc4a5cfbfb1bb3f78bc6102197#92ac1de4dc00686fc98f3a56f663c731c5dd53ec_56_56)
yannik.hampe commented 2024-11-13 09:46:34 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54480&start_sha=de7ea74ccf11e5dc4a5cfbfb1bb3f78bc6102197#f9307efb000e871a17a98c22b18ec14d9c69abf7_38_38)
yannik.hampe commented 2024-11-13 09:46:34 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54480&start_sha=de7ea74ccf11e5dc4a5cfbfb1bb3f78bc6102197#f9307efb000e871a17a98c22b18ec14d9c69abf7_219_139)
yannik.hampe commented 2024-11-13 09:46:34 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54480&start_sha=de7ea74ccf11e5dc4a5cfbfb1bb3f78bc6102197#dedb22c82d61d241847b5591ebb7b3f9e616f176_47_30)
yannik.hampe commented 2024-11-13 09:46:35 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54480&start_sha=de7ea74ccf11e5dc4a5cfbfb1bb3f78bc6102197#dedb22c82d61d241847b5591ebb7b3f9e616f176_97_52)
yannik.hampe commented 2024-11-13 09:46:35 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 301dc718 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>301dc718 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54480&start_sha=de7ea74ccf11e5dc4a5cfbfb1bb3f78bc6102197)
yannik.hampe commented 2024-11-13 11:38:39 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 65166751 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>65166751 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54514&start_sha=301dc718e8ffd66ddcb9fc153572ff1339e54d07)
yannik.hampe commented 2024-11-13 12:01:13 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 5ab0747d - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>5ab0747d - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54520&start_sha=65166751f1f65aa36cce8f6f50fab9bfa70a6107)
yannik.hampe commented 2024-11-13 12:26:34 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 07cd81e5 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>07cd81e5 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54531&start_sha=5ab0747d303e85ccf9b389c385348df6ae306807)
kilian.schuettler1 commented 2024-11-14 16:55:54 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

You create a set from it below and otherwise you only iterate over it, so it should be a Set

You create a set from it below and otherwise you only iterate over it, so it should be a Set
kilian.schuettler1 commented 2024-11-14 16:58:46 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

If a User adds new imports, they need to be added.

It seems you are removing all imports from the update.

Does this work then?

If a User adds new imports, they need to be added. It seems you are removing all imports from the update. Does this work then?
kilian.schuettler1 commented 2024-11-14 16:59:04 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

There is a function for this, getAllRules()

There is a function for this, getAllRules()
kilian.schuettler1 commented 2024-11-14 17:00:51 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

split the imports by the import keyword and create a Set from them to avoid duplicates.

Check function public Set<String> getImportSplitByKeyword() in RulesCompilationResult

split the imports by the import keyword and create a Set from them to avoid duplicates. Check function public Set\<String\> getImportSplitByKeyword() in RulesCompilationResult
kilian.schuettler1 commented 2024-11-14 17:01:23 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

Same here, we should not allow duplicates

Same here, we should not allow duplicates
kilian.schuettler1 commented 2024-11-14 17:01:37 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

Same here, check for duplicates

Same here, check for duplicates
kilian.schuettler1 commented 2024-11-14 17:03:20 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

This function is not in-place

This function is not in-place
kilian.schuettler1 commented 2024-11-14 17:05:47 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

you need to set the declarations and functions from the original bluePrint, or this does not do what is expected

you need to set the declarations and functions from the original bluePrint, or this does not do what is expected
kilian.schuettler1 commented 2024-11-14 17:08:16 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

The deploy JavaDoc below already publishes and is just missing the feature branch based rule.

With your change everything would get published twice.

Rebase onto master, its already changed there

The deploy JavaDoc below already publishes and is just missing the feature branch based rule. With your change everything would get published twice. Rebase onto master, its already changed there
yannik.hampe commented 2024-11-15 08:38:36 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

this is a mistake, changed

this is a mistake, changed
yannik.hampe commented 2024-11-15 09:45:38 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

resolved all threads

resolved all threads
yannik.hampe commented 2024-11-15 09:46:01 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54713&start_sha=07cd81e5a9cda1f389444d2cbaa09f907b46a8a9#b04078475c37802ed4e4db518eab38e2bf50213e_25_25)
yannik.hampe commented 2024-11-15 09:46:01 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54713&start_sha=07cd81e5a9cda1f389444d2cbaa09f907b46a8a9#b04078475c37802ed4e4db518eab38e2bf50213e_55_55)
yannik.hampe commented 2024-11-15 09:46:01 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54713&start_sha=07cd81e5a9cda1f389444d2cbaa09f907b46a8a9#b04078475c37802ed4e4db518eab38e2bf50213e_65_64)
yannik.hampe commented 2024-11-15 09:46:02 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54713&start_sha=07cd81e5a9cda1f389444d2cbaa09f907b46a8a9#b04078475c37802ed4e4db518eab38e2bf50213e_72_67)
yannik.hampe commented 2024-11-15 09:46:02 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54713&start_sha=07cd81e5a9cda1f389444d2cbaa09f907b46a8a9#b04078475c37802ed4e4db518eab38e2bf50213e_73_67)
yannik.hampe commented 2024-11-15 09:46:02 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54713&start_sha=07cd81e5a9cda1f389444d2cbaa09f907b46a8a9#b04078475c37802ed4e4db518eab38e2bf50213e_94_97)
yannik.hampe commented 2024-11-15 09:46:02 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54713&start_sha=07cd81e5a9cda1f389444d2cbaa09f907b46a8a9#e47c500ac037bb7cb0df2679eeb72879c5115ae0_183_183)
yannik.hampe commented 2024-11-15 09:46:03 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 7e64bb28 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>7e64bb28 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54713&start_sha=07cd81e5a9cda1f389444d2cbaa09f907b46a8a9)
yannik.hampe commented 2024-11-15 10:13:51 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 23 of the diff

changed this line in [version 23 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54716&start_sha=7e64bb28e880b7006d0dfcdd83896b685b343321#587d266bb27a4dc3022bbed44dfa19849df3044c_17_15)
yannik.hampe commented 2024-11-15 10:13:51 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 39 commits

  • 7e64bb28...21f2ded6 - 32 commits from branch master
  • 85bef908 - RED-9472: seperation of system rules
  • e535c62b - RED-9472: seperation of system rules
  • cb102a4e - RED-9472: seperation of system rules
  • 7fcaaacd - RED-9472: seperation of system rules
  • 0342c20a - RED-9472: seperation of system rules
  • 65cee5d4 - RED-9472: seperation of system rules
  • e349578c - Merge remote-tracking branch 'origin/feature/RED-9472' into feature/RED-9472

Compare with previous version

added 39 commits <ul><li>7e64bb28...21f2ded6 - 32 commits from branch <code>master</code></li><li>85bef908 - RED-9472: seperation of system rules</li><li>e535c62b - RED-9472: seperation of system rules</li><li>cb102a4e - RED-9472: seperation of system rules</li><li>7fcaaacd - RED-9472: seperation of system rules</li><li>0342c20a - RED-9472: seperation of system rules</li><li>65cee5d4 - RED-9472: seperation of system rules</li><li>e349578c - Merge remote-tracking branch &#39;origin/feature/RED-9472&#39; into feature/RED-9472</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54716&start_sha=7e64bb28e880b7006d0dfcdd83896b685b343321)
yannik.hampe commented 2024-11-18 09:04:53 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 4e773850 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>4e773850 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54799&start_sha=e349578cb9141983910c9e2d3190981d03ba9833)
yannik.hampe commented 2024-11-18 13:02:23 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 8c10e1c0 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>8c10e1c0 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54851&start_sha=4e7738503338f5d6bf719af68248f20840e3ee17)
yannik.hampe commented 2024-11-19 08:52:37 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 44721015 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>44721015 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54911&start_sha=8c10e1c00d9430910cf95db590b2c725182832e9)
yannik.hampe commented 2024-11-19 09:52:22 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 19 commits

  • 44721015...3f606ad5 - 7 commits from branch master
  • 3f606ad5...23959262 - 2 earlier commits
  • 463154a4 - RED-9472: seperation of system rules
  • 16950018 - RED-9472: seperation of system rules
  • e47dc307 - RED-9472: seperation of system rules
  • 82bfa1b5 - RED-9472: seperation of system rules
  • e5d00de2 - RED-9472: seperation of system rules
  • 6b7cf3a4 - RED-9472: seperation of system rules
  • 6208017d - RED-9472: seperation of system rules
  • f7467298 - RED-9472: seperation of system rules
  • 76120908 - RED-9472: seperation of system rules
  • c702ccb5 - Merge remote-tracking branch 'origin/feature/RED-9472' into feature/RED-9472

Compare with previous version

added 19 commits <ul><li>44721015...3f606ad5 - 7 commits from branch <code>master</code></li><li>3f606ad5...23959262 - 2 earlier commits</li><li>463154a4 - RED-9472: seperation of system rules</li><li>16950018 - RED-9472: seperation of system rules</li><li>e47dc307 - RED-9472: seperation of system rules</li><li>82bfa1b5 - RED-9472: seperation of system rules</li><li>e5d00de2 - RED-9472: seperation of system rules</li><li>6b7cf3a4 - RED-9472: seperation of system rules</li><li>6208017d - RED-9472: seperation of system rules</li><li>f7467298 - RED-9472: seperation of system rules</li><li>76120908 - RED-9472: seperation of system rules</li><li>c702ccb5 - Merge remote-tracking branch &#39;origin/feature/RED-9472&#39; into feature/RED-9472</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54929&start_sha=447210151ffd98947f2505670345a80878aa77e5)
yannik.hampe commented 2024-11-19 09:56:00 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 57408df4 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>57408df4 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54933&start_sha=c702ccb5949856f361beb35501300d3e5c9bfa0b)
yannik.hampe commented 2024-11-19 10:04:55 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • f0129955 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>f0129955 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54944&start_sha=57408df41365fa076b12ff758f098cf86d3187b7)
yannik.hampe commented 2024-11-19 10:18:14 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 5f97d7ac - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>5f97d7ac - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54951&start_sha=f0129955df51ff08b500dad4c4b2a4f14dff2d08)
yannik.hampe commented 2024-11-19 12:00:03 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 35a572a3 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>35a572a3 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=54961&start_sha=5f97d7acb36da006eddc127936437716cd1a0f11)
kilian.schuettler1 commented 2024-11-22 09:54:31 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
yannik.hampe commented 2024-11-22 10:13:01 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 7 commits

  • 35a572a3...db59ae01 - 6 commits from branch master
  • 518a9bdb - Merge branch 'master' into 'feature/RED-9472'

Compare with previous version

added 7 commits <ul><li>35a572a3...db59ae01 - 6 commits from branch <code>master</code></li><li>518a9bdb - Merge branch &#39;master&#39; into &#39;feature/RED-9472&#39;</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=56478&start_sha=35a572a3c5e73ba7337c82d1fca40c737f2be6fb)
yannik.hampe (Migrated from gitlab.knecon.com) scheduled this pull request to auto merge when all checks succeed 2024-11-22 10:13:08 +01:00
yannik.hampe commented 2024-11-22 10:13:14 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

reset approvals from @kilian.schuettler1 by pushing to the branch

reset approvals from @kilian.schuettler1 by pushing to the branch
kilian.schuettler1 commented 2024-11-22 10:13:58 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
yannik.hampe commented 2024-12-12 13:35:57 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 47eda629 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>47eda629 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=58313&start_sha=518a9bdb2e020dd15efba09730797d0d1b8cf560)
yannik.hampe commented 2024-12-12 13:36:10 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

reset approvals from @kilian.schuettler1 by pushing to the branch

reset approvals from @kilian.schuettler1 by pushing to the branch
yannik.hampe commented 2024-12-12 14:57:22 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 34 commits

  • 47eda629...c1990ef4 - 12 commits from branch master
  • c1990ef4...af00a4f5 - 12 earlier commits
  • c71668ad - RED-9472: seperation of system rules
  • 802d6630 - RED-9472: seperation of system rules
  • 0be1812c - RED-9472: seperation of system rules
  • 8099676c - RED-9472: seperation of system rules
  • 1642e14e - RED-9472: seperation of system rules
  • 79159113 - RED-9472: seperation of system rules
  • 2762d378 - RED-9472: seperation of system rules
  • ea3b0b99 - RED-9472: seperation of system rules
  • a011a93f - RED-9472: seperation of system rules
  • 9463f4f5 - Merge remote-tracking branch 'origin/feature/RED-9472' into feature/RED-9472

Compare with previous version

added 34 commits <ul><li>47eda629...c1990ef4 - 12 commits from branch <code>master</code></li><li>c1990ef4...af00a4f5 - 12 earlier commits</li><li>c71668ad - RED-9472: seperation of system rules</li><li>802d6630 - RED-9472: seperation of system rules</li><li>0be1812c - RED-9472: seperation of system rules</li><li>8099676c - RED-9472: seperation of system rules</li><li>1642e14e - RED-9472: seperation of system rules</li><li>79159113 - RED-9472: seperation of system rules</li><li>2762d378 - RED-9472: seperation of system rules</li><li>ea3b0b99 - RED-9472: seperation of system rules</li><li>a011a93f - RED-9472: seperation of system rules</li><li>9463f4f5 - Merge remote-tracking branch &#39;origin/feature/RED-9472&#39; into feature/RED-9472</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=58316&start_sha=47eda6290fde3aaaeafd184f2a78050f0cf2ac3a)
yannik.hampe commented 2024-12-12 15:00:07 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • fb639b47 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>fb639b47 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=58318&start_sha=9463f4f5873d96130d99b45fbf0287da0234b3d2)
yannik.hampe commented 2024-12-12 15:04:58 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • b12457cd - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>b12457cd - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=58322&start_sha=fb639b47576343e1b3bab1943c5264a1ebffaeff)
yannik.hampe commented 2024-12-13 10:06:58 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

marked this merge request as ready

marked this merge request as **ready**
yannik.hampe commented 2024-12-13 11:52:40 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

changed this line in version 37 of the diff

changed this line in [version 37 of the diff](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=58485&start_sha=b12457cd7b2541ce92beedd455624044b0b173ba#b04078475c37802ed4e4db518eab38e2bf50213e_77_78)
yannik.hampe commented 2024-12-13 11:52:41 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • a0b34894 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>a0b34894 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=58485&start_sha=b12457cd7b2541ce92beedd455624044b0b173ba)
yannik.hampe commented 2024-12-13 13:19:19 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • f22a7c45 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>f22a7c45 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=58490&start_sha=a0b34894eed50043791e260ebf0dd6928e528831)
yannik.hampe commented 2024-12-13 13:42:11 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 2d7feb8b - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>2d7feb8b - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=58495&start_sha=f22a7c450eb0c3af3ae238e2bb0bb607c52b9a7d)
yannik.hampe commented 2024-12-13 14:46:23 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • a723fe71 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>a723fe71 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=58506&start_sha=2d7feb8bfa6cc86d2c3c16087bd727bcdbedfe21)
yannik.hampe commented 2024-12-13 15:11:43 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 9cb19fb0 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>9cb19fb0 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=58510&start_sha=a723fe7129948271e40f660970c5e32aaa62f823)
yannik.hampe commented 2024-12-13 15:27:44 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 88155dc2 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>88155dc2 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=58514&start_sha=9cb19fb0f721f1fafeedd0bac1ca1a8fff3df680)
yannik.hampe commented 2024-12-18 09:49:14 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 69ae276c - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>69ae276c - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=58932&start_sha=88155dc211e96e5852f66a130fbbb9ea7069d8f8)
yannik.hampe commented 2024-12-18 10:48:37 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 56bed5a1 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>56bed5a1 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=58939&start_sha=69ae276c752f77079155f06b2e6b226614dcfeb1)
yannik.hampe commented 2024-12-18 11:02:07 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 42 commits

  • 56bed5a1...c8dd1676 - 2 commits from branch master
  • c8dd1676...3e82b997 - 30 earlier commits
  • 7363493d - RED-9472: seperation of system rules
  • bdb29a0e - RED-9472: seperation of system rules
  • d2994f9e - RED-9472: seperation of system rules
  • 77a76f8b - RED-9472: seperation of system rules
  • 1a16dd46 - RED-9472: seperation of system rules
  • cdc08307 - RED-9472: seperation of system rules
  • dfae9e5d - RED-9472: seperation of system rules
  • e55c4e5f - RED-9472: seperation of system rules
  • 04eb6cf3 - RED-9472: seperation of system rules
  • ff700a60 - Merge remote-tracking branch 'origin/feature/RED-9472' into feature/RED-9472

Compare with previous version

added 42 commits <ul><li>56bed5a1...c8dd1676 - 2 commits from branch <code>master</code></li><li>c8dd1676...3e82b997 - 30 earlier commits</li><li>7363493d - RED-9472: seperation of system rules</li><li>bdb29a0e - RED-9472: seperation of system rules</li><li>d2994f9e - RED-9472: seperation of system rules</li><li>77a76f8b - RED-9472: seperation of system rules</li><li>1a16dd46 - RED-9472: seperation of system rules</li><li>cdc08307 - RED-9472: seperation of system rules</li><li>dfae9e5d - RED-9472: seperation of system rules</li><li>e55c4e5f - RED-9472: seperation of system rules</li><li>04eb6cf3 - RED-9472: seperation of system rules</li><li>ff700a60 - Merge remote-tracking branch &#39;origin/feature/RED-9472&#39; into feature/RED-9472</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=58941&start_sha=56bed5a18ce3de4f107cf0a1b9a4f9e466e3d3a7)
kilian.schuettler1 commented 2024-12-19 13:45:49 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 5ab99496 - RED-9742: fix document import

Compare with previous version

added 1 commit <ul><li>5ab99496 - RED-9742: fix document import</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=59006&start_sha=ff700a60e499e6aaf69d991113df49cae6643afd)
kilian.schuettler1 commented 2024-12-19 14:14:05 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 077e4d0e - RED-9742: fix document import

Compare with previous version

added 1 commit <ul><li>077e4d0e - RED-9742: fix document import</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=59007&start_sha=5ab994969a9394f6fac819f85e86e4abb6bf7e94)
yannik.hampe commented 2024-12-19 14:25:13 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 3776f800 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>3776f800 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=59009&start_sha=077e4d0ee1f171b9aedc7cbf2e8bb5682396cd8b)
yannik.hampe commented 2024-12-20 09:23:56 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 9395b5ad - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>9395b5ad - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=59108&start_sha=3776f800053b10854a2d9fa95859c3161cb414d8)
yannik.hampe commented 2025-01-20 12:49:33 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • b48f448c - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>b48f448c - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=60004&start_sha=9395b5ad6bfa222e9376e0e349e6d489b27c89d5)
maverick.studer commented 2025-01-20 13:35:54 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 5a6746c5 - Potential fix for failing pipeline

Compare with previous version

added 1 commit <ul><li>5a6746c5 - Potential fix for failing pipeline</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=60006&start_sha=b48f448c24725cd3a4d03dbdc6d0c6f36cf3c242)
yannik.hampe commented 2025-01-22 10:16:08 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • f03b0a38 - RED-9472: seperation of system rules

Compare with previous version

added 1 commit <ul><li>f03b0a38 - RED-9472: seperation of system rules</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/537/diffs?diff_id=60169&start_sha=5a6746c5b2a9bcfa64289066c703f8e5e92b6979)
christoph.schabert commented 2025-01-23 09:56:38 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

SonarQube Code Analysis

Quality Gate failed

Failed conditions
57 New issues
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

## SonarQube Code Analysis ## Quality Gate failed Failed conditions [![](https://sonarqube.knecon.com/static/developer-server/common/failed-16px.png '')](https://sonarqube.knecon.com/project/issues?id=redaction-service%3Aredaction-service-server-v1&pullRequest=537&resolved=false) [57 New issues](https://sonarqube.knecon.com/project/issues?id=redaction-service%3Aredaction-service-server-v1&pullRequest=537&resolved=false) [![](https://sonarqube.knecon.com/static/developer-server/common/failed-16px.png '')](https://sonarqube.knecon.com/security_hotspots?id=redaction-service%3Aredaction-service-server-v1&pullRequest=537) [1 Security Hotspot](https://sonarqube.knecon.com/security_hotspots?id=redaction-service%3Aredaction-service-server-v1&pullRequest=537) [![](https://sonarqube.knecon.com/static/developer-server/common/failed-16px.png '')](https://sonarqube.knecon.com/component_measures?id=redaction-service%3Aredaction-service-server-v1&pullRequest=537&metric=new_coverage&view=list) [0.0% Coverage on New Code](https://sonarqube.knecon.com/component_measures?id=redaction-service%3Aredaction-service-server-v1&pullRequest=537&metric=new_coverage&view=list) (required ≥ 80%) [See analysis details on SonarQube](https://sonarqube.knecon.com/dashboard?id=redaction-service%3Aredaction-service-server-v1&pullRequest=537) ## ![](https://sonarqube.knecon.com/static/developer-server/common/bulb-16px.png '') Catch issues before they fail your Quality Gate with our IDE extension [![SonarQube IDE](https://sonarqube.knecon.com/static/developer-server/common/sonarqube-ide-16px.png 'SonarQube IDE')](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) [SonarQube IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
This pull request has changes conflicting with the target branch.
  • redaction-service-v1/rules-management/src/main/resources/all_redact_manager_rules.drl
  • redaction-service-v1/rules-management/src/main/resources/all_rules_documine.drl
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/RED-9472:feature/RED-9472
git checkout feature/RED-9472
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
renovate
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Marmelator (Kilian Schüttler)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/redaction-service#537