RED-10200: Spike performant rules update logic #572

Merged

maverick.studer merged 23 commits from feature/RED-10200 into master 2024-12-04 14:41:24 +01:00

Conversation 26 Commits 23 Files Changed 87

+3352 -2241

maverick.studer commented 2024-12-02 12:30:09 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

Closes RED-10200

Closes RED-10200

maverick.studer commented 2024-12-02 12:30:09 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

assigned to @maverick.studer

assigned to @maverick.studer

dominique.eiflaender1 (Migrated from gitlab.knecon.com) approved these changes 2024-12-02 12:30:09 +01:00

maverick.studer commented 2024-12-02 13:33:02 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

added 1 commit

• ac384f06 - RED-10200: Spike performant rules update logic

Compare with previous version

added 1 commit <ul><li>ac384f06 - RED-10200: Spike performant rules update logic</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/572/diffs?diff_id=57218&start_sha=29d25d432cc4f489185526984d342d52255a573f)

maverick.studer commented 2024-12-02 15:20:23 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

added 1 commit

• dfd95846 - RED-10200: Spike performant rules update logic

Compare with previous version

added 1 commit <ul><li>dfd95846 - RED-10200: Spike performant rules update logic</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/572/diffs?diff_id=57229&start_sha=ac384f0636ba49a467acb283dcb41692f7ce3742)

maverick.studer commented 2024-12-02 16:08:45 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

added 1 commit

• af347de8 - RED-10200: Spike performant rules update logic

Compare with previous version

added 1 commit <ul><li>af347de8 - RED-10200: Spike performant rules update logic</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/572/diffs?diff_id=57234&start_sha=dfd958466e60a7f6585ef48a28d68cf418ac4929)

kilian.schuettler1 commented 2024-12-02 16:26:50 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

Why not Java's standard HashMap implementation?

Also, wouldn't Map<TextEntity, Set<Relation>> make more sense?

Why not Java's standard HashMap implementation? Also, wouldn't Map\<TextEntity, Set\<Relation\>\> make more sense?

kilian.schuettler1 commented 2024-12-02 16:32:40 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

Always returns true now, or?

So we might no longer need the boolean

Always returns true now, or? So we might no longer need the boolean

kilian.schuettler1 commented 2024-12-02 16:35:12 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

Should always be true now, so not needed?

Should always be true now, so not needed?

kilian.schuettler1 commented 2024-12-02 16:41:01 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

Could add the eventListener to the entity here. Would reduce the calls in EntityCreationService and EntityDroolsExecutionService and make it obvious when the eventListener is used just by vieweing this class

Could add the eventListener to the entity here. Would reduce the calls in EntityCreationService and EntityDroolsExecutionService and make it obvious when the eventListener is used just by vieweing this class

kilian.schuettler1 commented 2024-12-02 16:56:48 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

Or alternatively, add onEntityInserted() to this interface, call insert from there and add the KieSessionUpdater just before calling addEntityToGraph in EntityCreationService, or addEntitites in EntityDroolsExecutionService

Or alternatively, add onEntityInserted() to this interface, call insert from there and add the KieSessionUpdater just before calling addEntityToGraph in EntityCreationService, or addEntitites in EntityDroolsExecutionService

maverick.studer commented 2024-12-02 18:18:20 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/redactmanager/redaction-service/-/merge_requests/572/diffs?diff_id=57236&start_sha=af347de8a3b4a85c34ec8ad32dfce4927c99c8c8#7c89028440a4c36dbb443c27ffd55b14f4f9ac20_79_77)

maverick.studer commented 2024-12-02 18:18:20 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/redactmanager/redaction-service/-/merge_requests/572/diffs?diff_id=57236&start_sha=af347de8a3b4a85c34ec8ad32dfce4927c99c8c8#aa8c87806c5a9613bf42446423fa2769eab31081_393_393)

maverick.studer commented 2024-12-02 18:18:21 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/redactmanager/redaction-service/-/merge_requests/572/diffs?diff_id=57236&start_sha=af347de8a3b4a85c34ec8ad32dfce4927c99c8c8#6c8e482e42c5aaa88e725ebc6099dae77ed474e0_998_997)

maverick.studer commented 2024-12-02 18:18:21 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/redactmanager/redaction-service/-/merge_requests/572/diffs?diff_id=57236&start_sha=af347de8a3b4a85c34ec8ad32dfce4927c99c8c8#e836d7568c62aa25c41f7d520e5694faa579bbdb_23_23)

maverick.studer commented 2024-12-02 18:18:21 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

added 1 commit

• 8126e7f8 - RED-10200: refactoring and cleanup

Compare with previous version

added 1 commit <ul><li>8126e7f8 - RED-10200: refactoring and cleanup</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/572/diffs?diff_id=57236&start_sha=af347de8a3b4a85c34ec8ad32dfce4927c99c8c8)

kilian.schuettler1 commented 2024-12-03 10:20:08 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

approved this merge request

approved this merge request

kilian.schuettler1 commented 2024-12-03 10:20:31 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

resolved all threads

resolved all threads

maverick.studer commented 2024-12-03 11:55:44 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

added 1 commit

• bd97e60e - RED-10200: update test

Compare with previous version

added 1 commit <ul><li>bd97e60e - RED-10200: update test</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/572/diffs?diff_id=57360&start_sha=8126e7f81e086115e1ac43fd1fecc5704984240f)

maverick.studer commented 2024-12-03 11:55:57 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

reset approvals from @kilian.schuettler1 by pushing to the branch

reset approvals from @kilian.schuettler1 by pushing to the branch

maverick.studer commented 2024-12-03 15:36:25 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

added 2 commits

• ef06d45e - RED-10200: fix failing acceptance, function tests
• dd545dae - RED-10200: fix failing acceptance, function tests

Compare with previous version

added 2 commits <ul><li>ef06d45e - RED-10200: fix failing acceptance, function tests</li><li>dd545dae - RED-10200: fix failing acceptance, function tests</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/572/diffs?diff_id=57367&start_sha=bd97e60e0f4070afa84e0b2bd2f7b9e984e1d412)

maverick.studer commented 2024-12-04 10:55:42 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

added 1 commit

• d022b1a5 - RED-10200: fix failing acceptance, function tests

Compare with previous version

added 1 commit <ul><li>d022b1a5 - RED-10200: fix failing acceptance, function tests</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/572/diffs?diff_id=57507&start_sha=dd545daeb753ceca71d3a469342e1313c14a1d0a)

maverick.studer commented 2024-12-04 11:23:19 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

added 1 commit

• 6ad03672 - RED-10200: fix failing acceptance, function tests

Compare with previous version

added 1 commit <ul><li>6ad03672 - RED-10200: fix failing acceptance, function tests</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/572/diffs?diff_id=57512&start_sha=d022b1a5c9e9f4e2d8586b5b2756a3b5269742bb)

maverick.studer commented 2024-12-04 11:51:53 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

added 1 commit

• c38edd00 - RED-10200: refactor

Compare with previous version

added 1 commit <ul><li>c38edd00 - RED-10200: refactor</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/572/diffs?diff_id=57515&start_sha=6ad0367268a5ddc2c4bd6a388f028cdfab099628)

christoph.schabert commented 2024-12-04 11:55:02 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

SonarQube Code Analysis

Quality Gate failed

Failed conditions
8 New issues
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

## SonarQube Code Analysis ## Quality Gate failed Failed conditions [](https://sonarqube.knecon.com/project/issues?id=redaction-service%3Aredaction-service-server-v1&pullRequest=572&resolved=false) [8 New issues](https://sonarqube.knecon.com/project/issues?id=redaction-service%3Aredaction-service-server-v1&pullRequest=572&resolved=false) [](https://sonarqube.knecon.com/component_measures?id=redaction-service%3Aredaction-service-server-v1&pullRequest=572&metric=new_coverage&view=list) [0.0% Coverage on New Code](https://sonarqube.knecon.com/component_measures?id=redaction-service%3Aredaction-service-server-v1&pullRequest=572&metric=new_coverage&view=list) (required ≥ 80%) [See analysis details on SonarQube](https://sonarqube.knecon.com/dashboard?id=redaction-service%3Aredaction-service-server-v1&pullRequest=572) ##  Catch issues before they fail your Quality Gate with our IDE extension [](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)

dominique.eiflaender1 commented 2024-12-04 14:37:10 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

approved this merge request

approved this merge request

maverick.studer commented 2024-12-04 14:41:25 +01:00 (Migrated from gitlab.knecon.com)

Copy Link

Copy Source

mentioned in commit a1e6361c3e

mentioned in commit a1e6361c3e89b5016677de01c74f68aa112df086

maverick.studer (Migrated from gitlab.knecon.com) merged commit a1e6361c3e into master 2024-12-04 14:41:25 +01:00

Sign in to join this conversation.

Reviewers

No Reviewers

dominique.eiflaender1

Labels

Clear labels

renovate

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

Marmelator (Kilian Schüttler)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Marmelator/redaction-service#572