Marmelator/redaction-service
1
0
Fork 0
Code Issues Pull Requests 14 Actions Packages Projects Releases 622 Wiki Activity

RED-10708: Tables as components in DM #583

Open
maverick.studer wants to merge 5 commits from RED-10708 into master
pull from: RED-10708
merge into: :master
Conversation 12 Commits 5 Files Changed 34
+2845 -219
maverick.studer commented 2025-01-27 16:52:40 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

Closes RED-10708

Closes RED-10708
maverick.studer commented 2025-01-27 16:52:40 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

assigned to @maverick.studer

assigned to @maverick.studer
dominique.eiflaender1 (Migrated from gitlab.knecon.com) approved these changes 2025-01-27 16:52:40 +01:00
maverick.studer commented 2025-01-31 12:33:54 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • 229d1e98 - RED-10708: Tables as components in DM

Compare with previous version

added 1 commit <ul><li>229d1e98 - RED-10708: Tables as components in DM</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/583/diffs?diff_id=60532&start_sha=723263a7c4651553e5a2ffe59bfed3c5aa3f9bd3)
maverick.studer commented 2025-01-31 12:59:57 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • db7debf0 - RED-10708: Tables as components in DM

Compare with previous version

added 1 commit <ul><li>db7debf0 - RED-10708: Tables as components in DM</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/583/diffs?diff_id=60534&start_sha=229d1e98ac2e04fb02c3f4b9b97c8528a03687d8)
dominique.eiflaender1 commented 2025-01-31 13:29:36 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
maverick.studer commented 2025-02-04 11:23:53 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • c3e0aae8 - RED-10708: Tables as components in DM

Compare with previous version

added 1 commit <ul><li>c3e0aae8 - RED-10708: Tables as components in DM</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/583/diffs?diff_id=60634&start_sha=db7debf0d4ac97a8136615cb6217eac8ad2a5326)
maverick.studer commented 2025-02-04 11:24:06 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

reset approvals from @dominique.eiflaender1 by pushing to the branch

reset approvals from @dominique.eiflaender1 by pushing to the branch
maverick.studer commented 2025-02-04 13:16:36 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

added 1 commit

  • a9fff497 - RED-10708: Tables as components in DM

Compare with previous version

added 1 commit <ul><li>a9fff497 - RED-10708: Tables as components in DM</li></ul> [Compare with previous version](/redactmanager/redaction-service/-/merge_requests/583/diffs?diff_id=60636&start_sha=c3e0aae800bc01a4f12806c9552f431f389d182f)
christoph.schabert commented 2025-02-04 13:19:20 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

SonarQube Code Analysis

Quality Gate failed

Failed conditions
4 New issues
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

## SonarQube Code Analysis ## Quality Gate failed Failed conditions [![](https://sonarqube.knecon.com/static/developer-server/common/failed-16px.png '')](https://sonarqube.knecon.com/project/issues?id=redaction-service%3Aredaction-service-server-v1&pullRequest=583&resolved=false) [4 New issues](https://sonarqube.knecon.com/project/issues?id=redaction-service%3Aredaction-service-server-v1&pullRequest=583&resolved=false) [![](https://sonarqube.knecon.com/static/developer-server/common/failed-16px.png '')](https://sonarqube.knecon.com/component_measures?id=redaction-service%3Aredaction-service-server-v1&pullRequest=583&metric=new_coverage&view=list) [0.0% Coverage on New Code](https://sonarqube.knecon.com/component_measures?id=redaction-service%3Aredaction-service-server-v1&pullRequest=583&metric=new_coverage&view=list) (required ≥ 80%) [See analysis details on SonarQube](https://sonarqube.knecon.com/dashboard?id=redaction-service%3Aredaction-service-server-v1&pullRequest=583) ## ![](https://sonarqube.knecon.com/static/developer-server/common/bulb-16px.png '') Catch issues before they fail your Quality Gate with our IDE extension [![SonarQube IDE](https://sonarqube.knecon.com/static/developer-server/common/sonarqube-ide-16px.png 'SonarQube IDE')](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) [SonarQube IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
kilian.schuettler1 commented 2025-02-04 13:30:48 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

instead of using the text booxes, i think we should be using the SemanticNode getBBox

instead of using the text booxes, i think we should be using the SemanticNode getBBox
dominique.eiflaender1 commented 2025-02-04 13:30:50 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
kilian.schuettler1 commented 2025-02-04 13:34:00 +01:00 (Migrated from gitlab.knecon.com)
Copy Link
Copy Source

Also, if we make SemanticEntity extend SemanticNode, we can implement this function there and then reuse the SemanticEntity for the Image as well maybe?

Also, if we make SemanticEntity extend SemanticNode, we can implement this function there and then reuse the SemanticEntity for the Image as well maybe?
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin RED-10708:RED-10708
git checkout RED-10708
Sign in to join this conversation.
Reviewers
No Reviewers
dominique.eiflaender1
Labels
Clear labels
renovate
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Marmelator (Kilian Schüttler)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/redaction-service#583