Marmelator/redaction-service
1
0
Fork 0
Code Issues Pull Requests 14 Actions Packages Projects Releases 622 Wiki Activity

DM-357 - Save manual redactions for which we did not find an exact match #85

Merged
andrei.isvoran.ext merged 1 commits from DM-357 into master 2023-08-08 17:16:44 +02:00
Conversation 4 Commits 1 Files Changed 1 +17 -20
andrei.isvoran.ext commented 2023-08-08 15:51:13 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

Closes DM-357

Closes DM-357
andrei.isvoran.ext commented 2023-08-08 15:51:13 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

requested review from @ali.oezyetimoglu1, @corina.olariu.ext1, @dominique.eiflaender1, @kilian.schuettler1, and @timo.bejan.ext

requested review from @ali.oezyetimoglu1, @corina.olariu.ext1, @dominique.eiflaender1, @kilian.schuettler1, and @timo.bejan.ext
andrei.isvoran.ext commented 2023-08-08 15:51:13 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

assigned to @andrei.isvoran.ext

assigned to @andrei.isvoran.ext
kilian.schuettler1 commented 2023-08-08 16:30:00 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

The way i see it you didn't really change anything, just remove the return type.
I agree it was unnecessary, but you still need to somehow remember the ones, that did not get found and then add them into the RedactionLog directly, just like the persistence service did.

The way i see it you didn't really change anything, just remove the return type. I agree it was unnecessary, but you still need to somehow remember the ones, that did not get found and then add them into the RedactionLog directly, just like the persistence service did.
timo.bejan.ext commented 2023-08-08 17:16:44 +02:00 (Migrated from gitlab.knecon.com)
Copy Link

mentioned in commit 6168644730

mentioned in commit 616864473026946209e7fdbd0e4fb35e848aa148
timo.bejan.ext (Migrated from gitlab.knecon.com) merged commit 6168644730 into master 2023-08-08 17:16:44 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
renovate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Marmelator
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Marmelator/redaction-service#85
No description provided.
Delete Branch "DM-357"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?